Re: [PATCH v5 30/33] nvdimm acpi: support Set Namespace Label Data function

[Stefan Hajnoczi]

On Wed, Oct 28, 2015 at 10:26:28PM +, Xiao Guangrong wrote:
> +static void nvdimm_dsm_func_set_label_data(NVDIMMDevice *nvdimm,
> +   nvdimm_dsm_in *in, GArray *out)
> +{
> +NVDIMMClass *nvc = NVDIMM_GET_CLASS(nvdimm);
> +nvdimm_func_in_set_label_data *set_label_data = >func_set_label_data;
> +uint32_t status;
> +
> +le32_to_cpus(_label_data->offset);
> +le32_to_cpus(_label_data->length);
> +
> +nvdimm_debug("Write Label Data: offset %#x length %#x.\n",
> + set_label_data->offset, set_label_data->length);
> +
> +if (nvdimm->label_size < set_label_data->offset + 
> set_label_data->length) {

Integer overflow.


signature.asc
Description: PGP signature

Re: [PATCH v5 30/33] nvdimm acpi: support Set Namespace Label Data function

[Xiao Guangrong]

On 10/29/2015 12:48 AM, Stefan Hajnoczi wrote:

On Wed, Oct 28, 2015 at 10:26:28PM +, Xiao Guangrong wrote:

+static void nvdimm_dsm_func_set_label_data(NVDIMMDevice *nvdimm,
+   nvdimm_dsm_in *in, GArray *out)
+{
+NVDIMMClass *nvc = NVDIMM_GET_CLASS(nvdimm);
+nvdimm_func_in_set_label_data *set_label_data = >func_set_label_data;
+uint32_t status;
+
+le32_to_cpus(_label_data->offset);
+le32_to_cpus(_label_data->length);
+
+nvdimm_debug("Write Label Data: offset %#x length %#x.\n",
+ set_label_data->offset, set_label_data->length);
+
+if (nvdimm->label_size < set_label_data->offset + set_label_data->length) {


Integer overflow.



Will fix it too.

Really appreciate for your review, Stefan!
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html