Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 10/29/2015 07:41 PM, Lan Tianyu wrote: On 2015年10月30日 00:17, Alexander Duyck wrote: On 10/29/2015 01:33 AM, Lan Tianyu wrote: On 2015年10月29日 14:58, Alexander Duyck wrote: Your code was having to do a bunch of shuffling in order to get things set up so that you could bring the interface

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 10/29/2015 01:33 AM, Lan Tianyu wrote: On 2015年10月29日 14:58, Alexander Duyck wrote: Your code was having to do a bunch of shuffling in order to get things set up so that you could bring the interface back up. I would argue that it may actually be faster at least on the bring-up to just drop

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 2015年10月26日 23:03, Alexander Duyck wrote: > No. I think you are missing the fact that there are 256 descriptors per > page. As such if you dirty just 1 you will be pulling in 255 more, of > which you may or may not have pulled in the receive buffer for. > > So for example if you have the

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 10/28/2015 11:12 PM, Lan Tianyu wrote: On 2015年10月26日 23:03, Alexander Duyck wrote: No. I think you are missing the fact that there are 256 descriptors per page. As such if you dirty just 1 you will be pulling in 255 more, of which you may or may not have pulled in the receive buffer for.

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 2015年10月29日 14:58, Alexander Duyck wrote: > > Your code was having to do a bunch of shuffling in order to get things > set up so that you could bring the interface back up. I would argue > that it may actually be faster at least on the bring-up to just drop the > old rings and start over

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 2015年10月30日 00:17, Alexander Duyck wrote: > On 10/29/2015 01:33 AM, Lan Tianyu wrote: >> On 2015年10月29日 14:58, Alexander Duyck wrote: >>> Your code was having to do a bunch of shuffling in order to get things >>> set up so that you could bring the interface back up. I would argue >>> that it

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 10/25/2015 10:36 PM, Lan Tianyu wrote: On 2015年10月24日 02:36, Alexander Duyck wrote: I was thinking about it and I am pretty sure the dummy write approach is problematic at best. Specifically the issue is that while you are performing a dummy write you risk pulling in descriptors for data

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 2015年10月24日 02:36, Alexander Duyck wrote: > I was thinking about it and I am pretty sure the dummy write approach is > problematic at best. Specifically the issue is that while you are > performing a dummy write you risk pulling in descriptors for data that > hasn't been dummy written to yet.

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 10/21/2015 09:37 AM, Lan Tianyu wrote: This patchset is to propose a new solution to add live migration support for 82599 SRIOV network card. Im our solution, we prefer to put all device specific operation into VF and PF driver and make code in the Qemu more general. VF status migration

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On Fri, 2015-10-23 at 11:36 -0700, Alexander Duyck wrote: > On 10/21/2015 09:37 AM, Lan Tianyu wrote: > > This patchset is to propose a new solution to add live migration support > > for 82599 > > SRIOV network card. > > > > Im our solution, we prefer to put all device specific operation into VF

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 10/23/2015 12:05 PM, Alex Williamson wrote: On Fri, 2015-10-23 at 11:36 -0700, Alexander Duyck wrote: On 10/21/2015 09:37 AM, Lan Tianyu wrote: This patchset is to propose a new solution to add live migration support for 82599 SRIOV network card. Im our solution, we prefer to put all

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On Wed, Oct 21, 2015 at 10:20 PM, Alex Williamson wrote: > This is why the typical VF agnostic approach here is to using bonding > and fail over to a emulated device during migration, so performance > suffers, but downtime is something acceptable. bonding in the VM

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On Thu, 2015-10-22 at 18:58 +0300, Or Gerlitz wrote: > On Wed, Oct 21, 2015 at 10:20 PM, Alex Williamson > wrote: > > > This is why the typical VF agnostic approach here is to using bonding > > and fail over to a emulated device during migration, so performance > >

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On Wed, Oct 21, 2015 at 7:37 PM, Lan Tianyu wrote: > This patchset is to propose a new solution to add live migration support > for 82599 SRIOV network card. > In our solution, we prefer to put all device specific operation into VF and > PF driver and make code in the Qemu

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On Wed, 2015-10-21 at 21:45 +0300, Or Gerlitz wrote: > On Wed, Oct 21, 2015 at 7:37 PM, Lan Tianyu wrote: > > This patchset is to propose a new solution to add live migration support > > for 82599 SRIOV network card. > > > In our solution, we prefer to put all device

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 10/21/2015 12:20 PM, Alex Williamson wrote: On Wed, 2015-10-21 at 21:45 +0300, Or Gerlitz wrote: On Wed, Oct 21, 2015 at 7:37 PM, Lan Tianyu wrote: This patchset is to propose a new solution to add live migration support for 82599 SRIOV network card. In our