Re: [kvm-unit-tests PATCH 00/18] bunch of mostly trivial patches
On Tue, Nov 10, 2015 at 11:54:22AM -0500, Andrew Jones wrote: > On Tue, Nov 10, 2015 at 05:38:38PM +0100, Paolo Bonzini wrote: > > > > > > On 06/11/2015 01:24, Andrew Jones wrote: > > > Many of these patches were posted once. Some weren't, but anyway > > > almost everything is pretty trivial. I'd like to get these in, or > > > at least get definitive nacks on them (and then drop them) in order > > > to clean my queue before more patches (coming from Alex Bennée and > > > Chistopher are reposted). > > > > > > All patches also available here > > > https://github.com/rhdrjones/kvm-unit-tests/commits/queue > > > > I applied all of these > > Thanks! > > > except 1 (question asked) and 14/15/16/17 (not sure I like the idea). Hi Paolo, Any more thoughts on these? I parsed "not sure I like" as "still thinking". Or should I parse it as a "no" and drop them from my queue? > > At one point I recall that you liked the uapi patches, although I'm > not 100% married to it myself, as it does add a new dependency. I'm > open to suggestions. Another argument for the uapi patches is that we're working on adding support for the mach-virt pcie host bridge in order to use pci-testdev in arm unit tests. We'll need to either use this series or import pci[_regs].h for that. > > I'm not sure what you're opposed to wrt to map files (patch 15). They > aren't 100% necessary, but don't really hurt either to generate either. > I won't fight for them though. I'm OK with dropping this one. The map files were useful to me once, but as rare as they would be, I agree cluttering things with them isn't a great idea. > > The TEST= patch is quite useful. I find it annoying to always have > to modify a makefile whenever I throw together a few line test. It > may not be for everyone, but then it doesn't do anything when it's > not used, so it shouldn't hurt that it exists. I would agree that > maybe the patch should also document it though, if you argued that. > Or, that fact that it's undocumented, and does nothing when not used, > could be an argument to just commit it :-) I still like this one. I'll buy you a beer for it :-) Thanks, drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [kvm-unit-tests PATCH 00/18] bunch of mostly trivial patches
On 06/11/2015 01:24, Andrew Jones wrote: > Many of these patches were posted once. Some weren't, but anyway > almost everything is pretty trivial. I'd like to get these in, or > at least get definitive nacks on them (and then drop them) in order > to clean my queue before more patches (coming from Alex Bennée and > Chistopher are reposted). > > All patches also available here > https://github.com/rhdrjones/kvm-unit-tests/commits/queue I applied all of these except 1 (question asked) and 14/15/16/17 (not sure I like the idea). Paolo > Thanks, > drew > > > Alex Bennée (4): > README: add some CONTRIBUTING notes > configure: emit HOST=$host to config.mak > lib/printf: support the %u unsigned fmt field > lib/arm: add flush_tlb_page mmu function > > Andrew Jones (13): > makefiles: use bash > trivial: lib: fail hard on failed mallocs > trivial: alloc: don't use 'top' outside spinlock > trivial: lib: missing extern in string.h > README: add pointer to new wiki page > run_tests: pass test name to run script > arm/run: use ACCEL to choose between kvm and tcg > run_tests: probe for max-smp > arm/arm64: allow building a single test > arm/arm64: generate map files > lib: link in linux kernel headers (uapi) > Revert "arm/arm64: import include/uapi/linux/psci.h" > arm/arm64: uart0_init: check /chosen/stdout-path > > Christopher Covington (1): > arm: Fail on unknown subtest > > .gitignore | 2 ++ > Makefile | 6 ++-- > README | 32 +++ > arm/run | 43 ++ > arm/selftest.c | 3 ++ > arm/unittests.cfg| 7 +++-- > config/config-arm-common.mak | 9 +- > configure| 11 +++ > lib/alloc.c | 8 +++-- > lib/arm/asm/mmu.h| 11 +++ > lib/arm/asm/page.h | 2 +- > lib/arm/asm/psci.h | 2 +- > lib/arm/asm/uapi-psci.h | 73 > > lib/arm/io.c | 36 -- > lib/arm64/asm/mmu.h | 8 + > lib/arm64/asm/page.h | 2 +- > lib/arm64/asm/psci.h | 2 +- > lib/arm64/asm/uapi-psci.h| 1 - > lib/asm-generic/page.h | 2 +- > lib/const.h | 11 --- > lib/printf.c | 13 > lib/string.h | 2 +- > lib/virtio-mmio.c| 7 ++--- > run_tests.sh | 12 +++- > scripts/functions.bash | 8 +++-- > scripts/mkstandalone.sh | 22 ++--- > x86/unittests.cfg| 1 + > 27 files changed, 210 insertions(+), 126 deletions(-) > delete mode 100644 lib/arm/asm/uapi-psci.h > delete mode 100644 lib/arm64/asm/uapi-psci.h > delete mode 100644 lib/const.h > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [kvm-unit-tests PATCH 00/18] bunch of mostly trivial patches
On Tue, Nov 10, 2015 at 05:38:38PM +0100, Paolo Bonzini wrote: > > > On 06/11/2015 01:24, Andrew Jones wrote: > > Many of these patches were posted once. Some weren't, but anyway > > almost everything is pretty trivial. I'd like to get these in, or > > at least get definitive nacks on them (and then drop them) in order > > to clean my queue before more patches (coming from Alex Bennée and > > Chistopher are reposted). > > > > All patches also available here > > https://github.com/rhdrjones/kvm-unit-tests/commits/queue > > I applied all of these Thanks! > except 1 (question asked) and 14/15/16/17 (not sure I like the idea). At one point I recall that you liked the uapi patches, although I'm not 100% married to it myself, as it does add a new dependency. I'm open to suggestions. I'm not sure what you're opposed to wrt to map files (patch 15). They aren't 100% necessary, but don't really hurt either to generate either. I won't fight for them though. The TEST= patch is quite useful. I find it annoying to always have to modify a makefile whenever I throw together a few line test. It may not be for everyone, but then it doesn't do anything when it's not used, so it shouldn't hurt that it exists. I would agree that maybe the patch should also document it though, if you argued that. Or, that fact that it's undocumented, and does nothing when not used, could be an argument to just commit it :-) Thanks, drew > > Paolo > > > Thanks, > > drew > > > > > > Alex Bennée (4): > > README: add some CONTRIBUTING notes > > configure: emit HOST=$host to config.mak > > lib/printf: support the %u unsigned fmt field > > lib/arm: add flush_tlb_page mmu function > > > > Andrew Jones (13): > > makefiles: use bash > > trivial: lib: fail hard on failed mallocs > > trivial: alloc: don't use 'top' outside spinlock > > trivial: lib: missing extern in string.h > > README: add pointer to new wiki page > > run_tests: pass test name to run script > > arm/run: use ACCEL to choose between kvm and tcg > > run_tests: probe for max-smp > > arm/arm64: allow building a single test > > arm/arm64: generate map files > > lib: link in linux kernel headers (uapi) > > Revert "arm/arm64: import include/uapi/linux/psci.h" > > arm/arm64: uart0_init: check /chosen/stdout-path > > > > Christopher Covington (1): > > arm: Fail on unknown subtest > > > > .gitignore | 2 ++ > > Makefile | 6 ++-- > > README | 32 +++ > > arm/run | 43 ++ > > arm/selftest.c | 3 ++ > > arm/unittests.cfg| 7 +++-- > > config/config-arm-common.mak | 9 +- > > configure| 11 +++ > > lib/alloc.c | 8 +++-- > > lib/arm/asm/mmu.h| 11 +++ > > lib/arm/asm/page.h | 2 +- > > lib/arm/asm/psci.h | 2 +- > > lib/arm/asm/uapi-psci.h | 73 > > > > lib/arm/io.c | 36 -- > > lib/arm64/asm/mmu.h | 8 + > > lib/arm64/asm/page.h | 2 +- > > lib/arm64/asm/psci.h | 2 +- > > lib/arm64/asm/uapi-psci.h| 1 - > > lib/asm-generic/page.h | 2 +- > > lib/const.h | 11 --- > > lib/printf.c | 13 > > lib/string.h | 2 +- > > lib/virtio-mmio.c| 7 ++--- > > run_tests.sh | 12 +++- > > scripts/functions.bash | 8 +++-- > > scripts/mkstandalone.sh | 22 ++--- > > x86/unittests.cfg| 1 + > > 27 files changed, 210 insertions(+), 126 deletions(-) > > delete mode 100644 lib/arm/asm/uapi-psci.h > > delete mode 100644 lib/arm64/asm/uapi-psci.h > > delete mode 100644 lib/const.h > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
