Re: [PATCH v3 04/10] VFIO: platform: add vfio_platform_set_automasked

2015-08-31 Thread Alex Williamson
On Mon, 2015-08-31 at 13:43 +0200, Antonios Motakis wrote: > > On 18-Aug-15 19:44, Alex Williamson wrote: > > On Mon, 2015-08-17 at 17:38 +0200, Eric Auger wrote: > >> On 08/12/2015 08:56 PM, Alex Williamson wrote: > >>> On Mon, 2015-08-10 at 15:20 +0200, Eric Auger wrote: > This function

Re: [RFC PATCH v3 0/3] vfio: platform: return device properties for a platform device

2015-08-31 Thread Christoffer Dall
On Mon, Aug 31, 2015 at 07:02:15PM +0200, Eric Auger wrote: > Hi Christoffer, > On 08/30/2015 04:06 PM, Christoffer Dall wrote: > > Hi Eric, > > > > On Thu, Aug 27, 2015 at 07:16:00PM +0200, Eric Auger wrote: > >> Hi Alex, > >> On 08/27/2015 06:11 PM, Alex Williamson wrote: > >>> On Thu,

Re: [RFC PATCH v3 0/3] vfio: platform: return device properties for a platform device

2015-08-31 Thread Eric Auger
Hi Christoffer, On 08/30/2015 04:06 PM, Christoffer Dall wrote: > Hi Eric, > > On Thu, Aug 27, 2015 at 07:16:00PM +0200, Eric Auger wrote: >> Hi Alex, >> On 08/27/2015 06:11 PM, Alex Williamson wrote: >>> On Thu, 2015-08-27 at 14:52 +0200, Eric Auger wrote: Hi Baptiste, Antonios,

Re: [PATCH 13/13] arm64: KVM: VHE: Early interrupt handling

2015-08-31 Thread Christoffer Dall
On Wed, Jul 08, 2015 at 05:19:16PM +0100, Marc Zyngier wrote: > With VHE enabled, it is possible to let the kernel handle an interrupt > without saving the full guest context, and without restoring the full > host context either. This reduces the latency of handling an interrupt. > > When an

Re: [PATCH 9/9] arm/arm64: KVM: arch timer: Reset CNTV_CTL to 0

2015-08-31 Thread Ard Biesheuvel
On 30 August 2015 at 15:54, Christoffer Dall wrote: > Provide a better quality of implementation and be architecture compliant > on ARMv7 for the architected timer by resetting the CNTV_CTL to 0 on > reset of the timer, and call kvm_timer_update_state(vcpu) at the

RE: [PATCH 1/3] KVM: arm64: Implement vGICv3 distributor and redistributor access from userspace

2015-08-31 Thread Pavel Fedin
Hello! > > + len = vgic_v3_get_reg_size(attr); > > + if (len < 0) > > + return len; > > > > - return -ENXIO; > > + ret = vgic_v3_attr_regs_access(dev, attr, (len == 8) ? (void *) : > > + (void *), len, false); > > this use of the ternary

Re: [PATCH v2 01/15] KVM: arm/arm64: VGIC: don't track used LRs in the distributor

2015-08-31 Thread Eric Auger
On 08/24/2015 06:33 PM, Andre Przywara wrote: > Hi Eric, > > On 12/08/15 10:01, Eric Auger wrote: > >>> diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c >>> index bc40137..394622c 100644 >>> --- a/virt/kvm/arm/vgic.c >>> +++ b/virt/kvm/arm/vgic.c >>> @@ -79,7 +79,6 @@ >>> #include

RE: [PATCH 3/3] KVM: arm64: Implement accessors for vGIC CPU interface registers

2015-08-31 Thread Pavel Fedin
Hello! > > I had imagined we would encode the GICv3 register accesses through the > > device API and not through the system register API, since I'm not crazy > > about polluting the general system register handling logic with GIC > > registers solely for the purposes of migration. > > There's

RE: [PATCH] KVM: arm64: Decode basic HYP fault information

2015-08-31 Thread Pavel Fedin
Hello! > my overall concern with this patch is that it adds complexity to an > already really bad situation, and potentially increases the likelihood > of not seeing any debug info at all. Why? In this case we currently already drop into C code. I do the same, with some more useful printout.

Re: [PATCH 3/3] KVM: arm64: Implement accessors for vGIC CPU interface registers

2015-08-31 Thread Christoffer Dall
On Mon, Aug 31, 2015 at 10:43:27AM +0300, Pavel Fedin wrote: > Hello! > > > > I had imagined we would encode the GICv3 register accesses through the > > > device API and not through the system register API, since I'm not crazy > > > about polluting the general system register handling logic with

Re: [PATCH v2 12/15] KVM: arm64: sync LPI configuration and pending tables

2015-08-31 Thread Eric Auger
On 08/25/2015 05:27 PM, Andre Przywara wrote: > Hi Eric, > > On 14/08/15 12:58, Eric Auger wrote: >> On 07/10/2015 04:21 PM, Andre Przywara wrote: >>> The LPI configuration and pending tables of the GICv3 LPIs are held >>> in tables in (guest) memory. To achieve reasonable performance, we >>>

Re: [PATCH v2 11/15] KVM: arm64: handle pending bit for LPIs in ITS emulation

2015-08-31 Thread Eric Auger
On 08/25/2015 04:34 PM, Andre Przywara wrote: > Hi Eric, > > On 14/08/15 12:58, Eric Auger wrote: >> On 07/10/2015 04:21 PM, Andre Przywara wrote: >>> As the actual LPI number in a guest can be quite high, but is mostly >>> assigned using a very sparse allocation scheme, bitmaps and arrays >>>

Re: [PATCH 9/9] arm/arm64: KVM: arch timer: Reset CNTV_CTL to 0

2015-08-31 Thread Christoffer Dall
On Mon, Aug 31, 2015 at 10:46:59AM +0200, Ard Biesheuvel wrote: > On 30 August 2015 at 15:54, Christoffer Dall > wrote: > > Provide a better quality of implementation and be architecture compliant > > on ARMv7 for the architected timer by resetting the CNTV_CTL to 0

Re: [PATCH 1/3] KVM: arm64: Implement vGICv3 distributor and redistributor access from userspace

2015-08-31 Thread Christoffer Dall
On Mon, Aug 31, 2015 at 10:35:05AM +0300, Pavel Fedin wrote: > Hello! > > > > + len = vgic_v3_get_reg_size(attr); > > > + if (len < 0) > > > + return len; > > > > > > - return -ENXIO; > > > + ret = vgic_v3_attr_regs_access(dev, attr, (len == 8) ? (void *) : > > > +

Re: [PATCH v3 04/10] VFIO: platform: add vfio_platform_set_automasked

2015-08-31 Thread Antonios Motakis
On 18-Aug-15 19:44, Alex Williamson wrote: > On Mon, 2015-08-17 at 17:38 +0200, Eric Auger wrote: >> On 08/12/2015 08:56 PM, Alex Williamson wrote: >>> On Mon, 2015-08-10 at 15:20 +0200, Eric Auger wrote: This function makes possible to change the automasked mode. Signed-off-by: