Re: [RFC PATCH 03/12] arm64: kvm: Cleanup VTCR_EL2/VTTBR computation

2016-03-19 Thread Marc Zyngier
On Wed, 16 Mar 2016 15:37:18 + "Suzuki K. Poulose" wrote: > On 16/03/16 15:01, Marc Zyngier wrote: > > On 14/03/16 16:53, Suzuki K Poulose wrote: > >> No functional changes. Group the common bits for VCTR_EL2 > >> initialisation for better readability. The granule

Re: [RFC PATCH 02/12] arm64: kvm: Fix {V}TCR_EL2_TG0 mask

2016-03-19 Thread Marc Zyngier
On 14/03/16 16:53, Suzuki K Poulose wrote: > {V}TCR_EL2_TG0 is a 2bit wide field, where: > > 00 - 4K > 01 - 64K > 10 - 16K > > But we use only 1 bit, which has worked well so far since > we never cared about 16K. Fix it for 16K support. > > Cc: Catalin Marinas > Cc:

Re: [PATCH v3 5/9] irqchip/gic-v3: Gather all ACPI specific data in a single structure

2016-03-19 Thread Christoffer Dall
On Tue, Mar 15, 2016 at 12:26:29PM +, Julien Grall wrote: > Hi Christoffer, > > On 09/03/16 05:39, Christoffer Dall wrote: > >On Tue, Mar 08, 2016 at 11:29:29AM +, Julien Grall wrote: > >>Even though all the variables aren't marked with __initdata, they are > >>only used during

Re: [PATCH v3 00/16] KVM: arm64: GICv3 ITS emulation

2016-03-19 Thread Christoffer Dall
On Mon, Mar 14, 2016 at 05:29:44PM +, Peter Maydell wrote: > On 14 March 2016 at 11:13, Andre Przywara wrote: > > So I see two ways to fix this: > > 1.) we find a KVM specific way of letting userland save and restore the > > ITS tables directly > > 2.) we implement the

Re: [PATCH v3 00/16] KVM: arm64: GICv3 ITS emulation

2016-03-19 Thread Peter Maydell
On 18 March 2016 at 09:40, Christoffer Dall wrote: > On Mon, Mar 14, 2016 at 06:20:36PM +, Andre Przywara wrote: >> Well, probably there is not so much difference. I was just wondering if >> it would be easier to treat that data as an opaque blob. >> But you are

Re: [RFC PATCH 03/12] arm64: kvm: Cleanup VTCR_EL2/VTTBR computation

2016-03-19 Thread Marc Zyngier
On 14/03/16 16:53, Suzuki K Poulose wrote: > No functional changes. Group the common bits for VCTR_EL2 > initialisation for better readability. The granule size > and the entry level are controlled by the page size. > > Cc: Christoffer Dall > Cc: Marc Zyngier

Re: [RFC PATCH 02/12] arm64: kvm: Fix {V}TCR_EL2_TG0 mask

2016-03-19 Thread Suzuki K. Poulose
On 16/03/16 14:54, Marc Zyngier wrote: On 14/03/16 16:53, Suzuki K Poulose wrote: {V}TCR_EL2_TG0 is a 2bit wide field, where: 00 - 4K 01 - 64K 10 - 16K But we use only 1 bit, which has worked well so far since we never cared about 16K. Fix it for 16K support. ---

Re: [PATCH v3 00/16] KVM: arm64: GICv3 ITS emulation

2016-03-19 Thread Christoffer Dall
On Mon, Mar 14, 2016 at 06:20:36PM +, Andre Przywara wrote: > Hi, > > On 14/03/16 17:54, Marc Zyngier wrote: > > On 14/03/16 17:29, Peter Maydell wrote: > >> On 14 March 2016 at 11:13, Andre Przywara wrote: > >>> So I see two ways to fix this: > >>> 1.) we find a KVM

Re: [PATCH] arm64: KVM: Turn kvm_ksym_ref into a NOP on VHE

2016-03-19 Thread Robin Murphy
Hi Marc, On 18/03/16 17:25, Marc Zyngier wrote: When running with VHE, there is no need to translate kernel pointers to the EL2 memory space, since we're already there (and we have a much saner memory map to start with). Unfortunately, kvm_ksym_ref is getting in the way, and the first call