Re: [PATCH 26/45] KVM: arm/arm64: vgic-new: Add GICv3 IDREGS register handler

2016-04-19 Thread Peter Maydell
On 19 April 2016 at 13:57, André Przywara wrote: > Hi Peter, > > thanks for going through the pain of looking into this! No problem -- I figured I might as well while I have my head full of the GICv3 spec for the QEMU emulated version. > On 19/04/16 13:34, Peter Maydell wrote: >> We claim to be

Re: [PATCH 26/45] KVM: arm/arm64: vgic-new: Add GICv3 IDREGS register handler

2016-04-19 Thread André Przywara
Hi Peter, thanks for going through the pain of looking into this! On 19/04/16 13:34, Peter Maydell wrote: > On 15 April 2016 at 18:11, Andre Przywara wrote: >> Signed-off-by: Andre Przywara >> --- >> virt/kvm/arm/vgic/vgic_mmio.c | 21 +++-- >> 1 file changed, 19 insertions(+),

Re: [PATCH 28/45] KVM: arm/arm64: vgic-new: Add GICv3 SGI system register trap handler

2016-04-19 Thread Peter Maydell
On 15 April 2016 at 18:11, Andre Przywara wrote: > In contrast to GICv2 SGIs in a GICv3 implementation are not triggered > by a MMIO write, but with a system register write. KVM knows about > that register already, we just need to implement the handler and wire > it up to the core KVM/ARM code. >

Re: [PATCH 26/45] KVM: arm/arm64: vgic-new: Add GICv3 IDREGS register handler

2016-04-19 Thread Peter Maydell
On 15 April 2016 at 18:11, Andre Przywara wrote: > Signed-off-by: Andre Przywara > --- > virt/kvm/arm/vgic/vgic_mmio.c | 21 +++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/arm/vgic/vgic_mmio.c b/virt/kvm/arm/vgic/vgic_mmio.c > index 7d275a7..da

Re: [PATCH 24/45] KVM: arm/arm64: vgic-new: Add GICv3 CTLR, IIDR, TYPER handlers

2016-04-19 Thread Peter Maydell
On 15 April 2016 at 18:11, Andre Przywara wrote: > As in the GICv2 emulation we handle those three registers in one > function. > > Signed-off-by: Andre Przywara > > Changelog RFC..v1: > - kick VCPUs if distributor gets enabled > --- > virt/kvm/arm/vgic/vgic.h | 2 ++ > virt/kvm/arm/vgic/v

Re: [PATCH 00/45] KVM: arm/arm64: Rework virtual GIC emulation

2016-04-19 Thread Vladimir Murzin
On 19/04/16 11:26, Andre Przywara wrote: > Hi Vladimir, > > can you try the attached patch on top of the series to see if this > fixes the GICv3 emulation issues you see? > With attached patch I don't see issue any more - all 255 vcpus are able to boot and send/receive self SGI. Thanks Vladimir

Re: [PATCH 00/45] KVM: arm/arm64: Rework virtual GIC emulation

2016-04-19 Thread Andre Przywara
Hi Vladimir, can you try the attached patch on top of the series to see if this fixes the GICv3 emulation issues you see? I think these lines got lost during the MMIO framework rebasing. Cheers, Andre. --- virt/kvm/arm/vgic/vgic_mmio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/virt