Re: [PATCH v3] KVM: arm/arm64: Add VGICv3 save/restore API documentation

2016-05-13 Thread Peter Maydell
On 13 May 2016 at 15:43, Christoffer Dall wrote: > Factor out the GICv3-specific documentation into a separate > documentation file. Add description for how to access distributor, > redistributor, and CPU interface registers for GICv3 in this new file, > and add a group for accesing level trigger

Re: [PATCH v3] KVM: arm/arm64: Add VGICv3 save/restore API documentation

2016-05-13 Thread Marc Zyngier
On 13/05/16 15:43, Christoffer Dall wrote: > Factor out the GICv3-specific documentation into a separate > documentation file. Add description for how to access distributor, > redistributor, and CPU interface registers for GICv3 in this new file, > and add a group for accesing level triggered IRQ

[PATCH v3] KVM: arm/arm64: Add VGICv3 save/restore API documentation

2016-05-13 Thread Christoffer Dall
Factor out the GICv3-specific documentation into a separate documentation file. Add description for how to access distributor, redistributor, and CPU interface registers for GICv3 in this new file, and add a group for accesing level triggered IRQ information for GICv3 as well. Signed-off-by: Chri

Re: [PATCH v3 47/55] KVM: arm/arm64: vgic-new: Add userland GIC CPU interface access

2016-05-13 Thread Christoffer Dall
On Fri, May 13, 2016 at 01:23:02PM +0100, Andre Przywara wrote: > Hi, > > On 13/05/16 12:54, Christoffer Dall wrote: > > On Fri, May 13, 2016 at 11:44:38AM +0100, Andre Przywara wrote: > >> Hi, > >> > >> On 13/05/16 08:53, Christoffer Dall wrote: > >>> On Thu, May 12, 2016 at 07:52:38PM +0100, And

Re: [PATCH v3 43/55] KVM: arm/arm64: vgic-new: vgic_kvm_device: access to VGIC registers

2016-05-13 Thread Marc Zyngier
On 13/05/16 13:24, Andre Przywara wrote: > Hi, > > On 12/05/16 19:30, Christoffer Dall wrote: >> On Fri, May 06, 2016 at 11:45:56AM +0100, Andre Przywara wrote: >>> From: Eric Auger >>> >>> This patch implements the switches for KVM_DEV_ARM_VGIC_GRP_DIST_REGS >>> and KVM_DEV_ARM_VGIC_GRP_CPU_REGS

Re: [PATCH v3 43/55] KVM: arm/arm64: vgic-new: vgic_kvm_device: access to VGIC registers

2016-05-13 Thread Christoffer Dall
On Fri, May 13, 2016 at 01:24:07PM +0100, Andre Przywara wrote: > Hi, > > On 12/05/16 19:30, Christoffer Dall wrote: > > On Fri, May 06, 2016 at 11:45:56AM +0100, Andre Przywara wrote: > >> From: Eric Auger > >> > >> This patch implements the switches for KVM_DEV_ARM_VGIC_GRP_DIST_REGS > >> and K

Re: [PATCH v3 43/55] KVM: arm/arm64: vgic-new: vgic_kvm_device: access to VGIC registers

2016-05-13 Thread Andre Przywara
Hi, On 12/05/16 19:30, Christoffer Dall wrote: > On Fri, May 06, 2016 at 11:45:56AM +0100, Andre Przywara wrote: >> From: Eric Auger >> >> This patch implements the switches for KVM_DEV_ARM_VGIC_GRP_DIST_REGS >> and KVM_DEV_ARM_VGIC_GRP_CPU_REGS API which allows the userspace to >> access VGIC re

Re: [PATCH v3 47/55] KVM: arm/arm64: vgic-new: Add userland GIC CPU interface access

2016-05-13 Thread Andre Przywara
Hi, On 13/05/16 12:54, Christoffer Dall wrote: > On Fri, May 13, 2016 at 11:44:38AM +0100, Andre Przywara wrote: >> Hi, >> >> On 13/05/16 08:53, Christoffer Dall wrote: >>> On Thu, May 12, 2016 at 07:52:38PM +0100, Andre Przywara wrote: Hi, On 12/05/16 19:47, Christoffer Dall wrote:

Re: [PATCH v3 47/55] KVM: arm/arm64: vgic-new: Add userland GIC CPU interface access

2016-05-13 Thread Christoffer Dall
On Fri, May 13, 2016 at 11:44:38AM +0100, Andre Przywara wrote: > Hi, > > On 13/05/16 08:53, Christoffer Dall wrote: > > On Thu, May 12, 2016 at 07:52:38PM +0100, Andre Przywara wrote: > >> Hi, > >> > >> On 12/05/16 19:47, Christoffer Dall wrote: > >>> On Fri, May 06, 2016 at 11:46:00AM +0100, And

Re: [PATCH v3 47/55] KVM: arm/arm64: vgic-new: Add userland GIC CPU interface access

2016-05-13 Thread Andre Przywara
Hi, On 13/05/16 08:53, Christoffer Dall wrote: > On Thu, May 12, 2016 at 07:52:38PM +0100, Andre Przywara wrote: >> Hi, >> >> On 12/05/16 19:47, Christoffer Dall wrote: >>> On Fri, May 06, 2016 at 11:46:00AM +0100, Andre Przywara wrote: Using the VMCR accessors we provide access to GIC CPU in

Re: [PATCH v3 42/55] KVM: arm/arm64: vgic-new: vgic_kvm_device: KVM_DEV_ARM_VGIC_GRP_ADDR

2016-05-13 Thread Christoffer Dall
On Fri, May 06, 2016 at 11:45:55AM +0100, Andre Przywara wrote: > From: Eric Auger > > This patch implements the KVM_DEV_ARM_VGIC_GRP_ADDR group which > enables to set the base address of GIC regions as seen by the guest. > > Signed-off-by: Eric Auger > Signed-off-by: Andre Przywara > --- > v

Re: [PATCH v3 41/55] KVM: arm/arm64: vgic-new: vgic_kvm_device: implement kvm_vgic_addr

2016-05-13 Thread Christoffer Dall
On Fri, May 06, 2016 at 11:45:54AM +0100, Andre Przywara wrote: > From: Eric Auger > > kvm_vgic_addr is used by the userspace to set the base address of > the following register regions, as seen by the guest: > - distributor(v2 and v3), > - re-distributors (v3), > - CPU interface (v2). > > Signe

Re: [PATCH v3 40/55] KVM: arm/arm64: vgic-new: vgic_kvm_device: KVM_DEV_ARM_VGIC_GRP_CTRL

2016-05-13 Thread Christoffer Dall
On Fri, May 06, 2016 at 11:45:53AM +0100, Andre Przywara wrote: > From: Eric Auger > > This patch implements the KVM_DEV_ARM_VGIC_GRP_CTRL group API > featuring KVM_DEV_ARM_VGIC_CTRL_INIT attribute. The vgic_init > function is not yet implemented though. > > Signed-off-by: Eric Auger > Signed-o

Re: [PATCH v3 38/55] KVM: arm/arm64: vgic-new: vgic_kvm_device: KVM device ops registration

2016-05-13 Thread Christoffer Dall
On Fri, May 06, 2016 at 11:45:51AM +0100, Andre Przywara wrote: > From: Eric Auger > > This patch introduces the skeleton for the KVM device operations > associated to KVM_DEV_TYPE_ARM_VGIC_V2 and KVM_DEV_TYPE_ARM_VGIC_V3. > > At that stage kvm_vgic_create is stubbed. > > Signed-off-by: Eric Au

Re: [PATCH v3 39/55] KVM: arm/arm64: vgic-new: vgic_kvm_device: KVM_DEV_ARM_VGIC_GRP_NR_IRQS

2016-05-13 Thread Christoffer Dall
On Fri, May 06, 2016 at 11:45:52AM +0100, Andre Przywara wrote: > From: Eric Auger > > This patch implements the KVM_DEV_ARM_VGIC_GRP_NR_IRQS group. This > modality is supported by both VGIC V2 and V3 KVM device as will be > other groups, hence the introduction of common helpers. > > Signed-off-

Re: [PATCH v2] KVM: arm/arm64: vgic-new: Switch to firmware-independent probing

2016-05-13 Thread Marc Zyngier
On 12/05/16 20:02, Christoffer Dall wrote: > On Tue, May 10, 2016 at 09:46:23AM +0100, Marc Zyngier wrote: >> As we did for the legacy code, switch the new VGIC implementation >> the firmware-independent probing, giving us ACPI support for free. >> >> Signed-off-by: Marc Zyngier > > So just remem

Re: [PATCH v3 47/55] KVM: arm/arm64: vgic-new: Add userland GIC CPU interface access

2016-05-13 Thread Christoffer Dall
On Thu, May 12, 2016 at 07:52:38PM +0100, Andre Przywara wrote: > Hi, > > On 12/05/16 19:47, Christoffer Dall wrote: > > On Fri, May 06, 2016 at 11:46:00AM +0100, Andre Przywara wrote: > >> Using the VMCR accessors we provide access to GIC CPU interface state > >> to userland by wiring it up to th

Re: [PATCH v3 45/55] KVM: arm/arm64: vgic-new: Add userland access to VGIC dist registers

2016-05-13 Thread Christoffer Dall
On Thu, May 12, 2016 at 08:10:21PM +0100, Andre Przywara wrote: > Hi, > > On 12/05/16 19:41, Christoffer Dall wrote: > > On Fri, May 06, 2016 at 11:45:58AM +0100, Andre Przywara wrote: > >> Userland may want to save and restore the state of the in-kernel VGIC, > >> so we provide the code which tak