Re: [PATCH v3 12/19] KVM: arm64: ITS: vgic_its_alloc_ite/device

2017-03-17 Thread Andre Przywara
Hi, On 06/03/17 11:34, Eric Auger wrote: > Add two new helpers to allocate an its ite and an its device. > This will avoid duplication on restore path. > > Signed-off-by: Eric Auger > > --- > > v1 -> v2: > - report itt_size fix and remove ITE_SIZE > - s/itte/ite/g > --- > virt/kvm/arm/vgic/vg

Re: [PATCH V12 05/10] acpi: apei: handle SEA notification type for ARMv8

2017-03-17 Thread James Morse
Hi Tyler, On 06/03/17 20:44, Tyler Baicar wrote: > ARM APEI extension proposal added SEA (Synchronous External Abort) > notification type for ARMv8. > Add a new GHES error source handling function for SEA. If an error > source's notification type is SEA, then this function can be registered > into

Re: [PATCH] KVM: arm/arm64: Signal SIGBUS when stage2 discovers hwpoison memory

2017-03-17 Thread James Morse
Hi Punit, On 17/03/17 15:06, Punit Agrawal wrote: > James Morse writes: >> Once we enable ARCH_SUPPORTS_MEMORY_FAILURE on arm64[0], notifications for >> broken memory can call memory_failure() in mm/memory-failure.c to deliver >> SIGBUS to any user space process using the page, and notify all the

Re: [PATCH v3 10/19] KVM: arm64: ITS: Check the device id matches TYPER DEVBITS range

2017-03-17 Thread Andre Przywara
Hi, On 06/03/17 11:34, Eric Auger wrote: > On MAPD we currently check the device id can be stored in the device table. > Let's first check it can be encoded within the range defined by TYPER > DEVBITS. > > Signed-off-by: Eric Auger > --- > virt/kvm/arm/vgic/vgic-its.c | 8 ++-- > 1 file cha

Re: [PATCH v3 09/19] KVM: arm64: ITS: Interpret MAPD ITT_addr field

2017-03-17 Thread Andre Przywara
On 06/03/17 11:34, Eric Auger wrote: > Up to now the MAPD ITT_addr had been ignored. We will need it > for save/restore. Let's record it in the its_device struct. > > Signed-off-by: Eric Auger > --- > virt/kvm/arm/vgic/vgic-its.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/virt

Re: [PATCH] KVM: arm/arm64: Signal SIGBUS when stage2 discovers hwpoison memory

2017-03-17 Thread Punit Agrawal
Hi James, One comment at the end. James Morse writes: > Once we enable ARCH_SUPPORTS_MEMORY_FAILURE on arm64[0], notifications for > broken memory can call memory_failure() in mm/memory-failure.c to deliver > SIGBUS to any user space process using the page, and notify all the > in-kernel users.

Re: [PATCH v3 08/19] KVM: arm64: ITS: Interpret MAPD Size field and check related errors

2017-03-17 Thread Andre Przywara
Hi, On 06/03/17 11:34, Eric Auger wrote: > Up to now the MAPD's ITT size field has been ignored. It encodes > the number of eventid bit minus 1. It should be used to check > the eventid when a MAPTI command is issued on a device. Let's > store the nb_eventid_bits in the its_device and do the check

Re: [PATCH v3 03/19] arm/arm64: vgic: turn vgic_find_mmio_region into public

2017-03-17 Thread Andre Przywara
Hi Eric, On 06/03/17 11:34, Eric Auger wrote: > We plan to use vgic_find_mmio_region in vgic-its.c so let's > turn it into a public function. Just a nit below, but for the patch: > Signed-off-by: Eric Auger Reviewed-by: Andre Przywara > --- > virt/kvm/arm/vgic/vgic-mmio.c | 3 +-- > virt/kv

Re: [PATCH v3 07/19] KVM: arm64: ITS: Report the ITE size in GITS_TYPER

2017-03-17 Thread Andre Przywara
On 06/03/17 11:34, Eric Auger wrote: > An ITE size of 8 Bytes is reported to the guest. Combining this > information with the number of event IDs the guest wants to support, > this latter will be able to allocate each device's ITT with the > right size. > > Signed-off-by: Eric Auger > > --- >

Re: [PATCH v3 00/25] arm/arm64: KVM: Rework the hyp-stub API

2017-03-17 Thread Russell King - ARM Linux
On Tue, Mar 14, 2017 at 04:09:44PM +, Marc Zyngier wrote: > On 14/03/17 16:05, Russell King - ARM Linux wrote: > > On Mon, Mar 06, 2017 at 02:24:33PM +, Marc Zyngier wrote: > >> As noticed by RMK in this thread[1], the hyp-stub API on 32bit ARM > >> could do with some TLC (it cannot perform

Re: KVM on ARM Cortex A53 in 32-bit Mode

2017-03-17 Thread Christoffer Dall
On Fri, Mar 17, 2017 at 01:09:22AM -0400, Yasutaka, T wrote: > 2017-03-16 5:38 GMT-04:00 Christoffer Dall : > > > On Wed, Mar 15, 2017 at 07:50:36PM -0400, Yasutaka, T wrote: > > > Hi Christopher and other KVM/ARM community members, > > > > > > I tried the following QEMU and Kernel combinations on

Re: [PATCH v2 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

2017-03-17 Thread Christoffer Dall
On Thu, Mar 16, 2017 at 06:20:51PM +, Suzuki K Poulose wrote: > In kvm_free_stage2_pgd() we don't hold the kvm->mmu_lock while calling > unmap_stage2_range() on the entire memory range for the guest. This could > cause problems with other callers (e.g, munmap on a memslot) trying to > unmap a r

Re: [PATCH] kvm: arm/arm64: Simplify lock relaxation in stage2_wp_range

2017-03-17 Thread Christoffer Dall
On Thu, Mar 16, 2017 at 06:24:34PM +, Suzuki K Poulose wrote: > From: Marc Zyngier > > Add checks to make sure that kvm->mmu_lock is held while calling > stage2_wp_range. Also avoid explicit checks already done by > cond_resched_lock(). > > Signed-off-by: Marc Zyngier > [ Added assert_spin