Re: [PATCH kvmtool v3 0/3] vfio-pci: Support INTx mode re-enabling

2019-04-02 Thread Leo Yan
Hi Will, On Tue, Apr 02, 2019 at 05:50:25PM +0100, Will Deacon wrote: > Hi Leo, > > On Tue, Mar 26, 2019 at 03:41:28PM +0800, Leo Yan wrote: > > When enable vfio-pci mode for NIC driver on Juno board, the IRQ is > > failed to forward properly from host to guest, finally root caused this > >

Re: [PATCH] KVM: arm/arm64: vgic-v3: Retire pending interrupts on disabling LPIs

2019-04-02 Thread Marc Zyngier
On Tue, 02 Apr 2019 15:43:31 +0100, Heyi Guo wrote: > > Hi Marc, > > The issue has been fixed after applying your patch. Excellent, thanks for testing it. I've now applied the final patch to the 5.1-fixes branch to get a bit more exposure before merging it to master. M. > > Thanks,

Re: [PATCH kvmtool v3 0/3] vfio-pci: Support INTx mode re-enabling

2019-04-02 Thread Will Deacon
Hi Leo, On Tue, Mar 26, 2019 at 03:41:28PM +0800, Leo Yan wrote: > When enable vfio-pci mode for NIC driver on Juno board, the IRQ is > failed to forward properly from host to guest, finally root caused this > issue is related with kvmtool cannot re-enable INTx mode properly. > > So the basic

Re: [PATCH] kvm: arm: Skip stage2 huge mappings for unaligned ipa backed by THP

2019-04-02 Thread Andrew Murray
On Tue, Apr 02, 2019 at 12:06:16PM +0100, Suzuki K Poulose wrote: > With commit a80868f398554842b14, we no longer ensure that the > THP page is properly aligned in the guest IPA. Skip the stage2 > huge mapping for unaligned IPA backed by transparent hugepages. > > Fixes: a80868f398554842b14

Re: [PATCH] KVM: arm/arm64: vgic-v3: Retire pending interrupts on disabling LPIs

2019-04-02 Thread Heyi Guo
Hi Marc, The issue has been fixed after applying your patch. Thanks, Heyi On 2019/4/2 17:32, Heyi Guo wrote: Thanks, I'll use this one for test. Heyi On 2019/4/2 16:48, Marc Zyngier wrote: On Tue, 02 Apr 2019 09:22:29 +0100, Auger Eric wrote: Hi Marc, On 4/2/19 9:24 AM, Marc Zyngier

Re: [PATCH] KVM: arm/arm64: vgic-v3: Retire pending interrupts on disabling LPIs

2019-04-02 Thread Auger Eric
Hi Marc, On 4/2/19 10:48 AM, Marc Zyngier wrote: > On Tue, 02 Apr 2019 09:22:29 +0100, > Auger Eric wrote: >> >> Hi Marc, >> >> On 4/2/19 9:24 AM, Marc Zyngier wrote: >>> When disabling LPIs (for example on reset) at the redistributor >>> level, it is expected that LPIs that was pending in the

[PATCH] kvm: arm: Skip stage2 huge mappings for unaligned ipa backed by THP

2019-04-02 Thread Suzuki K Poulose
With commit a80868f398554842b14, we no longer ensure that the THP page is properly aligned in the guest IPA. Skip the stage2 huge mapping for unaligned IPA backed by transparent hugepages. Fixes: a80868f398554842b14 ("KVM: arm/arm64: Enforce PTE mappings at stage2 when needed") Reported-by: Eric

Re: [PATCH 5/8] KVM: arm/arm64: Enforce PTE mappings at stage2 when needed

2019-04-02 Thread Marc Zyngier
On Tue, 02 Apr 2019 11:07:28 +0100, Auger Eric wrote: > > Hi Suzuki, > > On 4/2/19 11:47 AM, Suzuki K Poulose wrote: > > On Mon, Apr 01, 2019 at 07:10:37PM +0200, Auger Eric wrote: > >> Hi Suzuki, > >> > >> On 3/28/19 2:36 PM, Marc Zyngier wrote: > >>> From: Suzuki K Poulose > >>> > >>> commit

Re: [PATCH 5/8] KVM: arm/arm64: Enforce PTE mappings at stage2 when needed

2019-04-02 Thread Auger Eric
Hi Suzuki, On 4/2/19 11:47 AM, Suzuki K Poulose wrote: > On Mon, Apr 01, 2019 at 07:10:37PM +0200, Auger Eric wrote: >> Hi Suzuki, >> >> On 3/28/19 2:36 PM, Marc Zyngier wrote: >>> From: Suzuki K Poulose >>> >>> commit 6794ad5443a2118 ("KVM: arm/arm64: Fix unintended stage 2 PMD >>> mappings")

Re: [PATCH v7 16/27] KVM: arm64: Factor out core register ID enumeration

2019-04-02 Thread Dave P Martin
On Tue, Apr 02, 2019 at 10:32:34AM +0100, Marc Zyngier wrote: > On Tue, 02 Apr 2019 09:59:19 +0100, > Dave Martin wrote: > > > > On Tue, Apr 02, 2019 at 03:41:56AM +0100, Marc Zyngier wrote: [...] > > > diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c > > > index

Re: [PATCH 5/8] KVM: arm/arm64: Enforce PTE mappings at stage2 when needed

2019-04-02 Thread Suzuki K Poulose
On Mon, Apr 01, 2019 at 07:10:37PM +0200, Auger Eric wrote: > Hi Suzuki, > > On 3/28/19 2:36 PM, Marc Zyngier wrote: > > From: Suzuki K Poulose > > > > commit 6794ad5443a2118 ("KVM: arm/arm64: Fix unintended stage 2 PMD > > mappings") > > made the checks to skip huge mappings, stricter.

Re: [PATCH] KVM: arm/arm64: vgic-v3: Retire pending interrupts on disabling LPIs

2019-04-02 Thread Heyi Guo
Thanks, I'll use this one for test. Heyi On 2019/4/2 16:48, Marc Zyngier wrote: On Tue, 02 Apr 2019 09:22:29 +0100, Auger Eric wrote: Hi Marc, On 4/2/19 9:24 AM, Marc Zyngier wrote: When disabling LPIs (for example on reset) at the redistributor level, it is expected that LPIs that was

Re: [PATCH v7 16/27] KVM: arm64: Factor out core register ID enumeration

2019-04-02 Thread Marc Zyngier
On Tue, 02 Apr 2019 09:59:19 +0100, Dave Martin wrote: > > On Tue, Apr 02, 2019 at 03:41:56AM +0100, Marc Zyngier wrote: > > On Fri, 29 Mar 2019 13:00:41 +, > > Dave Martin wrote: > > > > > > In preparation for adding logic to filter out some KVM_REG_ARM_CORE > > > registers from the

Re: [PATCH V2] KVM: ARM: Remove pgtable page standard functions from stage-2 page tables

2019-04-02 Thread Will Deacon
On Mon, Apr 01, 2019 at 12:34:25PM -0600, Yu Zhao wrote: > On Mon, Apr 01, 2019 at 05:16:38PM +0100, Will Deacon wrote: > > [+KVM/ARM folks, since I can't take this without an Ack in place from them] > > > > My understanding is that this patch is intended to replace patch 3/4 in > > this series:

Re: [PATCH v7 16/27] KVM: arm64: Factor out core register ID enumeration

2019-04-02 Thread Dave Martin
On Tue, Apr 02, 2019 at 03:41:56AM +0100, Marc Zyngier wrote: > On Fri, 29 Mar 2019 13:00:41 +, > Dave Martin wrote: > > > > In preparation for adding logic to filter out some KVM_REG_ARM_CORE > > registers from the KVM_GET_REG_LIST output, this patch factors out > > the core register

Re: [PATCH] KVM: arm/arm64: vgic-v3: Retire pending interrupts on disabling LPIs

2019-04-02 Thread Marc Zyngier
On Tue, 02 Apr 2019 09:22:29 +0100, Auger Eric wrote: > > Hi Marc, > > On 4/2/19 9:24 AM, Marc Zyngier wrote: > > When disabling LPIs (for example on reset) at the redistributor > > level, it is expected that LPIs that was pending in the CPU > > interface are eventually retired. > > > >

Re: [PATCH] KVM: arm/arm64: vgic-v3: Retire pending interrupts on disabling LPIs

2019-04-02 Thread Auger Eric
Hi Marc, On 4/2/19 9:24 AM, Marc Zyngier wrote: > When disabling LPIs (for example on reset) at the redistributor > level, it is expected that LPIs that was pending in the CPU > interface are eventually retired. > > Currently, this is not what is happening, and these LPIs will > stay in the