Re: [PATCH 08/26] KVM: arm64: Use TTL hint in when invalidating stage-2 translations

2020-05-12 Thread James Morse
Hi Marc, On 22/04/2020 13:00, Marc Zyngier wrote: > Since we always have a precide idea of the level we're dealing with (precise) > when invalidating TLBs, we can provide it to as a hint to our > invalidation helper. > diff --git a/arch/arm64/include/asm/stage2_pgtable.h > b/arch/arm64/include

Re: [PATCH 03/26] KVM: arm64: Factor out stage 2 page table data from struct kvm

2020-05-12 Thread Alexandru Elisei
Hi, On 5/12/20 12:17 PM, James Morse wrote: > Hi Alex, Marc, > > (just on this last_vcpu_ran thing...) > > On 11/05/2020 17:38, Alexandru Elisei wrote: >> On 4/22/20 1:00 PM, Marc Zyngier wrote: >>> From: Christoffer Dall >>> >>> As we are about to reuse our stage 2 page table manipulation code f

Re: [PATCH 03/26] KVM: arm64: Factor out stage 2 page table data from struct kvm

2020-05-12 Thread James Morse
Hi Alex, On 12/05/2020 16:47, Alexandru Elisei wrote: > On 5/12/20 12:17 PM, James Morse wrote: >> On 11/05/2020 17:38, Alexandru Elisei wrote: >>> On 4/22/20 1:00 PM, Marc Zyngier wrote: From: Christoffer Dall As we are about to reuse our stage 2 page table manipulation code for >

Re: [PATCH 03/26] KVM: arm64: Factor out stage 2 page table data from struct kvm

2020-05-12 Thread Alexandru Elisei
Hi, On 5/12/20 12:17 PM, James Morse wrote: > Hi Alex, Marc, > > (just on this last_vcpu_ran thing...) > > On 11/05/2020 17:38, Alexandru Elisei wrote: >> On 4/22/20 1:00 PM, Marc Zyngier wrote: >>> From: Christoffer Dall >>> >>> As we are about to reuse our stage 2 page table manipulation code f

Re: [PATCH 08/26] KVM: arm64: Use TTL hint in when invalidating stage-2 translations

2020-05-12 Thread James Morse
Hi Andrew, On 07/05/2020 16:13, Andrew Scull wrote: >> @@ -176,7 +177,7 @@ static void clear_stage2_pud_entry(struct kvm_s2_mmu >> *mmu, pud_t *pud, phys_addr >> pmd_t *pmd_table __maybe_unused = stage2_pmd_offset(kvm, pud, 0); >> VM_BUG_ON(stage2_pud_huge(kvm, *pud)); >> stage2_pu

Re: [PATCH 03/26] KVM: arm64: Factor out stage 2 page table data from struct kvm

2020-05-12 Thread James Morse
Hi Alex, Marc, (just on this last_vcpu_ran thing...) On 11/05/2020 17:38, Alexandru Elisei wrote: > On 4/22/20 1:00 PM, Marc Zyngier wrote: >> From: Christoffer Dall >> >> As we are about to reuse our stage 2 page table manipulation code for >> shadow stage 2 page tables in the context of nested

Re: [PATCH] arm64/cpufeature: Add ID_AA64MMFR0_PARANGE_MASK

2020-05-12 Thread Mark Rutland
On Tue, May 12, 2020 at 11:53:43AM +0100, Mark Rutland wrote: > > > > /* Clamp the IPA limit to the PA size supported by the kernel */ > > ipa_max = (pa_max > PHYS_MASK_SHIFT) ? PHYS_MASK_SHIFT : pa_max; > > @@ -411,7 +411,8 @@ int kvm_arm_setup_stage2(struct kvm *kvm, unsigned long > > ty

Re: [PATCH] arm64/cpufeature: Add ID_AA64MMFR0_PARANGE_MASK

2020-05-12 Thread Mark Rutland
On Tue, May 12, 2020 at 07:43:26AM +0530, Anshuman Khandual wrote: > This replaces multiple open encoding (0x7) with ID_AA64MMFR0_PARANGE_MASK > thus cleaning the clutter. It modifies an existing ID_AA64MMFR0 helper and > introduces a new one i.e id_aa64mmfr0_iparange() and id_aa64mmfr0_parange() >

Re: [PATCH] arm64/cpufeature: Add ID_AA64MMFR0_PARANGE_MASK

2020-05-12 Thread Marc Zyngier
Anshuman, On 2020-05-12 03:13, Anshuman Khandual wrote: This replaces multiple open encoding (0x7) with ID_AA64MMFR0_PARANGE_MASK thus cleaning the clutter. It modifies an existing ID_AA64MMFR0 helper and introduces a new one i.e id_aa64mmfr0_iparange() and id_aa64mmfr0_parange() respectively