Re: [PATCH v3 08/15] arm64: kvm: Split hyp/switch.c to VHE/nVHE

2020-06-24 Thread kernel test robot
Hi David, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.8-rc2 next-20200624] [cannot apply to kvmarm/next arm64/for-next/core arm-perf/for-next/perf] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH v2 14/21] KVM: Move x86's version of struct kvm_mmu_memory_cache to common code

2020-06-24 Thread Ben Gardon
On Mon, Jun 22, 2020 at 1:09 PM Sean Christopherson wrote: > > Move x86's 'struct kvm_mmu_memory_cache' to common code in anticipation > of moving the entire x86 implementation code to common KVM and reusing > it for arm64 and MIPS. Add a new architecture specific asm/kvm_types.h > to control

Re: [PATCH v2 05/21] KVM: x86/mmu: Try to avoid crashing KVM if a MMU memory cache is empty

2020-06-24 Thread Ben Gardon
On Mon, Jun 22, 2020 at 1:09 PM Sean Christopherson wrote: > > Attempt to allocate a new object instead of crashing KVM (and likely the > kernel) if a memory cache is unexpectedly empty. Use GFP_ATOMIC for the > allocation as the caches are used while holding mmu_lock. The immediate > BUG_ON()

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Catalin Marinas
On Wed, Jun 24, 2020 at 03:59:35PM +0100, Steven Price wrote: > On 24/06/2020 15:21, Catalin Marinas wrote: > > On Wed, Jun 24, 2020 at 12:16:28PM +0100, Steven Price wrote: > > > On 23/06/2020 18:48, Catalin Marinas wrote: > > > > On Wed, Jun 17, 2020 at 01:38:42PM +0100, Steven Price wrote: > >

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Steven Price
On 24/06/2020 15:21, Catalin Marinas wrote: On Wed, Jun 24, 2020 at 12:16:28PM +0100, Steven Price wrote: On 23/06/2020 18:48, Catalin Marinas wrote: On Wed, Jun 17, 2020 at 01:38:42PM +0100, Steven Price wrote: These patches add support to KVM to enable MTE within a guest. It is based on

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Catalin Marinas
On Wed, Jun 24, 2020 at 12:16:28PM +0100, Steven Price wrote: > On 23/06/2020 18:48, Catalin Marinas wrote: > > On Wed, Jun 17, 2020 at 01:38:42PM +0100, Steven Price wrote: > > > These patches add support to KVM to enable MTE within a guest. It is > > > based on Catalin's v4 MTE user space

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Peter Maydell
On Wed, 24 Jun 2020 at 12:18, Steven Price wrote: > Ah yes, similar to (1) but much lower overhead ;) That's probably the > best option - it can be hidden in a memcpy_ignoring_tags() function. > However it still means that the VMM can't directly touch the guest's > memory which might cause issues

Re: [PATCH stable 4.9] arm64: entry: Place an SB sequence following an ERET instruction

2020-06-24 Thread Will Deacon
On Tue, Jun 23, 2020 at 11:46:37AM -0700, Florian Fainelli wrote: > On 6/11/20 9:42 PM, Florian Fainelli wrote: > > From: Will Deacon > > > > commit 679db70801da9fda91d26caf13bf5b5ccc74e8e8 upstream > > > > Some CPUs can speculate past an ERET instruction and potentially perform > > speculative

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Catalin Marinas
On Wed, Jun 24, 2020 at 12:18:46PM +0100, Steven Price wrote: > On 24/06/2020 12:09, Catalin Marinas wrote: > > On Wed, Jun 24, 2020 at 12:03:35PM +0100, Steven Price wrote: > > > On 24/06/2020 11:34, Dave Martin wrote: > > > > On Wed, Jun 24, 2020 at 10:38:48AM +0100, Catalin Marinas wrote: > > >

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Steven Price
On 24/06/2020 12:09, Catalin Marinas wrote: On Wed, Jun 24, 2020 at 12:03:35PM +0100, Steven Price wrote: On 24/06/2020 11:34, Dave Martin wrote: On Wed, Jun 24, 2020 at 10:38:48AM +0100, Catalin Marinas wrote: On Tue, Jun 23, 2020 at 07:05:07PM +0100, Peter Maydell wrote: On Wed, 17 Jun

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Steven Price
On 23/06/2020 18:48, Catalin Marinas wrote: Hi Steven, On Wed, Jun 17, 2020 at 01:38:42PM +0100, Steven Price wrote: These patches add support to KVM to enable MTE within a guest. It is based on Catalin's v4 MTE user space series[1]. [1]

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Catalin Marinas
On Wed, Jun 24, 2020 at 12:03:35PM +0100, Steven Price wrote: > On 24/06/2020 11:34, Dave Martin wrote: > > On Wed, Jun 24, 2020 at 10:38:48AM +0100, Catalin Marinas wrote: > > > On Tue, Jun 23, 2020 at 07:05:07PM +0100, Peter Maydell wrote: > > > > On Wed, 17 Jun 2020 at 13:39, Steven Price

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Steven Price
On 24/06/2020 11:34, Dave Martin wrote: On Wed, Jun 24, 2020 at 10:38:48AM +0100, Catalin Marinas wrote: On Tue, Jun 23, 2020 at 07:05:07PM +0100, Peter Maydell wrote: On Wed, 17 Jun 2020 at 13:39, Steven Price wrote: These patches add support to KVM to enable MTE within a guest. It is based

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Dave Martin
On Wed, Jun 24, 2020 at 10:38:48AM +0100, Catalin Marinas wrote: > On Tue, Jun 23, 2020 at 07:05:07PM +0100, Peter Maydell wrote: > > On Wed, 17 Jun 2020 at 13:39, Steven Price wrote: > > > These patches add support to KVM to enable MTE within a guest. It is > > > based on Catalin's v4 MTE user

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Catalin Marinas
On Tue, Jun 23, 2020 at 07:05:07PM +0100, Peter Maydell wrote: > On Wed, 17 Jun 2020 at 13:39, Steven Price wrote: > > These patches add support to KVM to enable MTE within a guest. It is > > based on Catalin's v4 MTE user space series[1]. > > > > [1]

Re: [PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters

2020-06-24 Thread Tianjia Zhang
On 2020/6/23 23:31, Christian Borntraeger wrote: On 23.06.20 15:14, Tianjia Zhang wrote: In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the