Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Dave Martin
On Mon, Oct 19, 2020 at 05:23:11PM +0200, Andrew Jones wrote: > On Mon, Oct 19, 2020 at 03:58:40PM +0100, Dave Martin wrote: > > On Mon, Oct 19, 2020 at 03:18:11PM +0100, Peter Maydell wrote: > > > On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > > > > > > > On Mon, Oct 19, 2020 at

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Andrew Jones
On Mon, Oct 19, 2020 at 03:58:40PM +0100, Dave Martin wrote: > On Mon, Oct 19, 2020 at 03:18:11PM +0100, Peter Maydell wrote: > > On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > > > > > On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > > > > Well, ID regs are special in the

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Dave Martin
On Mon, Oct 19, 2020 at 03:18:11PM +0100, Peter Maydell wrote: > On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > > > On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > > > Well, ID regs are special in the architecture -- they always exist > > > and must RAZ/WI, even if they're

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Peter Maydell
On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > > Well, ID regs are special in the architecture -- they always exist > > and must RAZ/WI, even if they're not actually given any fields yet. > > This is different from other

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Andrew Jones
On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > On Mon, 19 Oct 2020 at 12:32, Dave Martin wrote: > > I'm not quite sure about Peter's assessment here. > > > > I agree with the inconsistency identified here: we always enumerate all > > unallocated ID regs, but we enumerate

Re: [PATCH] perf: arm_spe: Use Inner Shareable DSB when draining the buffer

2020-10-19 Thread Will Deacon
On Mon, Oct 19, 2020 at 01:24:55PM +0100, Mark Rutland wrote: > On Tue, Oct 06, 2020 at 05:13:31PM +0100, Alexandru Elisei wrote: > > On 10/6/20 4:32 PM, Marc Zyngier wrote: > > > On Tue, 06 Oct 2020 16:05:20 +0100, > > > Alexandru Elisei wrote: > > >> From ARM DDI 0487F.b, page D9-2807: > > >> >

Re: [PATCH] perf: arm_spe: Use Inner Shareable DSB when draining the buffer

2020-10-19 Thread Marc Zyngier
On 2020-10-19 13:24, Mark Rutland wrote: On Tue, Oct 06, 2020 at 05:13:31PM +0100, Alexandru Elisei wrote: Hi Marc, Thank you for having a look at the patch! On 10/6/20 4:32 PM, Marc Zyngier wrote: > Hi Alex, > > On Tue, 06 Oct 2020 16:05:20 +0100, > Alexandru Elisei wrote: >> From ARM DDI

Re: [PATCH] perf: arm_spe: Use Inner Shareable DSB when draining the buffer

2020-10-19 Thread Mark Rutland
On Tue, Oct 06, 2020 at 05:13:31PM +0100, Alexandru Elisei wrote: > Hi Marc, > > Thank you for having a look at the patch! > > On 10/6/20 4:32 PM, Marc Zyngier wrote: > > Hi Alex, > > > > On Tue, 06 Oct 2020 16:05:20 +0100, > > Alexandru Elisei wrote: > >> From ARM DDI 0487F.b, page D9-2807: >

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Peter Maydell
On Mon, 19 Oct 2020 at 12:32, Dave Martin wrote: > I'm not quite sure about Peter's assessment here. > > I agree with the inconsistency identified here: we always enumerate all > unallocated ID regs, but we enumerate ID_AA64ZFR0_EL1 conditionally. > This doesn't feel right: on a non-SVE guest,

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Dave Martin
On Mon, Oct 19, 2020 at 11:25:25AM +0200, Andrew Jones wrote: > On Thu, Oct 15, 2020 at 03:57:02PM +0100, Peter Maydell wrote: > > On Thu, 15 Oct 2020 at 15:41, Andrew Jones wrote: > > > The reporter states neither the source nor destination hardware supports > > > SVE. My guess is that what's

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Andrew Jones
On Thu, Oct 15, 2020 at 03:57:02PM +0100, Peter Maydell wrote: > On Thu, 15 Oct 2020 at 15:41, Andrew Jones wrote: > > The reporter states neither the source nor destination hardware supports > > SVE. My guess is that what's happening is the reserved ID register > > ID_UNALLOCATED(4,4) was