Re: Possible nohz-full/RCU issue in arm64 KVM

2021-12-17 Thread Paolo Bonzini
On 12/17/21 18:12, Paul E. McKenney wrote: On Fri, Dec 17, 2021 at 06:02:23PM +0100, Paolo Bonzini wrote: On 12/17/21 17:45, Paul E. McKenney wrote: On Fri, Dec 17, 2021 at 05:34:04PM +0100, Paolo Bonzini wrote: On 12/17/21 17:07, Paul E. McKenney wrote: rcu_note_context_switch() is a point-i

Re: Possible nohz-full/RCU issue in arm64 KVM

2021-12-17 Thread Paolo Bonzini
On 12/17/21 17:45, Paul E. McKenney wrote: On Fri, Dec 17, 2021 at 05:34:04PM +0100, Paolo Bonzini wrote: On 12/17/21 17:07, Paul E. McKenney wrote: rcu_note_context_switch() is a point-in-time notification; it's not strictly necessary, but it may improve performance a bit by avoiding unnecessa

Re: Possible nohz-full/RCU issue in arm64 KVM

2021-12-17 Thread Paolo Bonzini
On 12/17/21 17:07, Paul E. McKenney wrote: rcu_note_context_switch() is a point-in-time notification; it's not strictly necessary, but it may improve performance a bit by avoiding unnecessary IPIs from the RCU subsystem. There's no benefit from doing it when you're back from the guest, because a

Re: Possible nohz-full/RCU issue in arm64 KVM

2021-12-17 Thread Paolo Bonzini
On 12/17/21 15:38, Mark Rutland wrote: For example kvm_guest_enter_irqoff() calls guest_enter_irq_off() which calls vtime_account_guest_enter(), but kvm_guest_exit_irqoff() doesn't call guest_exit_irq_off() and the call to vtime_account_guest_exit() is open-coded elsewhere. Also, guest_enter_irq_

Re: Possible nohz-full/RCU issue in arm64 KVM

2021-12-17 Thread Paolo Bonzini
On 12/17/21 14:21, Mark Rutland wrote: I'm not immediately sure what we*should* do here. What does x86 do for an IRQ taken from a guest mode? I couldn't spot any handling of that case, but I'm not familiar enough with the x86 exception model to know if I'm looking in the right place. ARM is mi

Re: Possible nohz-full/RCU issue in arm64 KVM

2021-12-17 Thread Mark Rutland
On Fri, Dec 17, 2021 at 03:15:29PM +0100, Nicolas Saenz Julienne wrote: > On Fri, 2021-12-17 at 13:21 +, Mark Rutland wrote: > > On Fri, Dec 17, 2021 at 12:51:57PM +0100, Nicolas Saenz Julienne wrote: > > > Hi All, > > > > Hi, > > > > > arm64's guest entry code does the following: > > > > >

Re: Possible nohz-full/RCU issue in arm64 KVM

2021-12-17 Thread Mark Rutland
On Fri, Dec 17, 2021 at 12:51:57PM +0100, Nicolas Saenz Julienne wrote: > Hi All, Hi, > arm64's guest entry code does the following: > > int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu) > { > [...] > > guest_enter_irqoff(); > > ret = kvm_call_hyp_ret(__kvm_vcpu_run, vcpu);

Re: [PATCH 1/2] ACPI/AEST: Initial AEST driver

2021-12-17 Thread Tyler Baicar
Hi Shuuichirou, Thank you for your feedback! On 12/9/2021 3:10 AM, ishii.shuuic...@fujitsu.com wrote: Hi, Tyler. We would like to make a few comments. -Original Message- From: Tyler Baicar Sent: Thursday, November 25, 2021 2:07 AM To: patc...@amperecomputing.com; abdulha...@os.amper

Re: [PATCH 1/2] ACPI/AEST: Initial AEST driver

2021-12-17 Thread Tyler Baicar
Hi Mark, Thank you for the initial feedback! On 11/24/2021 1:51 PM, Mark Rutland wrote: Hi, I haven't looked at this in great detail, but I spotted a few issues from an initial scan. On Wed, Nov 24, 2021 at 12:07:07PM -0500, Tyler Baicar wrote: Add support for parsing the ARM Error Source Ta

Re: [PATCH 1/2] ACPI/AEST: Initial AEST driver

2021-12-17 Thread Tyler Baicar
-Moved ACPI for ARM64 maintainers to "to:" Hi Marc, Darren, On 11/30/2021 11:41 AM, Darren Hart wrote: On Tue, Nov 30, 2021 at 09:45:46AM +, Marc Zyngier wrote: Hi Darren, On Mon, 29 Nov 2021 20:39:23 +, Darren Hart wrote: On Wed, Nov 24, 2021 at 06:09:14PM +, Marc Zyngier wrote