Re: [PATCH v2 1/5] hw/arm/virt: Key enablement of highmem PCIe on highmem_ecam

2022-01-04 Thread Marc Zyngier
Hi Eric, On Tue, 04 Jan 2022 15:31:33 +, Eric Auger wrote: > > Hi Marc, > > On 12/27/21 4:53 PM, Marc Zyngier wrote: > > Hi Eric, > > > > Picking this up again after a stupidly long time... > > > > On Mon, 04 Oct 2021 13:00:21 +0100, > > Eric Auger wrote: > >> Hi Marc, > >> > >> On

Re: [PATCH v2 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

2022-01-04 Thread Marc Zyngier
On Tue, 4 Jan 2022 17:19:40 +0200, Andy Shevchenko wrote: > The arm_vgic.h does not require all the stuff the kernel.h provides. > Replace kernel.h inclusion with the list of what is really being used. Applied to next, thanks! [1/1] KVM: arm64: vgic: Replace kernel.h with the necessary

Re: Possible nohz-full/RCU issue in arm64 KVM

2022-01-04 Thread Paolo Bonzini
On 1/4/22 17:39, Mark Rutland wrote: My main issue here was just that it's really difficult to see how the entry/exit logic is balanced, and I reckon we can solve that by splitting guest_{enter,exit}_irqoff() into helper functions to handle the vtime accounting separately from the context

[PATCH v2 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

2022-01-04 Thread Andy Shevchenko
The arm_vgic.h does not require all the stuff the kernel.h provides. Replace kernel.h inclusion with the list of what is really being used. Signed-off-by: Andy Shevchenko --- v2: updated commit message by dropping unrelated paragraph (Marc) include/kvm/arm_vgic.h | 4 +++- 1 file changed, 3

Re: Possible nohz-full/RCU issue in arm64 KVM

2022-01-04 Thread Mark Rutland
On Fri, Dec 17, 2021 at 04:54:22PM +0100, Paolo Bonzini wrote: > On 12/17/21 15:38, Mark Rutland wrote: > > For example kvm_guest_enter_irqoff() calls guest_enter_irq_off() which calls > > vtime_account_guest_enter(), but kvm_guest_exit_irqoff() doesn't call > > guest_exit_irq_off() and the call

Re: [PATCH v2 1/5] hw/arm/virt: Key enablement of highmem PCIe on highmem_ecam

2022-01-04 Thread Eric Auger
Hi Marc, On 12/27/21 4:53 PM, Marc Zyngier wrote: > Hi Eric, > > Picking this up again after a stupidly long time... > > On Mon, 04 Oct 2021 13:00:21 +0100, > Eric Auger wrote: >> Hi Marc, >> >> On 10/3/21 6:46 PM, Marc Zyngier wrote: >>> Currently, the highmem PCIe region is oddly keyed on the

Re: [PATCH kvmtool 9/9] arm64: Add support for KVM_ARM_VCPU_PMU_V3_SET_PMU

2022-01-04 Thread Marc Zyngier
On Mon, 15 Nov 2021 16:57:05 +, Alexandru Elisei wrote: > > The KVM_ARM_VCPU_PMU_V3_CTRL(KVM_ARM_VCPU_PMU_V3_SET_PMU) VCPU ioctl is > used to assign a physical PMU to the events that KVM creates when emulating > the PMU for that VCPU. This is useful on heterogeneous systems, when there > is

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

2022-01-04 Thread Andy Shevchenko
On Tue, Jan 04, 2022 at 01:44:31PM +, Marc Zyngier wrote: > On Wed, 22 Dec 2021 19:14:28 +, > Andy Shevchenko wrote: > > On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote: > > > On Wed, Dec 22, 2021 at 06:09:22PM +, Marc Zyngier wrote: > > > > On Wed, 22 Dec 2021

Re: [PATCH] KVM: arm64: Fix comment typo in kvm_vcpu_finalize_sve()

2022-01-04 Thread Marc Zyngier
On Thu, 30 Dec 2021 22:15:35 +0800, Zenghui Yu wrote: > kvm_arm_init_arch_resources() was renamed to kvm_arm_init_sve() in > commit a3be836df7cb ("KVM: arm/arm64: Demote > kvm_arm_init_arch_resources() to just set up SVE"). Fix the function > name in comment of kvm_vcpu_finalize_sve(). Applied to

Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions

2022-01-04 Thread Marc Zyngier
On Wed, 22 Dec 2021 19:14:28 +, Andy Shevchenko wrote: > > On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote: > > On Wed, Dec 22, 2021 at 06:09:22PM +, Marc Zyngier wrote: > > > On Wed, 22 Dec 2021 16:55:52 +, > > > Andy Shevchenko wrote: > > > > > > > > When kernel.h

Re: Possible nohz-full/RCU issue in arm64 KVM

2022-01-04 Thread Mark Rutland
On Mon, Dec 20, 2021 at 05:10:14PM +0100, Frederic Weisbecker wrote: > On Fri, Dec 17, 2021 at 01:21:39PM +, Mark Rutland wrote: > > On Fri, Dec 17, 2021 at 12:51:57PM +0100, Nicolas Saenz Julienne wrote: > > > Hi All, > > > > Hi, > > > > > arm64's guest entry code does the following: > > >

Re: [PATCH v5 34/69] KVM: arm64: nv: Configure HCR_EL2 for nested virtualization

2022-01-04 Thread Marc Zyngier
On Tue, 04 Jan 2022 08:53:42 +, Ganapatrao Kulkarni wrote: > > > > On 30-11-2021 01:31 am, Marc Zyngier wrote: > > From: Jintack Lim > > > > We enable nested virtualization by setting the HCR NV and NV1 bit. > > > > When the virtual E2H bit is set, we can support EL2 register accesses >