Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

On Thu, Dec 21, 2017 at 05:16:48PM +0800, Jia He wrote: > > Sorry for the late, I ever thought you would send out v2 with isb(). > It seems not. > I did: https://lists.cs.columbia.edu/pipermail/kvmarm/2017-December/029078.html > > On 12/15/2017 6:04 PM, Christoffer Dall Wrote: > >On Fri, Dec

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

Hi Christoffer Sorry for the late, I ever thought you would send out v2 with isb(). It seems not. On 12/15/2017 6:04 PM, Christoffer Dall Wrote: On Fri, Dec 15, 2017 at 10:27:02AM +0800, Jia He wrote: [...] [...] Meanwhile, I think I thought of a cleaner way to do this. Could you test

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

On Fri, Dec 15, 2017 at 10:33:48AM +, Marc Zyngier wrote: > On 15/12/17 10:10, Christoffer Dall wrote: > > On Fri, Dec 15, 2017 at 09:09:05AM +, Marc Zyngier wrote: > >> On 15/12/17 02:27, Jia He wrote: > >>> > >>> > >> > >> [...] > >> > @@ -367,6 +368,7 @@ static void

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

On Fri, Dec 15, 2017 at 09:09:05AM +, Marc Zyngier wrote: > On 15/12/17 02:27, Jia He wrote: > > > > > > [...] > > >> @@ -367,6 +368,7 @@ static void vtimer_save_state(struct kvm_vcpu *vcpu) > >> > >>/* Disable the virtual timer */ > >>write_sysreg_el0(0, cntv_ctl); > >> +

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

On Fri, Dec 15, 2017 at 10:27:02AM +0800, Jia He wrote: [...] > >diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c > >index 73d262c4712b..544ed15fbbb3 100644 > >--- a/virt/kvm/arm/arch_timer.c > >+++ b/virt/kvm/arm/arch_timer.c > >@@ -46,7 +46,7 @@ static const struct

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

On 12/14/2017 11:45 PM, Christoffer Dall Wrote: On Thu, Dec 14, 2017 at 11:28:04PM +0800, Jia He wrote: On 12/14/2017 9:09 PM, Christoffer Dall Wrote: On Thu, Dec 14, 2017 at 12:57:54PM +0800, Jia He wrote: Hi Jia, I have tried your newer level-mapped-v7 branch, but bug is still there.

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

On Thu, Dec 14, 2017 at 11:28:04PM +0800, Jia He wrote: > > On 12/14/2017 9:09 PM, Christoffer Dall Wrote: > >On Thu, Dec 14, 2017 at 12:57:54PM +0800, Jia He wrote: > >Hi Jia, > > > >>I have tried your newer level-mapped-v7 branch, but bug is still there. > >> > >>There is no special load in

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

Hi Christoffer On 12/14/2017 9:09 PM, Christoffer Dall Wrote: On Thu, Dec 14, 2017 at 12:57:54PM +0800, Jia He wrote: Hi Jia, I have tried your newer level-mapped-v7 branch, but bug is still there. There is no special load in both host and guest. The guest (kernel 4.14) is often hanging

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

On Thu, Dec 14, 2017 at 12:57:54PM +0800, Jia He wrote: Hi Jia, > > I have tried your newer level-mapped-v7 branch, but bug is still there. > > There is no special load in both host and guest. The guest (kernel > 4.14) is often hanging when booting > > the guest kernel log > > [ OK ] Reached

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

Hi On 12/14/2017 12:57 PM, Jia He Wrote: Hi Christoffer I have tried your newer level-mapped-v7 branch, but bug is still there. There is no special load in both host and guest. The guest (kernel 4.14) is often hanging when booting the guest kernel log [ OK ] Reached target Remote File

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

Hi Christoffer I have tried your newer level-mapped-v7 branch, but bug is still there. There is no special load in both host and guest. The guest (kernel 4.14) is often hanging when booting the guest kernel log [ OK ] Reached target Remote File Systems. Starting File System Check on

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

On Wed, Dec 13, 2017 at 10:27 AM, Marc Zyngier wrote: > On 13/12/17 09:08, Auger Eric wrote: >> Marc, >> On 13/12/17 09:56, Marc Zyngier wrote: >>> Hi Jia, >>> >>> On 13/12/17 07:00, Jia He wrote: In our Armv8a server (qualcomm Amberwing, non VHE), after applying

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

On 13/12/17 09:08, Auger Eric wrote: > Marc, > On 13/12/17 09:56, Marc Zyngier wrote: >> Hi Jia, >> >> On 13/12/17 07:00, Jia He wrote: >>> In our Armv8a server (qualcomm Amberwing, non VHE), after applying >>> Christoffer's timer optimizing patchset(Optimize arch timer register >>> handling), the

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

On Wed, Dec 13, 2017 at 08:56:12AM +, Marc Zyngier wrote: > Hi Jia, > > On 13/12/17 07:00, Jia He wrote: > > In our Armv8a server (qualcomm Amberwing, non VHE), after applying > > Christoffer's timer optimizing patchset(Optimize arch timer register > > handling), the guest is hang during

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

On Tue, Dec 12, 2017 at 11:00:07PM -0800, Jia He wrote: > In our Armv8a server (qualcomm Amberwing, non VHE), after applying > Christoffer's timer optimizing patchset(Optimize arch timer register > handling), the guest is hang during kernel booting. > > The error root cause might be as follows: >

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

Marc, On 13/12/17 09:56, Marc Zyngier wrote: > Hi Jia, > > On 13/12/17 07:00, Jia He wrote: >> In our Armv8a server (qualcomm Amberwing, non VHE), after applying >> Christoffer's timer optimizing patchset(Optimize arch timer register >> handling), the guest is hang during kernel booting. >> >>

Re: [PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

Hi Jia, On 13/12/17 07:00, Jia He wrote: > In our Armv8a server (qualcomm Amberwing, non VHE), after applying > Christoffer's timer optimizing patchset(Optimize arch timer register > handling), the guest is hang during kernel booting. > > The error root cause might be as follows: > 1. in

[PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

In our Armv8a server (qualcomm Amberwing, non VHE), after applying Christoffer's timer optimizing patchset(Optimize arch timer register handling), the guest is hang during kernel booting. The error root cause might be as follows: 1. in kvm_arch_timer_handler, it reset vtimer->cnt_ctl with current