Re: [PATCH 1/2] ARM: kvm: fix a bad BSYM() usage

2015-05-11 Thread Dave P Martin
On Mon, May 11, 2015 at 10:05:37AM +0100, Christoffer Dall wrote: On Sat, May 09, 2015 at 10:10:56PM +0200, Ard Biesheuvel wrote: On 9 May 2015 at 22:07, Christoffer Dall christoffer.d...@linaro.org wrote: On Fri, May 08, 2015 at 05:08:42PM +0100, Russell King wrote: BSYM() should only

Re: [PATCH 1/2] ARM: kvm: fix a bad BSYM() usage

2015-05-11 Thread Ard Biesheuvel
On 11 May 2015 at 11:05, Christoffer Dall christoffer.d...@linaro.org wrote: On Sat, May 09, 2015 at 10:10:56PM +0200, Ard Biesheuvel wrote: On 9 May 2015 at 22:07, Christoffer Dall christoffer.d...@linaro.org wrote: On Fri, May 08, 2015 at 05:08:42PM +0100, Russell King wrote: BSYM() should

Re: [PATCH 1/2] ARM: kvm: fix a bad BSYM() usage

2015-05-11 Thread Dave P Martin
On Mon, May 11, 2015 at 10:44:49AM +0100, Ard Biesheuvel wrote: On 11 May 2015 at 11:05, Christoffer Dall christoffer.d...@linaro.org wrote: On Sat, May 09, 2015 at 10:10:56PM +0200, Ard Biesheuvel wrote: On 9 May 2015 at 22:07, Christoffer Dall christoffer.d...@linaro.org wrote: On

Re: [PATCH 1/2] ARM: kvm: fix a bad BSYM() usage

2015-05-11 Thread Christoffer Dall
On Sat, May 09, 2015 at 09:10:57PM +0100, Russell King - ARM Linux wrote: On Sat, May 09, 2015 at 10:07:17PM +0200, Christoffer Dall wrote: On Fri, May 08, 2015 at 05:08:42PM +0100, Russell King wrote: BSYM() should only be used when refering to local symbols in the same assembly file

Re: [PATCH 1/2] ARM: kvm: fix a bad BSYM() usage

2015-05-09 Thread Christoffer Dall
On Fri, May 08, 2015 at 05:08:42PM +0100, Russell King wrote: BSYM() should only be used when refering to local symbols in the same assembly file which are resolved by the assembler, and not for linker-fixed up symbols. The use of BSYM() with panic is incorrect as the linker is involved in

Re: [PATCH 1/2] ARM: kvm: fix a bad BSYM() usage

2015-05-09 Thread Ard Biesheuvel
On 9 May 2015 at 22:07, Christoffer Dall christoffer.d...@linaro.org wrote: On Fri, May 08, 2015 at 05:08:42PM +0100, Russell King wrote: BSYM() should only be used when refering to local symbols in the same assembly file which are resolved by the assembler, and not for linker-fixed up

[PATCH 1/2] ARM: kvm: fix a bad BSYM() usage

2015-05-08 Thread Russell King
BSYM() should only be used when refering to local symbols in the same assembly file which are resolved by the assembler, and not for linker-fixed up symbols. The use of BSYM() with panic is incorrect as the linker is involved in fixing up this relocation, and it knows whether panic() is ARM or

Re: [PATCH 1/2] ARM: kvm: fix a bad BSYM() usage

2015-05-08 Thread Dave P Martin
On Fri, May 08, 2015 at 05:08:42PM +0100, Russell King wrote: BSYM() should only be used when refering to local symbols in the same assembly file which are resolved by the assembler, and not for linker-fixed up symbols. The use of BSYM() with panic is incorrect as the linker is involved in

Re: [PATCH 1/2] ARM: kvm: fix a bad BSYM() usage

2015-05-08 Thread Nicolas Pitre
On Fri, 8 May 2015, Russell King wrote: BSYM() should only be used when refering to local symbols in the same assembly file which are resolved by the assembler, and not for linker-fixed up symbols. The use of BSYM() with panic is incorrect as the linker is involved in fixing up this