Re: [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

2017-03-15 Thread Marc Zyngier
On 15/03/17 14:33, Suzuki K Poulose wrote: > On 15/03/17 13:28, Marc Zyngier wrote: >> On 15/03/17 10:56, Christoffer Dall wrote: >>> On Wed, Mar 15, 2017 at 09:39:26AM +, Marc Zyngier wrote: On 15/03/17 09:21, Christoffer Dall wrote: > On Tue, Mar 14, 2017 at 02:52:34PM +, Suzuki

Re: [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

2017-03-15 Thread Suzuki K Poulose
On 15/03/17 13:28, Marc Zyngier wrote: On 15/03/17 10:56, Christoffer Dall wrote: On Wed, Mar 15, 2017 at 09:39:26AM +, Marc Zyngier wrote: On 15/03/17 09:21, Christoffer Dall wrote: On Tue, Mar 14, 2017 at 02:52:34PM +, Suzuki K Poulose wrote: In kvm_free_stage2_pgd() we don't hold

Re: [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

2017-03-15 Thread Robin Murphy
Hi Marc, On 15/03/17 13:43, Marc Zyngier wrote: > On 15/03/17 13:35, Christoffer Dall wrote: >> On Wed, Mar 15, 2017 at 01:28:07PM +, Marc Zyngier wrote: >>> On 15/03/17 10:56, Christoffer Dall wrote: On Wed, Mar 15, 2017 at 09:39:26AM +, Marc Zyngier wrote: > On 15/03/17 09:21,

Re: [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

2017-03-15 Thread Marc Zyngier
On 15/03/17 13:35, Christoffer Dall wrote: > On Wed, Mar 15, 2017 at 01:28:07PM +, Marc Zyngier wrote: >> On 15/03/17 10:56, Christoffer Dall wrote: >>> On Wed, Mar 15, 2017 at 09:39:26AM +, Marc Zyngier wrote: On 15/03/17 09:21, Christoffer Dall wrote: > On Tue, Mar 14, 2017 at

Re: [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

2017-03-15 Thread Christoffer Dall
On Wed, Mar 15, 2017 at 01:28:07PM +, Marc Zyngier wrote: > On 15/03/17 10:56, Christoffer Dall wrote: > > On Wed, Mar 15, 2017 at 09:39:26AM +, Marc Zyngier wrote: > >> On 15/03/17 09:21, Christoffer Dall wrote: > >>> On Tue, Mar 14, 2017 at 02:52:34PM +, Suzuki K Poulose wrote: >

Re: [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

2017-03-15 Thread Marc Zyngier
On 15/03/17 10:56, Christoffer Dall wrote: > On Wed, Mar 15, 2017 at 09:39:26AM +, Marc Zyngier wrote: >> On 15/03/17 09:21, Christoffer Dall wrote: >>> On Tue, Mar 14, 2017 at 02:52:34PM +, Suzuki K Poulose wrote: In kvm_free_stage2_pgd() we don't hold the kvm->mmu_lock while calling

Re: [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

2017-03-15 Thread Christoffer Dall
On Wed, Mar 15, 2017 at 09:39:26AM +, Marc Zyngier wrote: > On 15/03/17 09:21, Christoffer Dall wrote: > > On Tue, Mar 14, 2017 at 02:52:34PM +, Suzuki K Poulose wrote: > >> In kvm_free_stage2_pgd() we don't hold the kvm->mmu_lock while calling > >> unmap_stage2_range() on the entire

Re: [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

2017-03-15 Thread Marc Zyngier
On 15/03/17 09:21, Christoffer Dall wrote: > On Tue, Mar 14, 2017 at 02:52:34PM +, Suzuki K Poulose wrote: >> In kvm_free_stage2_pgd() we don't hold the kvm->mmu_lock while calling >> unmap_stage2_range() on the entire memory range for the guest. This could >> cause problems with other callers

Re: [PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

2017-03-15 Thread Christoffer Dall
On Tue, Mar 14, 2017 at 02:52:34PM +, Suzuki K Poulose wrote: > In kvm_free_stage2_pgd() we don't hold the kvm->mmu_lock while calling > unmap_stage2_range() on the entire memory range for the guest. This could > cause problems with other callers (e.g, munmap on a memslot) trying to > unmap a

[PATCH 3/3] kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

2017-03-14 Thread Suzuki K Poulose
In kvm_free_stage2_pgd() we don't hold the kvm->mmu_lock while calling unmap_stage2_range() on the entire memory range for the guest. This could cause problems with other callers (e.g, munmap on a memslot) trying to unmap a range. Fixes: commit d5d8184d35c9 ("KVM: ARM: Memory virtualization