Re: [PATCH kvm-unit-tests 2/2] arm64: add micro-bench

2018-09-04 Thread Andrew Jones
On Tue, Sep 04, 2018 at 11:02:43AM -0400, Shih-Wei Li wrote: > I've tested patch v2 along with the fix in the switch case. The > performance numbers look sane on my seattle server. > > Tested-by: Shih-Wei Li Thanks Shih-Wei. I'll send v3 now with the breaks and add yours and Christoffer's

Re: [PATCH kvm-unit-tests 2/2] arm64: add micro-bench

2018-09-04 Thread Shih-Wei Li
I've tested patch v2 along with the fix in the switch case. The performance numbers look sane on my seattle server. Tested-by: Shih-Wei Li Thanks, Shih-Wei On Mon, Sep 3, 2018 at 11:38 PM, Shih-Wei Li wrote: > On Mon, Sep 3, 2018 at 12:31 PM, Andrew Jones wrote: >> On Mon, Sep 03, 2018 at

Re: [PATCH kvm-unit-tests 2/2] arm64: add micro-bench

2018-09-03 Thread Shih-Wei Li
On Mon, Sep 3, 2018 at 12:31 PM, Andrew Jones wrote: > On Mon, Sep 03, 2018 at 11:06:51AM -0400, Shih-Wei Li wrote: >> On Thu, Aug 30, 2018 at 10:17 AM, Andrew Jones wrote: >> > +static bool test_init(void) >> > +{ >> > + int v = gic_init(); >> > + >> > + if (!v) { >> > +

Re: [PATCH kvm-unit-tests 2/2] arm64: add micro-bench

2018-09-03 Thread Andrew Jones
On Mon, Sep 03, 2018 at 11:06:51AM -0400, Shih-Wei Li wrote: > On Thu, Aug 30, 2018 at 10:17 AM, Andrew Jones wrote: > > +static bool test_init(void) > > +{ > > + int v = gic_init(); > > + > > + if (!v) { > > + printf("No supported gic present, skipping tests...\n"); > >

Re: [PATCH kvm-unit-tests 2/2] arm64: add micro-bench

2018-09-03 Thread Shih-Wei Li
On Thu, Aug 30, 2018 at 10:17 AM, Andrew Jones wrote: > From: Shih-Wei Li > > Here we provide the support for measuring various micro level > operations on arm64. Measurements are currently obtained using > timer counters. Further modifications in KVM will be required > to support timestamping

Re: [PATCH kvm-unit-tests 2/2] arm64: add micro-bench

2018-09-03 Thread Christoffer Dall
On Mon, Sep 03, 2018 at 02:11:30PM +0200, Andrew Jones wrote: > On Mon, Sep 03, 2018 at 01:12:36PM +0200, Christoffer Dall wrote: > > On Thu, Aug 30, 2018 at 04:17:33PM +0200, Andrew Jones wrote: > > > From: Shih-Wei Li > > > > > > Here we provide the support for measuring various micro level >

Re: [PATCH kvm-unit-tests 2/2] arm64: add micro-bench

2018-09-03 Thread Andrew Jones
On Mon, Sep 03, 2018 at 01:12:36PM +0200, Christoffer Dall wrote: > On Thu, Aug 30, 2018 at 04:17:33PM +0200, Andrew Jones wrote: > > From: Shih-Wei Li > > > > Here we provide the support for measuring various micro level > > operations on arm64. Measurements are currently obtained using > >

Re: [PATCH kvm-unit-tests 2/2] arm64: add micro-bench

2018-09-03 Thread Christoffer Dall
On Thu, Aug 30, 2018 at 04:17:33PM +0200, Andrew Jones wrote: > From: Shih-Wei Li > > Here we provide the support for measuring various micro level > operations on arm64. Measurements are currently obtained using > timer counters. Further modifications in KVM will be required > to support

[PATCH kvm-unit-tests 2/2] arm64: add micro-bench

2018-08-30 Thread Andrew Jones
From: Shih-Wei Li Here we provide the support for measuring various micro level operations on arm64. Measurements are currently obtained using timer counters. Further modifications in KVM will be required to support timestamping using cycle counters, as KVM now disables accesses to the PMU