Re: [PATCH v2 02/17] virtio: pci-legacy: Validate queue pfn

2018-07-13 Thread Suzuki K Poulose
On 13/07/18 01:36, Michael S. Tsirkin wrote: On Tue, Mar 27, 2018 at 05:11:04PM +0300, Michael S. Tsirkin wrote: On Tue, Mar 27, 2018 at 02:15:12PM +0100, Suzuki K Poulose wrote: Legacy PCI over virtio uses a 32bit PFN for the queue. If the queue pfn is too large to fit in 32bits, which we

Re: [PATCH v2 02/17] virtio: pci-legacy: Validate queue pfn

2018-07-12 Thread Michael S. Tsirkin
On Tue, Mar 27, 2018 at 05:11:04PM +0300, Michael S. Tsirkin wrote: > On Tue, Mar 27, 2018 at 02:15:12PM +0100, Suzuki K Poulose wrote: > > Legacy PCI over virtio uses a 32bit PFN for the queue. If the > > queue pfn is too large to fit in 32bits, which we could hit on > > arm64 systems with 52bit

[PATCH v2 02/17] virtio: pci-legacy: Validate queue pfn

2018-03-27 Thread Suzuki K Poulose
Legacy PCI over virtio uses a 32bit PFN for the queue. If the queue pfn is too large to fit in 32bits, which we could hit on arm64 systems with 52bit physical addresses (even with 64K page size), we simply miss out a proper link to the other side of the queue. Add a check to validate the PFN,