RE: [PATCH v2 3/7] KVM: irqchip: convey devid to kvm_set_msi

2015-07-17 Thread Pavel Fedin
Hello! +} else if (!msi-flags) +return -EINVAL; Did you mean if (msg-flags) here (inverted condition)? Indeed, and also you need { } around the return for the QEMU coding standard. It's kernel and not qemu :) Kind regards, Pavel Fedin Expert Engineer

Re: [PATCH v2 3/7] KVM: irqchip: convey devid to kvm_set_msi

2015-07-10 Thread Andre Przywara
On 09/07/15 09:22, Eric Auger wrote: on ARM, a devid field is populated in kvm_msi struct in case the flag is set to KVM_MSI_VALID_DEVID. Let's populate the corresponding kvm_kernel_irq_routing_entry devid field and set the msi type to KVM_IRQ_ROUTING_EXTENDED_MSI. Signed-off-by: Eric Auger

[PATCH v2 3/7] KVM: irqchip: convey devid to kvm_set_msi

2015-07-09 Thread Eric Auger
on ARM, a devid field is populated in kvm_msi struct in case the flag is set to KVM_MSI_VALID_DEVID. Let's populate the corresponding kvm_kernel_irq_routing_entry devid field and set the msi type to KVM_IRQ_ROUTING_EXTENDED_MSI. Signed-off-by: Eric Auger eric.au...@linaro.org ---