Re: [PATCH v3 1/7] KVM: arm64: Discard any SVE state when entering KVM guests

2022-09-22 Thread Mark Brown
On Wed, Sep 21, 2022 at 06:31:28PM +0100, Marc Zyngier wrote: > Mark Brown wrote: > > There's no use for that hook now though. > Care to clarify? We don't do anything for SME even if we were to support SME with no FP properly. signature.asc Description: PGP signature

Re: [PATCH v3 1/7] KVM: arm64: Discard any SVE state when entering KVM guests

2022-09-21 Thread Marc Zyngier
On Tue, 20 Sep 2022 21:21:33 +0100, Mark Brown wrote: > > [1 ] > On Tue, Sep 20, 2022 at 05:44:01PM +0100, Marc Zyngier wrote: > > Mark Brown wrote: > > > > void kvm_arch_vcpu_load_fp(struct kvm_vcpu *vcpu) > > > { > > > BUG_ON(!current->mm); > > > - BUG_ON(test_thread_flag(TIF_SVE)); > >

Re: [PATCH v3 1/7] KVM: arm64: Discard any SVE state when entering KVM guests

2022-09-20 Thread Mark Brown
On Tue, Sep 20, 2022 at 05:44:01PM +0100, Marc Zyngier wrote: > Mark Brown wrote: > > void kvm_arch_vcpu_load_fp(struct kvm_vcpu *vcpu) > > { > > BUG_ON(!current->mm); > > - BUG_ON(test_thread_flag(TIF_SVE)); > > + > > + fpsimd_kvm_prepare(); > > Why is this *before* the check against

Re: [PATCH v3 1/7] KVM: arm64: Discard any SVE state when entering KVM guests

2022-09-20 Thread Marc Zyngier
On Mon, 15 Aug 2022 23:55:23 +0100, Mark Brown wrote: > > Since 8383741ab2e773a99 (KVM: arm64: Get rid of host SVE tracking/saving) > KVM has not tracked the host SVE state, relying on the fact that we > currently disable SVE whenever we perform a syscall. This may not be true > in future since

[PATCH v3 1/7] KVM: arm64: Discard any SVE state when entering KVM guests

2022-08-15 Thread Mark Brown
Since 8383741ab2e773a99 (KVM: arm64: Get rid of host SVE tracking/saving) KVM has not tracked the host SVE state, relying on the fact that we currently disable SVE whenever we perform a syscall. This may not be true in future since performance optimisation may result in us keeping SVE enabled in