Re: [PATCH v3 3/7] arm64/fpsimd: Have KVM explicitly say which FP registers to save

2022-09-22 Thread Mark Brown
On Wed, Sep 21, 2022 at 06:47:21PM +0100, Marc Zyngier wrote: > Mark Brown wrote: > > It means that using FP_STATE_TASK as a value for the fp_type > > member of the task struck recording what type of state is > > currently stored for the task is not valid, one of the other two > > values

Re: [PATCH v3 3/7] arm64/fpsimd: Have KVM explicitly say which FP registers to save

2022-09-21 Thread Marc Zyngier
On Tue, 20 Sep 2022 19:32:49 +0100, Mark Brown wrote: > > [1 ] > On Tue, Sep 20, 2022 at 06:52:59PM +0100, Marc Zyngier wrote: > > On Mon, 15 Aug 2022 23:55:25 +0100, > > Mark Brown wrote: > > > > enum fp_state { > > > + FP_STATE_TASK, /* Save based on current, invalid as fp_type */

Re: [PATCH v3 3/7] arm64/fpsimd: Have KVM explicitly say which FP registers to save

2022-09-20 Thread Mark Brown
On Tue, Sep 20, 2022 at 06:52:59PM +0100, Marc Zyngier wrote: > On Mon, 15 Aug 2022 23:55:25 +0100, > Mark Brown wrote: > > enum fp_state { > > + FP_STATE_TASK, /* Save based on current, invalid as fp_type */ > How is that related to the FP_TYPE_TASK in the commit message? What

Re: [PATCH v3 3/7] arm64/fpsimd: Have KVM explicitly say which FP registers to save

2022-09-20 Thread Marc Zyngier
On Mon, 15 Aug 2022 23:55:25 +0100, Mark Brown wrote: > > In order to avoid needlessly saving and restoring the guest registers KVM > relies on the host FPSMID code to save the guest registers when we context > switch away from the guest. This is done by binding the KVM guest state to > the CPU

[PATCH v3 3/7] arm64/fpsimd: Have KVM explicitly say which FP registers to save

2022-08-15 Thread Mark Brown
In order to avoid needlessly saving and restoring the guest registers KVM relies on the host FPSMID code to save the guest registers when we context switch away from the guest. This is done by binding the KVM guest state to the CPU on top of the task state that was originally there, then carefully