Re: [PATCH v4 10/19] KVM: arm/arm64: Do not use kern_hyp_va() with kvm_vgic_global_state

2018-02-20 Thread Marc Zyngier
On 19/02/18 14:39, Christoffer Dall wrote: > On Fri, Feb 16, 2018 at 09:33:39AM +, Marc Zyngier wrote: >> On 16/02/18 09:05, Christoffer Dall wrote: >>> On Thu, Feb 15, 2018 at 01:22:56PM +, Marc Zyngier wrote: On 15/01/18 15:36, Christoffer Dall wrote: > On Thu, Jan 04, 2018 at

Re: [PATCH v4 10/19] KVM: arm/arm64: Do not use kern_hyp_va() with kvm_vgic_global_state

2018-02-19 Thread Christoffer Dall
On Fri, Feb 16, 2018 at 09:33:39AM +, Marc Zyngier wrote: > On 16/02/18 09:05, Christoffer Dall wrote: > > On Thu, Feb 15, 2018 at 01:22:56PM +, Marc Zyngier wrote: > >> On 15/01/18 15:36, Christoffer Dall wrote: > >>> On Thu, Jan 04, 2018 at 06:43:25PM +, Marc Zyngier wrote: >

Re: [PATCH v4 10/19] KVM: arm/arm64: Do not use kern_hyp_va() with kvm_vgic_global_state

2018-02-16 Thread Marc Zyngier
On 16/02/18 09:05, Christoffer Dall wrote: > On Thu, Feb 15, 2018 at 01:22:56PM +, Marc Zyngier wrote: >> On 15/01/18 15:36, Christoffer Dall wrote: >>> On Thu, Jan 04, 2018 at 06:43:25PM +, Marc Zyngier wrote: kvm_vgic_global_state is part of the read-only section, and is

Re: [PATCH v4 10/19] KVM: arm/arm64: Do not use kern_hyp_va() with kvm_vgic_global_state

2018-02-16 Thread Christoffer Dall
On Thu, Feb 15, 2018 at 01:22:56PM +, Marc Zyngier wrote: > On 15/01/18 15:36, Christoffer Dall wrote: > > On Thu, Jan 04, 2018 at 06:43:25PM +, Marc Zyngier wrote: > >> kvm_vgic_global_state is part of the read-only section, and is > >> usually accessed using a PC-relative address

Re: [PATCH v4 10/19] KVM: arm/arm64: Do not use kern_hyp_va() with kvm_vgic_global_state

2018-01-15 Thread Christoffer Dall
On Thu, Jan 04, 2018 at 06:43:25PM +, Marc Zyngier wrote: > kvm_vgic_global_state is part of the read-only section, and is > usually accessed using a PC-relative address generation (adrp + add). > > It is thus useless to use kern_hyp_va() on it, and actively problematic > if kern_hyp_va()

[PATCH v4 10/19] KVM: arm/arm64: Do not use kern_hyp_va() with kvm_vgic_global_state

2018-01-04 Thread Marc Zyngier
kvm_vgic_global_state is part of the read-only section, and is usually accessed using a PC-relative address generation (adrp + add). It is thus useless to use kern_hyp_va() on it, and actively problematic if kern_hyp_va() becomes non-idempotent. On the other hand, there is no way that the