Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-12-12 Thread Kees Cook
On Tue, Dec 12, 2017 at 3:11 AM, Dave Martin wrote: > On Tue, Dec 12, 2017 at 10:40:30AM +, Will Deacon wrote: >> On Mon, Dec 11, 2017 at 11:23:09AM -0800, Kees Cook wrote: >> > On Mon, Dec 11, 2017 at 6:07 AM, Will Deacon wrote: >> > > On Thu, Dec 07, 2017 at 10:50:38AM -0800, Kees Cook wrot

Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-12-12 Thread Dave Martin
On Tue, Dec 12, 2017 at 10:40:30AM +, Will Deacon wrote: > On Mon, Dec 11, 2017 at 11:23:09AM -0800, Kees Cook wrote: > > On Mon, Dec 11, 2017 at 6:07 AM, Will Deacon wrote: > > > On Thu, Dec 07, 2017 at 10:50:38AM -0800, Kees Cook wrote: > > >> My question is mainly: why not just use copy_*()

Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-12-12 Thread Will Deacon
On Mon, Dec 11, 2017 at 11:23:09AM -0800, Kees Cook wrote: > On Mon, Dec 11, 2017 at 6:07 AM, Will Deacon wrote: > > On Thu, Dec 07, 2017 at 10:50:38AM -0800, Kees Cook wrote: > >> My question is mainly: why not just use copy_*() everywhere instead? > >> Having these things so spread out makes it

Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-12-11 Thread Kees Cook
On Mon, Dec 11, 2017 at 6:07 AM, Will Deacon wrote: > On Thu, Dec 07, 2017 at 10:50:38AM -0800, Kees Cook wrote: >> My question is mainly: why not just use copy_*() everywhere instead? >> Having these things so spread out makes it fragile, and there's very >> little performance benefit from using

Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-12-11 Thread Will Deacon
On Thu, Dec 07, 2017 at 10:50:38AM -0800, Kees Cook wrote: > My question is mainly: why not just use copy_*() everywhere instead? > Having these things so spread out makes it fragile, and there's very > little performance benefit from using __copy_*() over copy_*(). I think that's more of a genera

Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-12-07 Thread Kees Cook
On Thu, Dec 7, 2017 at 2:49 AM, Will Deacon wrote: > Hi Kees, > > On Wed, Dec 06, 2017 at 11:56:50AM -0800, Kees Cook wrote: >> On Tue, Oct 31, 2017 at 8:51 AM, Dave Martin wrote: >> > Miscellaneous: >> > >> > * Change inconsistent copy_to_user() calls to __copy_to_user() in >> >preserve_sve

Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-12-07 Thread Dave Martin
On Thu, Dec 07, 2017 at 10:49:48AM +, Will Deacon wrote: > Hi Kees, > > On Wed, Dec 06, 2017 at 11:56:50AM -0800, Kees Cook wrote: > > On Tue, Oct 31, 2017 at 8:51 AM, Dave Martin wrote: > > > Miscellaneous: > > > > > > * Change inconsistent copy_to_user() calls to __copy_to_user() in > > >

Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-12-07 Thread Will Deacon
Hi Kees, On Wed, Dec 06, 2017 at 11:56:50AM -0800, Kees Cook wrote: > On Tue, Oct 31, 2017 at 8:51 AM, Dave Martin wrote: > > Miscellaneous: > > > > * Change inconsistent copy_to_user() calls to __copy_to_user() in > >preserve_sve_context(). > > > >There are already __put_user_error() ca

Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-12-06 Thread Kees Cook
On Tue, Oct 31, 2017 at 8:51 AM, Dave Martin wrote: > This patch implements support for saving and restoring the SVE > registers around signals. > > A fixed-size header struct sve_context is always included in the > signal frame encoding the thread's vector length at the time of > signal delivery,

Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-11-08 Thread Dave Martin
On Tue, Nov 07, 2017 at 01:22:33PM +, Alex Bennée wrote: > > Dave Martin writes: > > > This patch implements support for saving and restoring the SVE > > registers around signals. > > > > A fixed-size header struct sve_context is always included in the > > signal frame encoding the thread's

Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-11-07 Thread Alex Bennée
Dave Martin writes: > This patch implements support for saving and restoring the SVE > registers around signals. > > A fixed-size header struct sve_context is always included in the > signal frame encoding the thread's vector length at the time of > signal delivery, optionally followed by a vari

Re: [PATCH v5 15/30] arm64/sve: Signal handling support

2017-11-01 Thread Catalin Marinas
On Tue, Oct 31, 2017 at 03:51:07PM +, Dave P Martin wrote: > This patch implements support for saving and restoring the SVE > registers around signals. > > A fixed-size header struct sve_context is always included in the > signal frame encoding the thread's vector length at the time of > signa

[PATCH v5 15/30] arm64/sve: Signal handling support

2017-10-31 Thread Dave Martin
This patch implements support for saving and restoring the SVE registers around signals. A fixed-size header struct sve_context is always included in the signal frame encoding the thread's vector length at the time of signal delivery, optionally followed by a variable-layout structure encoding the