Re: [PATCH v6 01/13] arm64: cpufeature: __this_cpu_has_cap() shouldn't stop early

2018-01-16 Thread Suzuki K Poulose
On 16/01/18 15:04, Catalin Marinas wrote: On Mon, Jan 15, 2018 at 07:38:54PM +, James Morse wrote: diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index 9ef84d0def9a..d88cd0e88606 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c

Re: [PATCH v6 01/13] arm64: cpufeature: __this_cpu_has_cap() shouldn't stop early

2018-01-16 Thread Catalin Marinas
On Mon, Jan 15, 2018 at 07:38:54PM +, James Morse wrote: > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 9ef84d0def9a..d88cd0e88606 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -1303,8 +1303,8 @@ static bool

Re: [PATCH v6 01/13] arm64: cpufeature: __this_cpu_has_cap() shouldn't stop early

2018-01-16 Thread Marc Zyngier
On 15/01/18 19:38, James Morse wrote: > this_cpu_has_cap() tests caps->desc not caps->matches, so it stops > walking the list when it finds a 'silent' feature, instead of > walking to the end of the list. > > Prior to v4.6's 644c2ae198412 ("arm64: cpufeature: Test 'matches' pointer > to find the

[PATCH v6 01/13] arm64: cpufeature: __this_cpu_has_cap() shouldn't stop early

2018-01-15 Thread James Morse
this_cpu_has_cap() tests caps->desc not caps->matches, so it stops walking the list when it finds a 'silent' feature, instead of walking to the end of the list. Prior to v4.6's 644c2ae198412 ("arm64: cpufeature: Test 'matches' pointer to find the end of the list") we always tested desc to find