Re: [PATCH v6 05/18] ACPI / APEI: Make estatus queue a Kconfig symbol

2018-10-12 Thread Borislav Petkov
On Fri, Oct 12, 2018 at 06:17:48PM +0100, James Morse wrote: > Ripping out the existing #ifdefs and replacing them with IS_ENABLED() would > let > the compiler work out the estatus stuff is unused, and saves us describing the > what-uses-it logic in Kconfig. > > But this does expose the x86 nmi

Re: [PATCH v6 05/18] ACPI / APEI: Make estatus queue a Kconfig symbol

2018-10-12 Thread James Morse
Hi Boris, On 04/10/2018 18:34, Borislav Petkov wrote: > On Wed, Oct 03, 2018 at 06:50:36PM +0100, James Morse wrote: >> I'm all in favour of letting the compiler work it out, but the existing ghes >> code has #ifdef/#else all over the place. This is 'keeping the style'. > > Yeah, but this

Re: [PATCH v6 05/18] ACPI / APEI: Make estatus queue a Kconfig symbol

2018-10-04 Thread Borislav Petkov
On Wed, Oct 03, 2018 at 06:50:36PM +0100, James Morse wrote: > I'm all in favour of letting the compiler work it out, but the existing ghes > code has #ifdef/#else all over the place. This is 'keeping the style'. Yeah, but this "style" is not the optimal one and we should simplify/clean up and

Re: [PATCH v6 05/18] ACPI / APEI: Make estatus queue a Kconfig symbol

2018-10-01 Thread Borislav Petkov
On Fri, Sep 21, 2018 at 11:16:52PM +0100, James Morse wrote: > Now that there are two users of the estatus queue, and likely to be more, > make it a Kconfig symbol selected by the appropriate notification. We > can move the ARCH_HAVE_NMI_SAFE_CMPXCHG checks in here too. Ok, question: why do we

[PATCH v6 05/18] ACPI / APEI: Make estatus queue a Kconfig symbol

2018-09-21 Thread James Morse
Now that there are two users of the estatus queue, and likely to be more, make it a Kconfig symbol selected by the appropriate notification. We can move the ARCH_HAVE_NMI_SAFE_CMPXCHG checks in here too. Signed-off-by: James Morse --- drivers/acpi/apei/Kconfig | 6 ++