Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones

2021-06-11 Thread Paolo Bonzini
On 11/06/21 14:08, Christian Borntraeger wrote: I always interpreted it as "number of times the KVM page table management code needed other CPUs to learn about new page tables". Whether the broadcast is done in software or hardware shouldn't matter; either way I suppose there is still some

Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones

2021-06-11 Thread Christian Borntraeger
On 11.06.21 14:03, Paolo Bonzini wrote: On 11/06/21 14:00, Christian Borntraeger wrote: What is the semantics of remote_tlb_flush? I always interpreted it as "number of times the KVM page table management code needed other CPUs to learn about new page tables". Whether the broadcast is

Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones

2021-06-11 Thread Paolo Bonzini
On 11/06/21 14:00, Christian Borntraeger wrote: What is the semantics of remote_tlb_flush? I always interpreted it as "number of times the KVM page table management code needed other CPUs to learn about new page tables". Whether the broadcast is done in software or hardware shouldn't matter;

Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones

2021-06-11 Thread Christian Borntraeger
On 11.06.21 12:51, Paolo Bonzini wrote: On 11/06/21 08:57, Christian Borntraeger wrote: @@ -755,12 +750,12 @@ struct kvm_vcpu_arch {   };   struct kvm_vm_stat { +    struct kvm_vm_stat_generic generic; s390 does not have remote_tlb_flush. I guess this does not hurt? It would have to be

Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones

2021-06-11 Thread Christian Borntraeger
On 03.06.21 23:14, Jing Zhang wrote: Put all generic statistics in a separate structure to ease statistics handling for the incoming new statistics API. No functional change intended. Reviewed-by: David Matlack Reviewed-by: Ricardo Koller Signed-off-by: Jing Zhang [...] diff --git

Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones

2021-06-08 Thread Krish Sadhukhan
On 6/3/21 2:14 PM, Jing Zhang wrote: Put all generic statistics in a separate structure to ease statistics handling for the incoming new statistics API. No functional change intended. Reviewed-by: David Matlack Reviewed-by: Ricardo Koller Signed-off-by: Jing Zhang ---

[PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones

2021-06-03 Thread Jing Zhang
Put all generic statistics in a separate structure to ease statistics handling for the incoming new statistics API. No functional change intended. Reviewed-by: David Matlack Reviewed-by: Ricardo Koller Signed-off-by: Jing Zhang --- arch/arm64/include/asm/kvm_host.h | 9 ++---