Re: [PATCH 2/2] KVM: arm64: Remove use of ARM64_FEATURE_MASK()

2022-12-22 Thread Mark Brown
On Thu, Dec 22, 2022 at 12:23:49PM +, Marc Zyngier wrote: > Mark Brown wrote: > > the users to directly use the generated mask macros, writing > > > > #define ARM64_FEATURE_MASK(x) (x##_MASK) > > > > obviously looks redundant and if we look at the users updating them turns > If the

Re: [PATCH 2/2] KVM: arm64: Remove use of ARM64_FEATURE_MASK()

2022-12-22 Thread Marc Zyngier
On Wed, 21 Dec 2022 18:06:10 +, Mark Brown wrote: > > The KVM code makes extensive use of ARM64_FEATURE_MASK() to generate a > mask for fields in the ID registers. This macro has the assumption that > all feature fields are 4 bits wide but the architecture has evolved to > add fields with