Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-12 Thread Marc Zyngier
On 12/03/18 02:33, Yang, Shunyong wrote: > Hi, Marc, > > On Sun, 2018-03-11 at 12:17 +, Marc Zyngier wrote: >> On Sun, 11 Mar 2018 01:55:08 + >> Christoffer Dall wrote: >> >>> >>> On Sat, Mar 10, 2018 at 12:20 PM, Marc Zyngier >> m> wrote:

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-11 Thread Yang, Shunyong
Hi, Marc, On Sun, 2018-03-11 at 12:17 +, Marc Zyngier wrote: > On Sun, 11 Mar 2018 01:55:08 + > Christoffer Dall wrote: > > > > > On Sat, Mar 10, 2018 at 12:20 PM, Marc Zyngier > m> wrote: > > > > > > On Fri, 09 Mar 2018 21:36:12 +, > > >

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-10 Thread Christoffer Dall
On Sat, Mar 10, 2018 at 12:20 PM, Marc Zyngier wrote: > On Fri, 09 Mar 2018 21:36:12 +, > Christoffer Dall wrote: >> >> On Thu, Mar 08, 2018 at 05:28:44PM +, Marc Zyngier wrote: >> > I'd be more confident if we did forbid P+A for such interrupts >> > altogether, as

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-10 Thread Marc Zyngier
On Fri, 09 Mar 2018 21:36:12 +, Christoffer Dall wrote: > > On Thu, Mar 08, 2018 at 05:28:44PM +, Marc Zyngier wrote: > > I'd be more confident if we did forbid P+A for such interrupts > > altogether, as they really feel like another kind of HW interrupt. > > How about a slightly bigger

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-09 Thread Christoffer Dall
On Thu, Mar 08, 2018 at 05:28:44PM +, Marc Zyngier wrote: > On Thu, 08 Mar 2018 16:19:00 +, > Christoffer Dall wrote: > > > > On Thu, Mar 08, 2018 at 11:54:27AM +, Marc Zyngier wrote: > > > On 08/03/18 09:49, Marc Zyngier wrote: [...] > > > The state is now pending, we've really

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-09 Thread Marc Zyngier
On 09/03/18 13:10, Auger Eric wrote: > Hi Marc, > > On 09/03/18 10:40, Marc Zyngier wrote: >> On 09/03/18 03:14, Yang, Shunyong wrote: >> >> [trimming things a bit] >> > static bool lr_signals_eoi_mi(u32 lr_val) > { > - return !(lr_val & GICH_LR_STATE) && (lr_val &

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-09 Thread Auger Eric
Hi Marc, On 09/03/18 10:12, Marc Zyngier wrote: > On 08/03/18 18:12, Auger Eric wrote: >> Hi Marc, Christoffer, >> >> On 08/03/18 18:28, Marc Zyngier wrote: >>> On Thu, 08 Mar 2018 16:19:00 +, >>> Christoffer Dall wrote: On Thu, Mar 08, 2018 at 11:54:27AM +, Marc Zyngier wrote:

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-09 Thread Auger Eric
Hi Marc, On 09/03/18 10:40, Marc Zyngier wrote: > On 09/03/18 03:14, Yang, Shunyong wrote: > > [trimming things a bit] > static bool lr_signals_eoi_mi(u32 lr_val) { - return !(lr_val & GICH_LR_STATE) && (lr_val & GICH_LR_EOI) && -

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-09 Thread Marc Zyngier
On 09/03/18 03:14, Yang, Shunyong wrote: [trimming things a bit] >>>  static bool lr_signals_eoi_mi(u32 lr_val) >>>  { >>> - return !(lr_val & GICH_LR_STATE) && (lr_val & >>> GICH_LR_EOI) && >>> -    !(lr_val & GICH_LR_HW); >>> + return !((lr_val &

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-09 Thread Marc Zyngier
On 08/03/18 18:12, Auger Eric wrote: > Hi Marc, Christoffer, > > On 08/03/18 18:28, Marc Zyngier wrote: >> On Thu, 08 Mar 2018 16:19:00 +, >> Christoffer Dall wrote: >>> >>> On Thu, Mar 08, 2018 at 11:54:27AM +, Marc Zyngier wrote: On 08/03/18 09:49, Marc Zyngier wrote: >

Re: Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Yang, Shunyong
Hi, Eric, Marc and Christoffer, On Thu, 2018-03-08 at 19:12 +0100, Auger Eric wrote: > Hi Marc, Christoffer, > > On 08/03/18 18:28, Marc Zyngier wrote: > > > > On Thu, 08 Mar 2018 16:19:00 +, > > Christoffer Dall wrote: > > > > > > > > > On Thu, Mar 08, 2018 at 11:54:27AM +, Marc

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Auger Eric
Hi Marc, Christoffer, On 08/03/18 18:28, Marc Zyngier wrote: > On Thu, 08 Mar 2018 16:19:00 +, > Christoffer Dall wrote: >> >> On Thu, Mar 08, 2018 at 11:54:27AM +, Marc Zyngier wrote: >>> On 08/03/18 09:49, Marc Zyngier wrote: [updated Christoffer's email address] Hi

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Marc Zyngier
On Thu, 08 Mar 2018 16:19:00 +, Christoffer Dall wrote: > > On Thu, Mar 08, 2018 at 11:54:27AM +, Marc Zyngier wrote: > > On 08/03/18 09:49, Marc Zyngier wrote: > > > [updated Christoffer's email address] > > > > > > Hi Shunyong, > > > > > > On 08/03/18 07:01, Shunyong Yang wrote: > >

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Christoffer Dall
On Thu, Mar 08, 2018 at 11:54:27AM +, Marc Zyngier wrote: > On 08/03/18 09:49, Marc Zyngier wrote: > > [updated Christoffer's email address] > > > > Hi Shunyong, > > > > On 08/03/18 07:01, Shunyong Yang wrote: > >> When resampling irqfds is enabled, level interrupt should be > >> de-asserted

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Christoffer Dall
On Thu, Mar 08, 2018 at 09:49:43AM +, Marc Zyngier wrote: > [updated Christoffer's email address] > > Hi Shunyong, > > On 08/03/18 07:01, Shunyong Yang wrote: > > When resampling irqfds is enabled, level interrupt should be > > de-asserted when resampling happens. On page 4-47 of GIC v3 > >

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Auger Eric
Hi Marc, On 08/03/18 12:54, Marc Zyngier wrote: > On 08/03/18 09:49, Marc Zyngier wrote: >> [updated Christoffer's email address] >> >> Hi Shunyong, >> >> On 08/03/18 07:01, Shunyong Yang wrote: >>> When resampling irqfds is enabled, level interrupt should be >>> de-asserted when resampling

Re: [此邮件可能存在风险] Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Yang, Shunyong
Hi, Eric, First, please let me change Christoffer's email to cd...@kernel.org. I add more information about my test below, please check. On Thu, 2018-03-08 at 09:57 +0100, Auger Eric wrote: > Hi, > > On 08/03/18 08:01, Shunyong Yang wrote: > > > > When resampling irqfds is enabled, level

Re: [此邮件可能存在风险] Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Auger Eric
Hi Shunyong, On 08/03/18 10:31, Yang, Shunyong wrote: > Hi, Eric, > > First, please let me change Christoffer's email to cd...@kernel.org. I > add more information about my test below, please check. > > On Thu, 2018-03-08 at 09:57 +0100, Auger Eric wrote: >> Hi, >> >> On 08/03/18 08:01, Shunyong

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Marc Zyngier
On 08/03/18 09:49, Marc Zyngier wrote: > [updated Christoffer's email address] > > Hi Shunyong, > > On 08/03/18 07:01, Shunyong Yang wrote: >> When resampling irqfds is enabled, level interrupt should be >> de-asserted when resampling happens. On page 4-47 of GIC v3 >> specification IHI0069D, it

Re: [此邮件可能存在风险] Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Marc Zyngier
On 08/03/18 09:31, Yang, Shunyong wrote: > Hi, Eric, > > First, please let me change Christoffer's email to cd...@kernel.org. I > add more information about my test below, please check. > > On Thu, 2018-03-08 at 09:57 +0100, Auger Eric wrote: >> Hi, >> >> On 08/03/18 08:01, Shunyong Yang wrote:

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Marc Zyngier
[updated Christoffer's email address] Hi Shunyong, On 08/03/18 07:01, Shunyong Yang wrote: > When resampling irqfds is enabled, level interrupt should be > de-asserted when resampling happens. On page 4-47 of GIC v3 > specification IHI0069D, it said, > "When the PE acknowledges an SGI, a PPI, or

Re: [RFC PATCH] KVM: arm/arm64: vgic: change condition for level interrupt resampling

2018-03-08 Thread Auger Eric
Hi, On 08/03/18 08:01, Shunyong Yang wrote: > When resampling irqfds is enabled, level interrupt should be > de-asserted when resampling happens. On page 4-47 of GIC v3 > specification IHI0069D, it said, > "When the PE acknowledges an SGI, a PPI, or an SPI at the CPU > interface, the IRI changes