Re: disabling halt polling broken? (was Re: [PATCH 00/14] KVM: Halt-polling fixes, cleanups and a new stat)

2022-11-17 Thread wangyanan (Y)
On 2022/11/17 1:19, David Matlack wrote: On Tue, Nov 15, 2022 at 11:28:56AM +0800, wangyanan (Y) wrote: Hi Sean, Paolo, I recently also notice the behavior change of param halt_poll_ns. Now it loses the ability to: 1) dynamically disable halt polling for all the running VMs by `echo 0 >

Re: [PATCH v4 07/16] KVM: arm64: PMU: Add counter_index_to_*reg() helpers

2022-11-17 Thread Reiji Watanabe
Hi Marc, On Sun, Nov 13, 2022 at 8:38 AM Marc Zyngier wrote: > > In order to reduce the boilerplate code, add two helpers returning > the counter register index (resp. the event register) in the vcpu > register file from the counter index. > > Reviewed-by: Oliver Upton > Signed-off-by: Marc

Re: [PATCH v4 09/16] KVM: arm64: PMU: Do not let AArch32 change the counters' top 32 bits

2022-11-17 Thread Reiji Watanabe
Hi Marc, On Sun, Nov 13, 2022 at 8:38 AM Marc Zyngier wrote: > > Even when using PMUv3p5 (which implies 64bit counters), there is > no way for AArch32 to write to the top 32 bits of the counters. > The only way to influence these bits (other than by counting > events) is by writing PMCR.P==1. >

Re: [PATCH 0/2] KVM: arm64: selftests: Fixes for single-step test

2022-11-17 Thread Marc Zyngier
On Thu, 17 Nov 2022 00:23:48 +, Sean Christopherson wrote: > > Marc, > > I would like to route this through Paolo's tree/queue for 6.2 along with > a big pile of other selftests updates. I am hoping to get the selftests > pile queued sooner than later as there is a lot of active

Re: [PATCH v3 0/8] perf: Arm SPEv1.2 support

2022-11-17 Thread Rob Herring
On Fri, Nov 4, 2022 at 10:55 AM Rob Herring wrote: > > This series adds support for Arm SPEv1.2 which is part of the > Armv8.7/Armv9.2 architecture. There's 2 new features that affect the > kernel: a new event filter bit, branch 'not taken', and an inverted > event filter register. > > Since this

Re: [PATCH 2/2] KVM: arm64: selftests: Disable single-step without relying on ucall()

2022-11-17 Thread Sean Christopherson
On Thu, Nov 17, 2022, Sean Christopherson wrote: > On Thu, Nov 17, 2022, Oliver Upton wrote: > > On Thu, Nov 17, 2022 at 12:23:50AM +, Sean Christopherson wrote: > > > Automatically disable single-step when the guest reaches the end of the > > > verified section instead of using an explicit

Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling

2022-11-17 Thread Sean Christopherson
On Thu, Nov 17, 2022, Huang, Kai wrote: > On Wed, 2022-11-16 at 17:11 +, Sean Christopherson wrote: > > static int kvm_x86_check_processor_compatibility(void) > > { > > int cpu = smp_processor_id(); > > struct cpuinfo_x86 *c = _data(cpu); > > > > /* > > *

Re: [PATCH v3 2/2] KVM: arm64: Don't acquire RCU read lock for exclusive table walks

2022-11-17 Thread Will Deacon
On Wed, Nov 16, 2022 at 04:56:55PM +, Oliver Upton wrote: > Marek reported a BUG resulting from the recent parallel faults changes, > as the hyp stage-1 map walker attempted to allocate table memory while > holding the RCU read lock: > > BUG: sleeping function called from invalid context at

Re: [PATCH v3 2/2] KVM: arm64: Don't acquire RCU read lock for exclusive table walks

2022-11-17 Thread Oliver Upton
Hi Will, Thanks for having a look. On Thu, Nov 17, 2022 at 05:49:52PM +, Will Deacon wrote: > On Wed, Nov 16, 2022 at 04:56:55PM +, Oliver Upton wrote: [...] > > -static inline void kvm_pgtable_walk_begin(void) {} > > -static inline void kvm_pgtable_walk_end(void) {} > > +static inline

Re: [External] Re: [v2 0/6] KVM: arm64: implement vcpu_is_preempted check

2022-11-17 Thread Marc Zyngier
On Mon, 07 Nov 2022 12:00:44 +, Usama Arif wrote: > > > > On 06/11/2022 16:35, Marc Zyngier wrote: > > On Fri, 04 Nov 2022 06:20:59 +, > > Usama Arif wrote: > >> > >> This patchset adds support for vcpu_is_preempted in arm64, which > >> allows the guest to check if a vcpu was

Re: [PATCH 2/2] KVM: arm64: selftests: Disable single-step without relying on ucall()

2022-11-17 Thread Sean Christopherson
On Thu, Nov 17, 2022, Sean Christopherson wrote: > On Thu, Nov 17, 2022, Sean Christopherson wrote: > > On Thu, Nov 17, 2022, Oliver Upton wrote: > > > On Thu, Nov 17, 2022 at 12:23:50AM +, Sean Christopherson wrote: > > > > Automatically disable single-step when the guest reaches the end of

Re: [RFC PATCH 04/12] KVM: arm64: Add kvm_pgtable_stage2_split()

2022-11-17 Thread Ricardo Koller
On Tue, Nov 15, 2022 at 11:54:27PM +, Oliver Upton wrote: > On Tue, Nov 15, 2022 at 03:27:18PM -0800, Ricardo Koller wrote: > > On Tue, Nov 15, 2022 at 03:03:42PM -0800, Ricardo Koller wrote: > > > On Mon, Nov 14, 2022 at 08:54:52PM +, Oliver Upton wrote: > > [...] > > > > > > diff --git