Re: [PATCH 5/6] irqchip: GICv3: Don't deactivate interrupts forwarded to a guest

2015-08-12 Thread Marc Zyngier
On 12/08/15 16:09, Eric Auger wrote: On 08/12/2015 04:20 PM, Marc Zyngier wrote: On 11/08/15 11:03, Eric Auger wrote: On 07/09/2015 03:19 PM, Marc Zyngier wrote: Commit 0a4377de3056 (genirq: Introduce irq_set_vcpu_affinity() to target an interrupt to a VCPU) added just what we needed at the

Re: [PATCH 5/6] irqchip: GICv3: Don't deactivate interrupts forwarded to a guest

2015-08-12 Thread Eric Auger
On 08/12/2015 05:40 PM, Marc Zyngier wrote: On 12/08/15 16:09, Eric Auger wrote: On 08/12/2015 04:20 PM, Marc Zyngier wrote: On 11/08/15 11:03, Eric Auger wrote: On 07/09/2015 03:19 PM, Marc Zyngier wrote: Commit 0a4377de3056 (genirq: Introduce irq_set_vcpu_affinity() to target an interrupt

Re: [PATCH v4 06/11] KVM: arm/arm64: vgic: Allow dynamic mapping of physical/virtual interrupts

2015-08-12 Thread Marc Zyngier
On Tue, 11 Aug 2015 08:42:37 +0100 Christoffer Dall christoffer.d...@linaro.org wrote: On Fri, Aug 07, 2015 at 04:45:42PM +0100, Marc Zyngier wrote: In order to be able to feed physical interrupts to a guest, we need to be able to establish the virtual-physical mapping between the two

Re: KVM Live migration with GICv3

2015-08-12 Thread Peter Maydell
On 12 August 2015 at 17:17, Marc Zyngier marc.zyng...@arm.com wrote: If you plan to do anything for GICv3, you should only deal with with the system register version of the CPU interface. Also, please make sure that you think about (and in terms of) the underlying state inside the GIC, which is

Re: KVM Live migration with GICv3

2015-08-12 Thread Marc Zyngier
On 11/08/15 06:25, Vijay Kilari wrote: Hi, I have prototyped Live migration with GICv3. For this I have made following changes 1) Save and Restore of GICv3 registers in QEMU. - For GICv2, QEMU is saving/restoring GICD, GICC registers. For GICv3, we have to save/restore GICD,

Re: [PATCH v4 06/11] KVM: arm/arm64: vgic: Allow dynamic mapping of physical/virtual interrupts

2015-08-12 Thread Christoffer Dall
On Wed, Aug 12, 2015 at 10:56:38AM +0100, Marc Zyngier wrote: On Tue, 11 Aug 2015 08:42:37 +0100 Christoffer Dall christoffer.d...@linaro.org wrote: On Fri, Aug 07, 2015 at 04:45:42PM +0100, Marc Zyngier wrote: In order to be able to feed physical interrupts to a guest, we need to be

Re: [PATCH v2 05/15] KVM: arm/arm64: make GIC frame address initialization model specific

2015-08-12 Thread Eric Auger
On 07/10/2015 04:21 PM, Andre Przywara wrote: Currently we initialize all the possible GIC frame addresses in one function, without looking at the specific GIC model we instantiate for the guest. As this gets confusing when adding another VGIC model later, lets move these initializations into

Re: [PATCH v2 04/15] KVM: arm/arm64: extend arch CAP checks to allow per-VM capabilities

2015-08-12 Thread Eric Auger
Reviewed-by: Eric Auger eric.au...@linaro.org Best Regards Eric On 07/10/2015 04:21 PM, Andre Przywara wrote: KVM capabilities can be a per-VM property, though ARM/ARM64 currently does not pass on the VM pointer to the architecture specific capability handlers. Add a struct kvm* parameter

Re: [PATCH 1/6] irqchip: GICv3: Convert to EOImode == 1

2015-08-12 Thread Marc Zyngier
On 11/08/15 10:14, Eric Auger wrote: Hi Marc, On 07/09/2015 03:19 PM, Marc Zyngier wrote: So far, GICv3 has been used in with EOImode == 0. The effect of this mode is to perform the priority drop and the deactivation of the interrupt at the same time. While this works perfectly for Linux

Re: [PATCH 2/6] irqchip: GIC: Convert to EOImode == 1

2015-08-12 Thread Marc Zyngier
Hi Eric, On 11/08/15 10:15, Eric Auger wrote: Hi Marc, On 07/09/2015 03:19 PM, Marc Zyngier wrote: So far, GICv2 has been used in with EOImode == 0. The effect of this mode is to perform the priority drop and the deactivation of the interrupt at the same time. While this works perfectly

Re: [PATCH 3/6] irqchip: GICv3: Skip LPI deactivation

2015-08-12 Thread Marc Zyngier
On 11/08/15 10:42, Eric Auger wrote: On 07/09/2015 03:19 PM, Marc Zyngier wrote: Contrary to other GICv3 interrupts, LPIs do not have an active state by virtue of being edge-triggered only (they only have a pending state). Given this, there is no point trying to deactivate them, and we can

Re: [PATCH 2/6] irqchip: GIC: Convert to EOImode == 1

2015-08-12 Thread Catalin Marinas
On Wed, Aug 12, 2015 at 02:31:47PM +0100, Marc Zyngier wrote: On 11/08/15 10:15, Eric Auger wrote: On 07/09/2015 03:19 PM, Marc Zyngier wrote: static int gic_irq_set_irqchip_state(struct irq_data *d, @@ -272,11 +278,15 @@ static void __exception_irq_entry gic_handle_irq(struct pt_regs

Re: [PATCH v3 04/10] VFIO: platform: add vfio_platform_set_automasked

2015-08-12 Thread Alex Williamson
On Mon, 2015-08-10 at 15:20 +0200, Eric Auger wrote: This function makes possible to change the automasked mode. Signed-off-by: Eric Auger eric.au...@linaro.org --- v1 - v2: - set forwarded flag --- drivers/vfio/platform/vfio_platform_irq.c | 19 +++ 1 file changed,

Re: [PATCH v3 06/10] VFIO: platform: add irq bypass producer management

2015-08-12 Thread Alex Williamson
On Mon, 2015-08-10 at 15:21 +0200, Eric Auger wrote: This patch populates the IRQ bypass callacks: - stop/start producer simply consist in disabling/enabling the host irq - add/del consumer: basically set the automasked flag to false/true Signed-off-by: Eric Auger eric.au...@linaro.org

Re: [PATCH v5 5/5] KVM: eventfd: add irq bypass consumer management

2015-08-12 Thread Alex Williamson
On Mon, 2015-08-10 at 15:31 +0200, Eric Auger wrote: This patch adds the registration/unregistration of an irq_bypass_consumer on irqfd assignment/deassignment. Signed-off-by: Eric Auger eric.au...@linaro.org Signed-off-by: Feng Wu feng...@intel.com --- v4 - v5: - due to removal of

Re: [PATCH v3 01/10] VFIO: platform: registration of a dummy IRQ bypass producer

2015-08-12 Thread Alex Williamson
On Mon, 2015-08-10 at 15:20 +0200, Eric Auger wrote: Register a dummy producer with void callbacks Signed-off-by: Eric Auger eric.au...@linaro.org --- v2 - v3: - rename vfio_platform_irq_bypass_resume into *_start --- drivers/vfio/platform/vfio_platform_irq.c | 32