Re: [PATCH] updated: arm64: KVM: vgic: deal with GIC sub-page alignment

2016-07-08 Thread Itaru Kitayama
Forgot to mention that all tests/attempts were done on an ACPI-based system. On 7/9/16 9:27 AM, Itaru Kitayama wrote: Marc, I'm at the latest commit, fa9301d in the gicv-align branch at the moment, with that an unmodified QEMU guest boots fine on a 64Kb page granular host, thanks to the

Re: [PATCH] updated: arm64: KVM: vgic: deal with GIC sub-page alignment

2016-07-08 Thread Itaru Kitayama
Marc, I'm at the latest commit, fa9301d in the gicv-align branch at the moment, with that an unmodified QEMU guest boots fine on a 64Kb page granular host, thanks to the trapping you introduced. (I wanted to get some performance statistics of the new feature with perf, but on arm64 most of

Re: [RFC v6 4/6] KVM: arm/arm64: enable irqchip routing

2016-07-08 Thread Radim Krčmář
2016-07-08 10:52+0200, Andrew Jones: > On Fri, Jul 08, 2016 at 10:16:53AM +0200, Auger Eric wrote: >> On 07/07/2016 19:20, Andrew Jones wrote: >> > On Wed, Jul 06, 2016 at 10:47:53AM +0200, Eric Auger wrote: >> >> diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c >> >> @@ -29,7 +29,9 @@ >> >>

Re: [PATCH v8 08/17] KVM: arm64: handle ITS related GICv3 redistributor registers

2016-07-08 Thread Christoffer Dall
On Tue, Jul 05, 2016 at 12:23:00PM +0100, Andre Przywara wrote: > In the GICv3 redistributor there are the PENDBASER and PROPBASER > registers which we did not emulate so far, as they only make sense > when having an ITS. In preparation for that emulate those MMIO > accesses by storing the 64-bit

Re: [PATCH v8 11/17] KVM: arm64: implement basic ITS register handlers

2016-07-08 Thread Marc Zyngier
On 05/07/16 12:23, Andre Przywara wrote: > Add emulation for some basic MMIO registers used in the ITS emulation. > This includes: > - GITS_{CTLR,TYPER,IIDR} > - ID registers > - GITS_{CBASER,CREADR,CWRITER} > (which implement the ITS command buffer handling) > - GITS_BASER > > Most of the

Re: [PATCH v8 09/17] KVM: arm64: introduce ITS emulation file with MMIO framework

2016-07-08 Thread André Przywara
On 08/07/16 14:34, Marc Zyngier wrote: > On 05/07/16 12:23, Andre Przywara wrote: >> The ARM GICv3 ITS emulation code goes into a separate file, but needs >> to be connected to the GICv3 emulation, of which it is an option. >> The ITS MMIO handlers require the respective ITS pointer to be passed

Re: [PATCH v8 09/17] KVM: arm64: introduce ITS emulation file with MMIO framework

2016-07-08 Thread Marc Zyngier
On 08/07/16 14:34, Marc Zyngier wrote: > On 05/07/16 12:23, Andre Przywara wrote: >> The ARM GICv3 ITS emulation code goes into a separate file, but needs >> to be connected to the GICv3 emulation, of which it is an option. >> The ITS MMIO handlers require the respective ITS pointer to be passed

Re: [PATCH v8 09/17] KVM: arm64: introduce ITS emulation file with MMIO framework

2016-07-08 Thread Marc Zyngier
On 05/07/16 12:23, Andre Przywara wrote: > The ARM GICv3 ITS emulation code goes into a separate file, but needs > to be connected to the GICv3 emulation, of which it is an option. > The ITS MMIO handlers require the respective ITS pointer to be passed in, > so we amend the existing VGIC MMIO

Re: [PATCH v8 06/17] KVM: arm/arm64: VGIC: add refcounting for IRQs

2016-07-08 Thread André Przywara
On 08/07/16 14:09, Marc Zyngier wrote: > On 08/07/16 13:54, André Przywara wrote: >> On 08/07/16 11:50, Marc Zyngier wrote: >>> On 08/07/16 11:28, Andre Przywara wrote: Hi, On 07/07/16 16:00, Marc Zyngier wrote: > On 05/07/16 12:22, Andre Przywara wrote: >> @@ -236,6

Re: [PATCH v8 06/17] KVM: arm/arm64: VGIC: add refcounting for IRQs

2016-07-08 Thread Marc Zyngier
On 08/07/16 13:54, André Przywara wrote: > On 08/07/16 11:50, Marc Zyngier wrote: >> On 08/07/16 11:28, Andre Przywara wrote: >>> Hi, >>> >>> On 07/07/16 16:00, Marc Zyngier wrote: On 05/07/16 12:22, Andre Przywara wrote: > In the moment our struct vgic_irq's are statically allocated at

Re: [PATCH v8 06/17] KVM: arm/arm64: VGIC: add refcounting for IRQs

2016-07-08 Thread André Przywara
On 08/07/16 11:50, Marc Zyngier wrote: > On 08/07/16 11:28, Andre Przywara wrote: >> Hi, >> >> On 07/07/16 16:00, Marc Zyngier wrote: >>> On 05/07/16 12:22, Andre Przywara wrote: In the moment our struct vgic_irq's are statically allocated at guest creation time. So getting a pointer to

Re: [PATCH v8 06/17] KVM: arm/arm64: VGIC: add refcounting for IRQs

2016-07-08 Thread Marc Zyngier
On 08/07/16 11:28, Andre Przywara wrote: > Hi, > > On 07/07/16 16:00, Marc Zyngier wrote: >> On 05/07/16 12:22, Andre Przywara wrote: >>> In the moment our struct vgic_irq's are statically allocated at guest >>> creation time. So getting a pointer to an IRQ structure is trivial and >>> safe. LPIs

Re: [PATCH v8 06/17] KVM: arm/arm64: VGIC: add refcounting for IRQs

2016-07-08 Thread Andre Przywara
Hi, On 07/07/16 16:00, Marc Zyngier wrote: > On 05/07/16 12:22, Andre Przywara wrote: >> In the moment our struct vgic_irq's are statically allocated at guest >> creation time. So getting a pointer to an IRQ structure is trivial and >> safe. LPIs are more dynamic, they can be mapped and unmapped

Re: [RFC v6 4/6] KVM: arm/arm64: enable irqchip routing

2016-07-08 Thread Andrew Jones
On Fri, Jul 08, 2016 at 10:16:53AM +0200, Auger Eric wrote: > Hi Drew, > > On 07/07/2016 19:20, Andrew Jones wrote: > > On Wed, Jul 06, 2016 at 10:47:53AM +0200, Eric Auger wrote: > >> This patch adds compilation and link against irqchip. > >> > >> Main motivation behind using irqchip code is to

Re: [RFC v6 4/6] KVM: arm/arm64: enable irqchip routing

2016-07-08 Thread Auger Eric
Hi Drew, On 07/07/2016 19:20, Andrew Jones wrote: > On Wed, Jul 06, 2016 at 10:47:53AM +0200, Eric Auger wrote: >> This patch adds compilation and link against irqchip. >> >> Main motivation behind using irqchip code is to enable MSI >> routing code. In the future irqchip routing may also be