Re: [PULL 0/8] KVM/ARM Fixes for v4.7-rc2

2016-06-02 Thread Radim Krčmář
2016-06-02 12:20+0200, Christoffer Dall: > Hi Paolo and Radim, > > The following changes since commit 1a695a905c18548062509178b98bc91e67510864: > > Linux 4.7-rc1 (2016-05-29 09:29:24 -0700) > > are available in the git repository at: > >

Re: [RFC v7 7/7] KVM: arm: enable KVM_SIGNAL_MSI and MSI routing

2016-07-22 Thread Radim Krčmář
2016-07-21 23:10+0200, Auger Eric: > On 21/07/2016 18:33, Radim Krčmář wrote: >> 2016-07-18 13:25+, Eric Auger: >>> If the ITS modality is not available, let's simply support MSI >>> injection by transforming the MSI.data into an SPI ID. >>> >>>

Re: [RFC v7 7/7] KVM: arm: enable KVM_SIGNAL_MSI and MSI routing

2016-07-22 Thread Radim Krčmář
2016-07-22 15:52+0200, Auger Eric: > On 22/07/2016 15:39, Radim Krčmář wrote: >> 2016-07-21 23:10+0200, Auger Eric: >>> On 21/07/2016 18:33, Radim Krčmář wrote: >>>> 2016-07-18 13:25+, Eric Auger: >>>>> If the ITS modality is not availa

Re: [RFC v8 5/7] KVM: arm/arm64: Enable irqchip routing

2016-07-22 Thread Radim Krčmář
2016-07-22 13:46+, Eric Auger: > This patch adds compilation and link against irqchip. > > Main motivation behind using irqchip code is to enable MSI > routing code. In the future irqchip routing may also be useful > when targeting multiple irqchips. > > Routing standard callbacks now are

Re: [RFC v9 0/6] KVM: arm/arm64: gsi routing support

2016-07-22 Thread Radim Krčmář
2016-07-22 16:20+, Eric Auger: > With the advent of GICv3 ITS in-kernel emulation, KVM MSI routing > becomes mandated for proper VIRTIO-PCI vhost integration. Changes to interfaces and common code look ok, Acked-by: Radim Krčmář <rkrc...@redhat.com>

Re: [PATCH v2 0/2] KVM: Synchronize KVM devices list access and create ops

2016-08-12 Thread Radim Krčmář
2016-08-09 19:12+0200, Christoffer Dall: > Currently accesses the kvm->devices list is not synchronized by any > mechanism which can potentially lead to data corruption. Further, a > number of the create operations on the individual devices are racy and > would allow creation of multiple devices,

Re: [PATCH v2] arm64: KVM: VHE: Context switch MDSCR_EL1

2016-07-21 Thread Radim Krčmář
2016-07-19 13:56+0100, Marc Zyngier: > The kprobe enablement work has uncovered that changes made by > a guest to MDSCR_EL1 were propagated to the host when VHE was > enabled, leading to unexpected exception being delivered. > > Moving this register to the list of registers that are always >

Re: [PATCH v2] arm64: KVM: VHE: Context switch MDSCR_EL1

2016-07-21 Thread Radim Krčmář
2016-07-21 14:24+0100, Marc Zyngier: > On Thu, 21 Jul 2016 15:17:20 +0200 > Radim Krčmář <rkrc...@redhat.com> wrote: > > Hi Radim, > >> 2016-07-19 13:56+0100, Marc Zyngier: >> > The kprobe enablement work has uncovered that changes made by >> > a g

Re: [RFC v7 2/7] KVM: kvm_host: add devid in kvm_kernel_irq_routing_entry

2016-07-21 Thread Radim Krčmář
2016-07-18 13:25+, Eric Auger: > Extend kvm_kernel_irq_routing_entry to transport the device id > field, devid. A new flags field makes possible to indicate the > devid is valid. Those additions are used for ARM GICv3 ITS MSI > injection. > > Signed-off-by: Eric Auger

Re: [RFC v7 1/7] KVM: api: pass the devid in the msi routing entry

2016-07-21 Thread Radim Krčmář
2016-07-18 13:25+, Eric Auger: > On ARM, the MSI msg (address and data) comes along with > out-of-band device ID information. The device ID encodes the > device that writes the MSI msg. Let's convey the device id in > kvm_irq_routing_msi and use KVM_MSI_VALID_DEVID flag value in >

Re: [RFC v6 4/6] KVM: arm/arm64: enable irqchip routing

2016-07-08 Thread Radim Krčmář
2016-07-08 10:52+0200, Andrew Jones: > On Fri, Jul 08, 2016 at 10:16:53AM +0200, Auger Eric wrote: >> On 07/07/2016 19:20, Andrew Jones wrote: >> > On Wed, Jul 06, 2016 at 10:47:53AM +0200, Eric Auger wrote: >> >> diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c >> >> @@ -29,7 +29,9 @@ >> >>

Re: [RFC v7 1/7] KVM: api: pass the devid in the msi routing entry

2016-07-21 Thread Radim Krčmář
2016-07-21 17:43+0100, Andre Przywara: > Hi Radim, > > On 21/07/16 17:01, Radim Krčmář wrote: >> 2016-07-18 13:25+, Eric Auger: >>> On ARM, the MSI msg (address and data) comes along with >>> out-of-band device ID information. The device ID encodes the &

Re: [RFC v7 2/7] KVM: kvm_host: add devid in kvm_kernel_irq_routing_entry

2016-07-21 Thread Radim Krčmář
2016-07-21 17:54+0100, Marc Zyngier: > On 21/07/16 17:13, Radim Krčmář wrote: >> 2016-07-18 13:25+, Eric Auger: >>> Extend kvm_kernel_irq_routing_entry to transport the device id >>> field, devid. A new flags field makes possible to indicate the >>> devi

Re: [PATCH] KVM: race-free exit from KVM_RUN without POSIX signals

2017-02-16 Thread Radim Krčmář
> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- The old immediate exit with signal did more work, but none of it should affect user-space, so it looks like another minor optimization, Reviewed-by: Radim Krčmář <rkrc...@redhat.com> > change from RFC: &

Re: [PATCH 0/3] KVM/ARM updates for 4.10-rc4

2017-01-17 Thread Radim Krčmář
2017-01-13 11:31+, Marc Zyngier: > Radim, Paolo, > > Here's the KVM/ARM updates for 4.10-rc4. Two timer fixes, and one vgic > fix for a deadlock that's been reported this week (which should land > into stable). Pulled to kvm/master, thanks. ___

Re: [kvm-unit-tests PATCH] configure: honour $ARCH and $CROSS_COMPILE

2016-11-21 Thread Radim Krčmář
2016-11-21 18:22+, Andre Przywara: > Both environment variables seem to be standard in cross-compilation > environments, especially with Linux. > Let the configure script take those into account when setting the default > values for --arch and --cross-prefix. Explicitly specifying the latter >

Re: [PULL] KVM/ARM updates for 4.9-rc6

2016-11-19 Thread Radim Krčmář
2016-11-18 09:39+, Marc Zyngier: > Paolo, Radim, > > Please find below the pull request for a couple of fixes for the > PMU emulation, courtesy of Wei. Both patches are candidates for stable. Pulled, thanks. ___ kvmarm mailing list

Re: [PULL] KVM/ARM updates for 4.9-rc7

2016-12-01 Thread Radim Krčmář
2016-12-01 09:25+, Marc Zyngier: > Paolo, Radim, > > Hopefully, this is the last update for 4.9. This time, a single patch > that prevents bogus acknoledgement of interrupts. > > It'd be great if this could make it into v4.9-final Pulled, thanks.

Re: [PATCH v2 1/9] KVM: add kvm_request_pending

2017-04-11 Thread Radim Krčmář
2017-04-08 15:32-0400, Paolo Bonzini: > > > Makes sense. My pitch at the documentation after dropping READ_ONCE(): > > > > I'm confused again, I thought you wanted to keep READ_ONCE(). > > > > > > > > /* > > >* The return value of kvm_request_pending() is implicitly volatile > > > >

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-06 Thread Radim Krčmář
2017-04-06 12:18+0200, Christian Borntraeger: > On 03/31/2017 06:06 PM, Andrew Jones wrote: >> Signed-off-by: Andrew Jones >> +VCPU Requests and Guest Mode >> + > > FWIW, s390 does not implement the guest mode. Maybe add some words that not > all

Re: [PATCH v2 1/9] KVM: add kvm_request_pending

2017-04-07 Thread Radim Krčmář
2017-04-06 16:25+0200, Christoffer Dall: > On Wed, Apr 05, 2017 at 10:20:17PM +0200, Radim Krčmář wrote: >> 2017-04-05 19:39+0200, Christoffer Dall: >> > On Wed, Apr 05, 2017 at 03:10:50PM +0200, Radim Krčmář wrote: >> x86 uses KVM_REQ_MCLOCK_INPROGRESS for synch

Re: [PATCH v2 2/9] KVM: Add documentation for VCPU requests

2017-04-05 Thread Radim Krčmář
2017-04-04 19:23+0200, Christoffer Dall: > On Tue, Apr 04, 2017 at 07:06:00PM +0200, Andrew Jones wrote: >> On Tue, Apr 04, 2017 at 05:24:03PM +0200, Christoffer Dall wrote: >> > On Fri, Mar 31, 2017 at 06:06:51PM +0200, Andrew Jones wrote: >> > > +and will definitely see the request, or is

Re: [PATCH v2 1/9] KVM: add kvm_request_pending

2017-04-05 Thread Radim Krčmář
2017-04-04 18:41+0200, Andrew Jones: > On Tue, Apr 04, 2017 at 05:30:14PM +0200, Christoffer Dall wrote: >> On Fri, Mar 31, 2017 at 06:06:50PM +0200, Andrew Jones wrote: >> > From: Radim Krčmář <rkrc...@redhat.com> >> > >> > A first step in vcpu->

Re: [PULL 0/5] KVM/ARM Fixes for v4.11-rc6

2017-04-05 Thread Radim Krčmář
2017-04-05 12:13+0200, Christoffer Dall: > Hi Paolo and Radim, > > Please pull a handfull of fixes for the next -rc release of v4.11. > > They include: > - Addressing a problem with GICv3 userspace save/restore > - Clarify GICv2 userspace save/restore ABI > - Be more careful in clearing GIC

Re: [PATCH 00/10] KVM/ARM fixes for 4.11-rc2

2017-03-09 Thread Radim Krčmář
2017-03-09 09:55+, Marc Zyngier: > Paolo, Radim, > > Here's the KVM/ARM updates for 4.11-rc2. The usual bag of vgic > updates, making the memslot array large enough to handle guests with > tons of devices assigned to them, a tidying up of exception handling, > and a rather annoying TLB

Re: [kvm-unit-tests PATCH] arm/arm64: gic: Test changing active state of interrupts

2017-03-08 Thread Radim Krčmář
2017-03-08 03:45-0800, Christoffer Dall: > On Tue, Mar 07, 2017 at 08:34:33PM +0100, Radim Krčmář wrote: > > 2017-03-07 17:58+0100, Andrew Jones: > > > On Mon, Mar 06, 2017 at 07:16:09AM -0800, Christoffer Dall wrote: > > > > From: Christoffer Dall <cd...@lina

Re: [PATCH kvm-unit-tests 1/2] arm/arm64: Add PSCI tests

2017-03-03 Thread Radim Krčmář
2017-02-27 18:32+0100, Andrew Jones: > From: Levente Kurusa > > The cpu_on test exposed two races in KVM's PSCI emulation. > > Signed-off-by: Levente Kurusa > [Rewrote the cpu_on test to improve the chance of hitting the race. > Also added affinity-info

Re: [PATCH kvm-unit-tests v2 0/2] arm/arm64: introduce PSCI tests

2017-03-03 Thread Radim Krčmář
Applied, thanks. 2017-03-03 15:30+0100, Andrew Jones: > Andrew Jones (1): > arm/arm64: psci: support testing tcg > > Levente Kurusa (1): > arm/arm64: Add PSCI tests > > arm/Makefile.common | 1 + > arm/psci.c | 150 > >

Re: [kvm-unit-tests PATCH] arm/arm64: gic: Test changing active state of interrupts

2017-03-07 Thread Radim Krčmář
2017-03-07 17:58+0100, Andrew Jones: > On Mon, Mar 06, 2017 at 07:16:09AM -0800, Christoffer Dall wrote: > > From: Christoffer Dall > > > > We found a deadlock when changing the active state of an interrupt while > > the interrupt is queued on the LR of the running VCPU. > > >

Re: [PATCH 0/4] KVM/ARM fixes for 4.13-rc4

2017-08-03 Thread Radim Krčmář
2017-08-03 16:28+0100, Marc Zyngier: > Paolo, Radim, > > Here's a pull request for a few KVM/ARM updates. Nothing major except > for a VM destruction race (Suzuki has a knack for finding those...). > > Please pull. Pulled, thanks. ___ kvmarm mailing

Re: [PATCH kvm-unit-tests] arm64: timer: Use correct counter for !pending_before

2017-08-03 Thread Radim Krčmář
2017-08-03 08:25+0200, Christoffer Dall: > We were using the virtual counter to calculate a timer cval which is 10 > seconds in the future, but this obviously doesn't work for the physical > timer which is bases on the physical counter. > > Make sure we use a properly paired timer/counter pair. >

Re: [PATCH 1/2] kvm: Fix mmu_notifier release race

2017-04-25 Thread Radim Krčmář
2017-04-24 11:10+0100, Suzuki K Poulose: > The KVM uses mmu_notifier (wherever available) to keep track > of the changes to the mm of the guest. The guest shadow page > tables are released when the VM exits via mmu_notifier->ops.release(). > There is a rare chance that the mmu_notifier->release

Re: [PULL 00/13] KVM/ARM Fixes for v4.12-rc2

2017-05-18 Thread Radim Krčmář
2017-05-18 11:47+0200, Christoffer Dall: > Hi Radim and Paolo, > > Here is a fairly large set of fixes post -rc1 for KVM/ARM. > > The fixes include: > - A fix for a build failure introduced in -rc1 when tracepoints are >enabled on 32-bit ARM. > - Disabling use of stack pointer protection

Re: [PULL 0/3] KVM/ARM Fixes for v4.12-rc5

2017-06-07 Thread Radim Krčmář
2017-06-06 22:21+0200, Christoffer Dall: > On Tue, Jun 06, 2017 at 03:56:26PM +0200, Christoffer Dall wrote: > > Hi Radim and Paolo, > > > > Three additional fixes for KVM/ARM for v4.12. > > We didn't expect three additional fixes to pop up so quickly, so I'm > going to send another pull request

Re: [PATCH 05/37] KVM: Record the executing ioctl number on the vcpu struct

2017-10-13 Thread Radim Krčmář
the vcpu. > > Cc: Paolo Bonzini <pbonz...@redhat.com> > Cc: Radim Krčmář <rkrc...@redhat.com> > Signed-off-by: Christoffer Dall <christoffer.d...@linaro.org> > --- > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > @@ -147,12 +147,13 @@ bool kvm_is_r

Re: [PATCH 05/37] KVM: Record the executing ioctl number on the vcpu struct

2017-10-13 Thread Radim Krčmář
2017-10-13 19:31+0200, Christoffer Dall: > On Fri, Oct 13, 2017 at 07:13:07PM +0200, Radim Krčmář wrote: > > I think that other (special) callsites of vcpu_load()/vcpu_put() have a > > well defined IOCTL that can be used instead of vcpu->ioctl, so we could > > just pass the

Re: [PULL 00/26] KVM/ARM Changes for v4.15

2017-11-09 Thread Radim Krčmář
2017-11-07 11:47+0100, Christoffer Dall: > Hi Paolo and Radim, > > Here is the first round of KVM/ARM Changes for v4.15. I will follow up > with a second pull request based on tip:irq/core containing the KVM/ARM > side of the GICv4 support. > > Changes in this pull requestinclude: > -

Re: [PULL 00/19] KVM/ARM Fixes for v4.15

2017-12-05 Thread Radim Krčmář
2017-12-04 14:56+0100, Christoffer Dall: > From: Christoffer Dall > > Hi Paolo and Radim, > > Here's the first round of fixes for KVM/ARM for v4.15. This is a fairly large > set of fixes, partially because we spotted a handful of issues from running > the > SMATCH

Re: [GIT PULL] KVM/arm updates for 4.18-rc2

2018-06-22 Thread Radim Krčmář
2018-06-22 13:49+0100, Marc Zyngier: > Radim, Paolo, > > This is the first batch of fixes for 4.18, mostly dealing with the > fallout from Dave's lazy FPSIMD handling. We also have the disabling > of the compat interface on arm64 (it never had it the first place), > and a relaxation on the

Re: [PULL 00/28] KVM/ARM Changes for v4.16

2018-01-31 Thread Radim Krčmář
2018-01-31 10:34+0100, Christoffer Dall: > Hi Paolo and Radim, > > Apologies for getting this pull request to you rather late; there were a > number of issues that I wanted to make sure we could fix properly before > including some of the changes in this pull request. > > The changes for this

Re: [PATCH 1/2] KVM: Enforce error in ioctl for compat tasks when !KVM_COMPAT

2018-06-21 Thread Radim Krčmář
2018-06-21 12:40+0100, Marc Zyngier: > Radim, Paolo: are you happy with me taking this through the kvmarm tree? Yes, please do. Acked-by: Radim Krčmář ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listi

Re: [PATCH 0/5] KVM/arm fixes for 4.17-rc2

2018-04-25 Thread Radim Krčmář
2018-04-20 17:07+0100, Marc Zyngier: > Radim, Paolo, > > Here is the first batch of KVM/arm fixes post 4.17 merge window. Not a > lot to report, apart from the slightly scary VMID allocation race that > has been sitting there from day 1. > > Please pull. Pulled, thanks.

Re: [GIT PULL] KVM/ARM updates for v4.17

2018-03-28 Thread Radim Krčmář
2018-03-28 13:51+0100, Marc Zyngier: > Paolo, Radim, > > This is the (rather big) set of updates for KVM/ARM for v4.17. The > main features are the set of VHE optimizations taking advantage of > CPUs implementing ARMv8.1, together with the EL2 randomization patches > that are the foundation for