Re: [PATCH 01/14] KVM: selftests: Define literal to asm constraint in aarch64 as unsigned long

2022-12-13 Thread Philippe Mathieu-Daudé
tools/testing/selftests/kvm/aarch64/page_fault_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH 07/14] KVM: selftests: Use proper function prototypes in probing code

2022-12-13 Thread Philippe Mathieu-Daudé
-by: Sean Christopherson --- tools/testing/selftests/kvm/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu

Re: [PATCH 05/14] KVM: selftests: Fix a typo in x86-64's kvm_get_cpu_address_width()

2022-12-13 Thread Philippe Mathieu-Daudé
*pa_bits = kvm_cpu_has(X86_FEATURE_PAE) ? 36 : 32; :) Reviewed-by: Philippe Mathieu-Daudé ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH 03/14] KVM: selftests: Fix divide-by-zero bug in memslot_perf_test

2022-12-13 Thread Philippe Mathieu-Daudé
-- tools/testing/selftests/kvm/memslot_perf_test.c | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Philippe Mathieu-Daudé ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v2 21/50] KVM: MIPS: Hardcode callbacks to hardware virtualization extensions

2022-12-01 Thread Philippe Mathieu-Daudé
t kvm_mips_callbacks { void (*vcpu_reenter)(struct kvm_vcpu *vcpu); }; extern struct kvm_mips_callbacks *kvm_mips_callbacks; IIUC we could even constify this pointer. Anyway, Reviewed-by: Philippe Mathieu-Daudé diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c index af2949

Re: [PATCH 17/44] KVM: arm64: Do arm/arch initialiation without bouncing through kvm_init()

2022-11-03 Thread Philippe Mathieu-Daudé
Hi Sean, On 3/11/22 00:18, Sean Christopherson wrote: Move arm/arch specific initialization directly in arm's module_init(), now called kvm_arm_init(), instead of bouncing through kvm_init() to reach kvm_arch_init(). Invoking kvm_arch_init() is the very first action performed by kvm_init(),

Re: [PATCH 27/44] KVM: Drop kvm_arch_{init,exit}() hooks

2022-11-03 Thread Philippe Mathieu-Daudé
| 3 --- virt/kvm/kvm_main.c | 19 ++- 9 files changed, 2 insertions(+), 76 deletions(-) Reviewed-by: Philippe Mathieu-Daudé ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu

Re: [PATCH 30/44] KVM: Drop kvm_arch_check_processor_compat() hook

2022-11-03 Thread Philippe Mathieu-Daudé
++-- arch/x86/kvm/x86.c | 5 - include/linux/kvm_host.h | 4 +--- virt/kvm/kvm_main.c| 24 +--- 13 files changed, 13 insertions(+), 67 deletions(-) Reviewed-by: Philippe Mathieu-Daudé ___ kvmarm mailing list

Re: [PATCH 22/44] KVM: RISC-V: Do arch init directly in riscv_kvm_init()

2022-11-03 Thread Philippe Mathieu-Daudé
son --- arch/riscv/kvm/main.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Philippe Mathieu-Daudé ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH 25/44] KVM: s390: Do s390 specific init without bouncing through kvm_init()

2022-11-03 Thread Philippe Mathieu-Daudé
/s390/kvm/kvm-s390.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH 21/44] KVM: MIPS: Register die notifier prior to kvm_init()

2022-11-03 Thread Philippe Mathieu-Daudé
changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH 20/44] KVM: MIPS: Setup VZ emulation? directly from kvm_mips_init()

2022-11-03 Thread Philippe Mathieu-Daudé
ing kvm_arch_init() will allow dropping the hook entirely once all architecture implementations are nops. No functional change intended. Signed-off-by: Sean Christopherson --- arch/mips/kvm/mips.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Da

Re: [PATCH v4 11/12] KVM: mips, x86: do not rely on KVM_REQ_UNHALT

2022-09-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini > Signed-off-by: Sean Christopherson > --- > arch/mips/kvm/emulate.c | 7 +++ > arch/x86/kvm/x86.c | 9 - > 2 files changed, 11 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé ___

Re: [PATCH 2/5] KVM: mips: Use kvm_get_vcpu() instead of open-coded access

2021-11-07 Thread Philippe Mathieu-Daudé
s/kvm/mips.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v2] kvm_host: unify VM_STAT and VCPU_STAT definitions in a single place

2020-04-15 Thread Philippe Mathieu-Daudé
\ > + { n, offsetof(struct kvm, stat.x), KVM_STAT_VM, ## __VA_ARGS__ } > +#define VCPU_STAT(n, x, ...) >\ Not sure while you use so many whitespaces here... (m

Re: [PATCH] kvm_host: unify VM_STAT and VCPU_STAT definitions in a single place

2020-04-14 Thread Philippe Mathieu-Daudé
Hi Emanuele, On 4/13/20 4:03 PM, Emanuele Giuseppe Esposito wrote: > The macros VM_STAT and VCPU_STAT are redundantly implemented in multiple > files, each used by a different architecure to initialize the debugfs > entries for statistics. Since they all have the same purpose, they can be >

Re: [PATCH v3 08/15] KVM: Move setting of memslot into helper routine

2019-12-05 Thread Philippe Mathieu-Daudé
Reviewed-by: Philippe Mathieu-Daudé ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v3 07/15] KVM: Refactor error handling for setting memory region

2019-12-05 Thread Philippe Mathieu-Daudé
w.flags & KVM_MEM_LOG_DIRTY_PAGES)) new.dirty_bitmap = NULL; else if (!new.dirty_bitmap) { - if (kvm_create_dirty_bitmap() < 0) - goto out; + r = kvm_create_dirty_bitmap(); + if (r) + return r; R

Re: [PATCH] target/arm: Fix ISR_EL1 tracking when executing at EL2

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/22/19 3:16 PM, Peter Maydell wrote: On Fri, 22 Nov 2019 at 13:59, Marc Zyngier wrote: The ARMv8 ARM states when executing at EL2, EL3 or Secure EL1, ISR_EL1 shows the pending status of the physical IRQ, FIQ, or SError interrupts. Unfortunately, QEMU's implementation only considers the