Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function

2020-04-16 Thread Tianjia Zhang
On 2020/4/15 22:53, Paolo Bonzini wrote: On 15/04/20 11:07, Vitaly Kuznetsov wrote: In case this is no longer needed I'd suggest we drop 'kvm_run' parameter and extract it from 'struct kvm_vcpu' when needed. This looks like a natural add-on to your cleanup patch. I agree, though I think it

Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function

2020-04-15 Thread Paolo Bonzini
On 15/04/20 11:07, Vitaly Kuznetsov wrote: > In case this is no longer needed I'd suggest we drop 'kvm_run' parameter > and extract it from 'struct kvm_vcpu' when needed. This looks like a > natural add-on to your cleanup patch. I agree, though I think it should be _instead_ of Tianjia's patch

Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function

2020-04-15 Thread Tianjia Zhang
On 2020/4/14 22:26, Vitaly Kuznetsov wrote: Tianjia Zhang writes: kvm_arch_vcpu_ioctl_run() is only called in the file kvm_main.c, where vcpu->run is the kvm_run parameter, so it has been replaced. Signed-off-by: Tianjia Zhang --- arch/x86/kvm/x86.c | 8 virt/kvm/arm/arm.c |

Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function

2020-04-14 Thread Vitaly Kuznetsov
Tianjia Zhang writes: > kvm_arch_vcpu_ioctl_run() is only called in the file kvm_main.c, > where vcpu->run is the kvm_run parameter, so it has been replaced. > > Signed-off-by: Tianjia Zhang > --- > arch/x86/kvm/x86.c | 8 > virt/kvm/arm/arm.c | 2 +- > 2 files changed, 5

Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function

2020-04-13 Thread Tianjia Zhang
On 2020/4/13 16:56, Marc Zyngier wrote: Tianjia, On 2020-04-13 04:45, Tianjia Zhang wrote: kvm_arch_vcpu_ioctl_run() is only called in the file kvm_main.c, where vcpu->run is the kvm_run parameter, so it has been replaced. Signed-off-by: Tianjia Zhang ---  arch/x86/kvm/x86.c | 8  

[PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function

2020-04-13 Thread Tianjia Zhang
kvm_arch_vcpu_ioctl_run() is only called in the file kvm_main.c, where vcpu->run is the kvm_run parameter, so it has been replaced. Signed-off-by: Tianjia Zhang --- arch/x86/kvm/x86.c | 8 virt/kvm/arm/arm.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function

2020-04-13 Thread Marc Zyngier
Tianjia, On 2020-04-13 04:45, Tianjia Zhang wrote: kvm_arch_vcpu_ioctl_run() is only called in the file kvm_main.c, where vcpu->run is the kvm_run parameter, so it has been replaced. Signed-off-by: Tianjia Zhang --- arch/x86/kvm/x86.c | 8 virt/kvm/arm/arm.c | 2 +- 2 files changed,