Re: [PATCH 05/10] KVM: arm/arm64: vgic: Relax vgic_can_sample_irq for edge IRQs

2015-07-03 Thread Peter Maydell
On 3 July 2015 at 10:50, Marc Zyngier wrote: > On 02/07/15 17:23, Christoffer Dall wrote: >> If we had a different *shared* device than the timer which is >> edge-triggered, don't we then also need to capture the physical >> distributor's pending state along with the state of the device unless we

Re: [PATCH 05/10] KVM: arm/arm64: vgic: Relax vgic_can_sample_irq for edge IRQs

2015-07-03 Thread Marc Zyngier
On 02/07/15 17:23, Christoffer Dall wrote: > On Wed, Jul 01, 2015 at 07:18:40PM +0100, Marc Zyngier wrote: >> On 01/07/15 12:58, Christoffer Dall wrote: >>> On Wed, Jul 01, 2015 at 10:17:52AM +0100, Marc Zyngier wrote: On 30/06/15 21:19, Christoffer Dall wrote: > On Mon, Jun 08, 2015 at 06

Re: [PATCH 05/10] KVM: arm/arm64: vgic: Relax vgic_can_sample_irq for edge IRQs

2015-07-02 Thread Christoffer Dall
On Wed, Jul 01, 2015 at 07:18:40PM +0100, Marc Zyngier wrote: > On 01/07/15 12:58, Christoffer Dall wrote: > > On Wed, Jul 01, 2015 at 10:17:52AM +0100, Marc Zyngier wrote: > >> On 30/06/15 21:19, Christoffer Dall wrote: > >>> On Mon, Jun 08, 2015 at 06:04:00PM +0100, Marc Zyngier wrote: > We

Re: [PATCH 05/10] KVM: arm/arm64: vgic: Relax vgic_can_sample_irq for edge IRQs

2015-07-01 Thread Marc Zyngier
On 01/07/15 12:58, Christoffer Dall wrote: > On Wed, Jul 01, 2015 at 10:17:52AM +0100, Marc Zyngier wrote: >> On 30/06/15 21:19, Christoffer Dall wrote: >>> On Mon, Jun 08, 2015 at 06:04:00PM +0100, Marc Zyngier wrote: We only set the irq_queued flag for level interrupts, meaning that "!v

Re: [PATCH 05/10] KVM: arm/arm64: vgic: Relax vgic_can_sample_irq for edge IRQs

2015-07-01 Thread Christoffer Dall
On Wed, Jul 01, 2015 at 10:17:52AM +0100, Marc Zyngier wrote: > On 30/06/15 21:19, Christoffer Dall wrote: > > On Mon, Jun 08, 2015 at 06:04:00PM +0100, Marc Zyngier wrote: > >> We only set the irq_queued flag for level interrupts, meaning > >> that "!vgic_irq_is_queued(vcpu, irq)" is a good enough

Re: [PATCH 05/10] KVM: arm/arm64: vgic: Relax vgic_can_sample_irq for edge IRQs

2015-07-01 Thread Marc Zyngier
On 30/06/15 21:19, Christoffer Dall wrote: > On Mon, Jun 08, 2015 at 06:04:00PM +0100, Marc Zyngier wrote: >> We only set the irq_queued flag for level interrupts, meaning >> that "!vgic_irq_is_queued(vcpu, irq)" is a good enough predicate >> for all interrupts. >> >> This will allow us to inject e

Re: [PATCH 05/10] KVM: arm/arm64: vgic: Relax vgic_can_sample_irq for edge IRQs

2015-06-30 Thread Christoffer Dall
On Mon, Jun 08, 2015 at 06:04:00PM +0100, Marc Zyngier wrote: > We only set the irq_queued flag for level interrupts, meaning > that "!vgic_irq_is_queued(vcpu, irq)" is a good enough predicate > for all interrupts. > > This will allow us to inject edge HW interrupts, for which the > state ACTIVE+P

[PATCH 05/10] KVM: arm/arm64: vgic: Relax vgic_can_sample_irq for edge IRQs

2015-06-08 Thread Marc Zyngier
We only set the irq_queued flag for level interrupts, meaning that "!vgic_irq_is_queued(vcpu, irq)" is a good enough predicate for all interrupts. This will allow us to inject edge HW interrupts, for which the state ACTIVE+PENDING is not allowed. Signed-off-by: Marc Zyngier --- virt/kvm/arm/vgi