Re: [PATCH 1/4] KVM: arm/arm64: vgic: Do not cond_resched_lock() with IRQs disabled

2018-11-21 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v4.19.2, v4.18.19, v4.14.81, v4.9.137, v4.4.163, v3.18.125. v4.19.2: Build OK!

Re: [PATCH 1/4] KVM: arm/arm64: vgic: Do not cond_resched_lock() with IRQs disabled

2018-11-20 Thread Julien Thierry
On 20/11/18 14:18, Christoffer Dall wrote: On Mon, Nov 19, 2018 at 05:07:56PM +, Julien Thierry wrote: To change the active state of an MMIO, halt is requested for all vcpus of the affected guest before modifying the IRQ state. This is done by calling cond_resched_lock() in

Re: [PATCH 1/4] KVM: arm/arm64: vgic: Do not cond_resched_lock() with IRQs disabled

2018-11-20 Thread Marc Zyngier
On 20/11/2018 14:18, Christoffer Dall wrote: > On Mon, Nov 19, 2018 at 05:07:56PM +, Julien Thierry wrote: >> To change the active state of an MMIO, halt is requested for all vcpus of >> the affected guest before modifying the IRQ state. This is done by calling >> cond_resched_lock() in

Re: [PATCH 1/4] KVM: arm/arm64: vgic: Do not cond_resched_lock() with IRQs disabled

2018-11-20 Thread Christoffer Dall
On Mon, Nov 19, 2018 at 05:07:56PM +, Julien Thierry wrote: > To change the active state of an MMIO, halt is requested for all vcpus of > the affected guest before modifying the IRQ state. This is done by calling > cond_resched_lock() in vgic_mmio_change_active(). However interrupts are >

[PATCH 1/4] KVM: arm/arm64: vgic: Do not cond_resched_lock() with IRQs disabled

2018-11-19 Thread Julien Thierry
To change the active state of an MMIO, halt is requested for all vcpus of the affected guest before modifying the IRQ state. This is done by calling cond_resched_lock() in vgic_mmio_change_active(). However interrupts are disabled at this point and running a vcpu cannot get rescheduled. Solve