Re: [PATCH V14 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1

2017-04-13 Thread Baicar, Tyler
On 4/13/2017 2:47 PM, Borislav Petkov wrote: On Thu, Apr 13, 2017 at 02:30:21PM -0600, Baicar, Tyler wrote: I do not agree with this. The struct being passed to this function is already named acpi_hest_generic_data in the existing code and all over this code is named gdata not just d. And I'm

Re: [PATCH V14 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1

2017-04-13 Thread Borislav Petkov
On Thu, Apr 13, 2017 at 02:30:21PM -0600, Baicar, Tyler wrote: > I do not agree with this. The struct being passed to this function is > already named acpi_hest_generic_data in the existing code and all over this > code is named gdata not just d. And I'm saying they're too long - the preexisting

Re: [PATCH V14 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1

2017-04-13 Thread Baicar, Tyler
On 4/12/2017 7:34 AM, Borislav Petkov wrote: Subject: [PATCH V14 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1 Use a verb in your patch subjects: "Add support for ..." or so. Hello Boris, Will do in the next version. On Tue, Mar 28, 2017 at 01:30:32PM -0

Re: [PATCH V14 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1

2017-04-12 Thread Joe Perches
On Wed, 2017-04-12 at 15:34 +0200, Borislav Petkov wrote: > On Tue, Mar 28, 2017 at 01:30:32PM -0600, Tyler Baicar wrote: > > Currently when a RAS error is reported it is not timestamped. [] > > diff --git a/include/acpi/ghes.h b/include/acpi/ghes.h [] > > +#define