Re: [PATCH v4 10/40] KVM: arm64: Slightly improve debug save/restore functions

2018-02-24 Thread Marc Zyngier
On Sat, 24 Feb 2018 18:32:36 +, Christoffer Dall wrote: > > On Wed, Feb 21, 2018 at 05:52:41PM +, Marc Zyngier wrote: > > On 21/02/18 17:39, Andrew Jones wrote: > > > On Thu, Feb 15, 2018 at 10:03:02PM +0100, Christoffer Dall wrote: > > >> The debug save/restore functions can be improved b

Re: [PATCH v4 10/40] KVM: arm64: Slightly improve debug save/restore functions

2018-02-24 Thread Christoffer Dall
On Wed, Feb 21, 2018 at 05:52:41PM +, Marc Zyngier wrote: > On 21/02/18 17:39, Andrew Jones wrote: > > On Thu, Feb 15, 2018 at 10:03:02PM +0100, Christoffer Dall wrote: > >> The debug save/restore functions can be improved by using the has_vhe() > >> static key instead of the instruction altern

Re: [PATCH v4 10/40] KVM: arm64: Slightly improve debug save/restore functions

2018-02-22 Thread Andrew Jones
On Wed, Feb 21, 2018 at 05:52:41PM +, Marc Zyngier wrote: > On 21/02/18 17:39, Andrew Jones wrote: > > On Thu, Feb 15, 2018 at 10:03:02PM +0100, Christoffer Dall wrote: > >> The debug save/restore functions can be improved by using the has_vhe() > >> static key instead of the instruction altern

Re: [PATCH v4 10/40] KVM: arm64: Slightly improve debug save/restore functions

2018-02-21 Thread Marc Zyngier
On 21/02/18 17:39, Andrew Jones wrote: > On Thu, Feb 15, 2018 at 10:03:02PM +0100, Christoffer Dall wrote: >> The debug save/restore functions can be improved by using the has_vhe() >> static key instead of the instruction alternative. Using the static key >> uses the same paradigm as we're going

Re: [PATCH v4 10/40] KVM: arm64: Slightly improve debug save/restore functions

2018-02-21 Thread Andrew Jones
On Thu, Feb 15, 2018 at 10:03:02PM +0100, Christoffer Dall wrote: > The debug save/restore functions can be improved by using the has_vhe() > static key instead of the instruction alternative. Using the static key > uses the same paradigm as we're going to use elsewhere, it makes the > code more r

[PATCH v4 10/40] KVM: arm64: Slightly improve debug save/restore functions

2018-02-15 Thread Christoffer Dall
The debug save/restore functions can be improved by using the has_vhe() static key instead of the instruction alternative. Using the static key uses the same paradigm as we're going to use elsewhere, it makes the code more readable, and it generates slightly better code (no stack setups and functi