Re: [RFC PATCH 03/33] irqchip/gic-v3-its: Refactor command encoding

2017-02-16 Thread Auger Eric
On 17/01/2017 11:20, Marc Zyngier wrote: > The way we encode the various ITS command fields is both tedious > and error prone. Let's introduce a helper function that performs > the encoding, and convert the existing encoders to use that > helper. > > Signed-off-by: Marc Zyngier

Re: [RFC PATCH 03/33] irqchip/gic-v3-its: Refactor command encoding

2017-02-13 Thread Thomas Gleixner
On Tue, 17 Jan 2017, Marc Zyngier wrote: > +static void its_mask_encode(u64 *raw_cmd, u64 val, int h, int l) I'd rather name h/l in a way which makes it clear that they are describing a bit range. msb/lsb perhaps. > +{ > + u64 mask = GENMASK_ULL(h, l); New line missing here. > +

[RFC PATCH 03/33] irqchip/gic-v3-its: Refactor command encoding

2017-01-17 Thread Marc Zyngier
The way we encode the various ITS command fields is both tedious and error prone. Let's introduce a helper function that performs the encoding, and convert the existing encoders to use that helper. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its.c | 34