Re: [PATCH] KVM: arm/arm64: VGIC MMIO: add missing irq_lock

2018-03-15 Thread Andre Przywara
Hi, (sorry for the delay, forgot this in my draft folder) On 13/03/18 01:00, Christoffer Dall wrote: > On Tue, Mar 06, 2018 at 09:21:06AM +, Andre Przywara wrote: >> Our irq_is_pending() helper function accesses multiple members of the >> vgic_irq struct, so we need to hold the lock when call

Re: [PATCH] KVM: arm/arm64: VGIC MMIO: add missing irq_lock

2018-03-12 Thread Christoffer Dall
On Tue, Mar 06, 2018 at 09:21:06AM +, Andre Przywara wrote: > Our irq_is_pending() helper function accesses multiple members of the > vgic_irq struct, so we need to hold the lock when calling it. For the record I don't think this is necessarily a completely valid conclusion. The fact that you

Re: [PATCH] KVM: arm/arm64: VGIC MMIO: add missing irq_lock

2018-03-07 Thread Marc Zyngier
On 06/03/18 09:21, Andre Przywara wrote: > Our irq_is_pending() helper function accesses multiple members of the > vgic_irq struct, so we need to hold the lock when calling it. > Add that requirement as a comment to the definition and take the lock > around the call in vgic_mmio_read_pending(), whe

Re: [PATCH] KVM: arm/arm64: VGIC MMIO: add missing irq_lock

2018-03-06 Thread Andre Przywara
Hi, On 06/03/18 09:21, Andre Przywara wrote: > Our irq_is_pending() helper function accesses multiple members of the > vgic_irq struct, so we need to hold the lock when calling it. > Add that requirement as a comment to the definition and take the lock > around the call in vgic_mmio_read_pending()

[PATCH] KVM: arm/arm64: VGIC MMIO: add missing irq_lock

2018-03-06 Thread Andre Przywara
Our irq_is_pending() helper function accesses multiple members of the vgic_irq struct, so we need to hold the lock when calling it. Add that requirement as a comment to the definition and take the lock around the call in vgic_mmio_read_pending(), where we were missing it before. Signed-off-by: And