Re: [PATCH 3/4] kvm: Replace vcpu->swait with rcuwait

2020-04-15 Thread Paolo Bonzini
On 14/04/20 23:12, Davidlohr Bueso wrote: > On Wed, 25 Mar 2020, Paolo Bonzini wrote: > >> On 24/03/20 05:44, Davidlohr Bueso wrote: >>> diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c >>> index 71244bf87c3a..e049fcb3dffb 100644 >>> --- a/arch/mips/kvm/mips.c >>> +++

Re: [PATCH 3/4] kvm: Replace vcpu->swait with rcuwait

2020-04-15 Thread Davidlohr Bueso
On Wed, 25 Mar 2020, Paolo Bonzini wrote: On 24/03/20 05:44, Davidlohr Bueso wrote: diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c index 71244bf87c3a..e049fcb3dffb 100644 --- a/arch/mips/kvm/mips.c +++ b/arch/mips/kvm/mips.c @@ -290,8 +290,7 @@ static enum hrtimer_restart

Re: [PATCH 3/4] kvm: Replace vcpu->swait with rcuwait

2020-03-25 Thread Paolo Bonzini
On 24/03/20 05:44, Davidlohr Bueso wrote: > diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c > index 71244bf87c3a..e049fcb3dffb 100644 > --- a/arch/mips/kvm/mips.c > +++ b/arch/mips/kvm/mips.c > @@ -290,8 +290,7 @@ static enum hrtimer_restart > kvm_mips_comparecount_wakeup(struct hrtimer

Re: [PATCH 3/4] kvm: Replace vcpu->swait with rcuwait

2020-03-24 Thread Davidlohr Bueso
On Wed, 25 Mar 2020, kbuild test robot wrote: arch/x86/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_vcpu_block': arch/x86/kvm/../../../virt/kvm/kvm_main.c:2698:16: error: macro "rcuwait_wait_event" passed 3 arguments, but takes just 2 TASK_IDLE); This is because this

Re: [PATCH 3/4] kvm: Replace vcpu->swait with rcuwait

2020-03-24 Thread kbuild test robot
Hi Davidlohr, I love your patch! Yet something to improve: [auto build test ERROR on next-20200323] [also build test ERROR on v5.6-rc7] [cannot apply to kvm/linux-next kvmarm/next linus/master kvm-ppc/kvm-ppc-next v5.6-rc7 v5.6-rc6 v5.6-rc5] [if your patch is applied to the wrong git tree,

Re: [PATCH 3/4] kvm: Replace vcpu->swait with rcuwait

2020-03-24 Thread kbuild test robot
Hi Davidlohr, I love your patch! Yet something to improve: [auto build test ERROR on next-20200323] [also build test ERROR on v5.6-rc7] [cannot apply to kvm/linux-next kvmarm/next linus/master kvm-ppc/kvm-ppc-next v5.6-rc7 v5.6-rc6 v5.6-rc5] [if your patch is applied to the wrong git tree,

[PATCH 3/4] kvm: Replace vcpu->swait with rcuwait

2020-03-24 Thread Davidlohr Bueso
The use of any sort of waitqueue (simple or regular) for wait/waking vcpus has always been an overkill and semantically wrong. Because this is per-vcpu (which is blocked) there is only ever a single waiting vcpu, thus no need for any sort of queue. As such, make use of the rcuwait primitive, with