Re: can we define a KVM_REG_ARM encoding bit for NonSecure/Secure ?

2018-03-06 Thread Marc Zyngier
On 06/03/18 14:09, Peter Maydell wrote: > On 6 March 2018 at 13:59, Marc Zyngier wrote: >> On 05/03/18 14:01, Peter Maydell wrote: >>> #define KVM_REG_ARM_SECURE_MASK 0x1000 >>> >>> in arch/arm/include/uapi/asm/kvm.h >>> >>> Does this seem like a good idea? (We could alternatively stea

Re: can we define a KVM_REG_ARM encoding bit for NonSecure/Secure ?

2018-03-06 Thread Peter Maydell
On 6 March 2018 at 13:59, Marc Zyngier wrote: > On 05/03/18 14:01, Peter Maydell wrote: >> #define KVM_REG_ARM_SECURE_MASK 0x1000 >> >> in arch/arm/include/uapi/asm/kvm.h >> >> Does this seem like a good idea? (We could alternatively steal a bit >> from the top of the rather-over-speci

Re: can we define a KVM_REG_ARM encoding bit for NonSecure/Secure ?

2018-03-06 Thread Marc Zyngier
On 05/03/18 14:01, Peter Maydell wrote: > Hi; I've just noticed a bug in QEMU where we weren't migrating > Secure-bank register state for AArch32 emulated guest correctly, which > turns out to be intertwined with how KVM defines its index values for > cp15 registers in the KVM_REG_ARM_* encoding. >