Re: [Launchpad-reviewers] [Merge] lp:~lifeless/launchpad/bugmessage into lp:launchpad

2010-09-16 Thread Stuart Bishop
Review: Approve db This version adds a unique constraint rather than a unique index, which I prefer as it puts a little more metadata into PG. SET client_min_messages=ERROR; ALTER TABLE BugMessage ADD COLUMN index integer; ALTER TABLE BugMessage ADD CONSTRAINT bugmessage__bug__index__key UNIQUE

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/db-add-derivedistroseries-api into lp:launchpad

2010-09-16 Thread Steve Kowalik
The proposal to merge lp:~stevenk/launchpad/db-add-derivedistroseries-api into lp:launchpad has been updated. Description changed to: This branch adds a new method to IDistroSeries: deriveDistroSeries(). This method is intended to be called via API scripts for both the distro use-case as well

Re: [Launchpad-reviewers] [Merge] lp:~allenap/launchpad/bugsubscription-to-storm into lp:launchpad/devel

2010-09-16 Thread Gavin Panella
@Rob BugSubscription doesn't use any cached properties, so I don't follow. We can switch the base class at a later date, en masse, when one is available. Would that work? I suspect I'm missing something. -- https://code.launchpad.net/~allenap/launchpad/bugsubscription-to-storm/+merge/35537 Your

[Launchpad-reviewers] [Merge] lp:~jelmer/launchpad/506256-remove-popen-2 into lp:launchpad/devel

2010-09-16 Thread Jelmer Vernooij
The proposal to merge lp:~jelmer/launchpad/506256-remove-popen-2 into lp:launchpad/devel has been updated. Status: Work in progress = Needs review -- https://code.launchpad.net/~jelmer/launchpad/506256-remove-popen-2/+merge/35412 Your team Launchpad code reviewers is requested to review the

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/db-add-derivedistroseries-api into lp:launchpad

2010-09-16 Thread Steve Kowalik
The proposal to merge lp:~stevenk/launchpad/db-add-derivedistroseries-api into lp:launchpad has been updated. Description changed to: This branch adds a new method to IDistroSeries: deriveDistroSeries(). This method is intended to be called via API scripts for both the distro use-case as well

Re: [Launchpad-reviewers] [Merge] lp:~jelmer/launchpad/506256-remove-popen-2 into lp:launchpad/devel

2010-09-16 Thread Jelmer Vernooij
=== modified file 'database/schema/security.cfg' --- database/schema/security.cfg2010-09-16 00:33:37 + +++ database/schema/security.cfg2010-09-16 09:04:13 + @@ -1130,9 +1130,12 @@ public.packagebuild = SELECT, INSERT, UPDATE public.binarypackagebuild

[Launchpad-reviewers] [Merge] lp:~jelmer/launchpad/506256-remove-popen-2 into lp:launchpad/devel

2010-09-16 Thread Jelmer Vernooij
The proposal to merge lp:~jelmer/launchpad/506256-remove-popen-2 into lp:launchpad/devel has been updated. Description changed to: This MP actually has two prerequisites which both have been approved but not yet landed: lp:~jelmer/launchpad/506256-remove-popen and

[Launchpad-reviewers] [Merge] lp:~michael.nelson/launchpad/635005-difference-details-2 into lp:launchpad

2010-09-16 Thread Michael Nelson
Michael Nelson has proposed merging lp:~michael.nelson/launchpad/635005-difference-details-2 into lp:launchpad. Requested reviews: Launchpad UI Reviewers (launchpad-ui-reviewers): ui Launchpad code reviewers (launchpad-reviewers) Related bugs: #635005 DistroSeriesDifference detailed

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/db-add-derivedistroseries-api into lp:launchpad

2010-09-16 Thread Steve Kowalik
The proposal to merge lp:~stevenk/launchpad/db-add-derivedistroseries-api into lp:launchpad has been updated. Status: Work in progress = Needs review -- https://code.launchpad.net/~stevenk/launchpad/db-add-derivedistroseries-api/+merge/35500 Your team Launchpad code reviewers is requested

Re: [Launchpad-reviewers] [Merge] lp:~allenap/launchpad/bugsubscription-to-storm into lp:launchpad/devel

2010-09-16 Thread Robert Collins
On Thu, Sep 16, 2010 at 8:36 PM, Gavin Panella gavin.pane...@canonical.com wrote: @Rob BugSubscription doesn't use any cached properties, so I don't follow. We can switch the base class at a later date, en masse, when one is available. Would that work? I suspect I'm missing something. That

[Launchpad-reviewers] [Merge] lp:~lifeless/launchpad/bugmessage into lp:launchpad

2010-09-16 Thread noreply
The proposal to merge lp:~lifeless/launchpad/bugmessage into lp:launchpad has been updated. Status: Approved = Merged -- https://code.launchpad.net/~lifeless/launchpad/bugmessage/+merge/35620 Your team Launchpad code reviewers is requested to review the proposed merge of

[Launchpad-reviewers] [Merge] lp:~julian-edwards/launchpad/copy-archive-dispatch-bug-575165 into lp:launchpad/devel

2010-09-16 Thread Julian Edwards
Julian Edwards has proposed merging lp:~julian-edwards/launchpad/copy-archive-dispatch-bug-575165 into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: #575165 Buildd-manager erroneously checks COPY archives for release pocket upload

[Launchpad-reviewers] [Merge] lp:~leonardr/launchpad/accept-oauth-signatures into lp:launchpad

2010-09-16 Thread Leonard Richardson
Leonard Richardson has proposed merging lp:~leonardr/launchpad/accept-oauth-signatures into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Backstory: the only way to get (non-anonymous or read-write) access to the Launchpad web service is to associate an

[Launchpad-reviewers] [Merge] lp:~jelmer/launchpad/635591-sync-source-unicode into lp:launchpad/devel

2010-09-16 Thread Jelmer Vernooij
Jelmer Vernooij has proposed merging lp:~jelmer/launchpad/635591-sync-source-unicode into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers): code Related bugs: #635591 Regression: syncing packages with UTF-8 changelogs fails

Re: [Launchpad-reviewers] [Merge] lp:~jelmer/launchpad/635591-sync-source-unicode into lp:launchpad/devel

2010-09-16 Thread Jelmer Vernooij
FWIW, I'm also filing a bug against python-debian about this issue. -- https://code.launchpad.net/~jelmer/launchpad/635591-sync-source-unicode/+merge/35715 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/launchpad/635591-sync-source-unicode into

Re: [Launchpad-reviewers] [Merge] lp:~jelmer/launchpad/635591-sync-source-unicode into lp:launchpad/devel

2010-09-16 Thread Robert Collins
Review: Approve Something is funny with the bug/branch info here; the older MP isn't linked, the bug isn't qa-bad or qa-needstesting marked. Could you please put a bug together for why the older MP wasn't linked from the branch anymore? --

[Launchpad-reviewers] [Merge] lp:~jelmer/launchpad/635591-sync-source-unicode into lp:launchpad/devel

2010-09-16 Thread Robert Collins
The proposal to merge lp:~jelmer/launchpad/635591-sync-source-unicode into lp:launchpad/devel has been updated. Status: Needs review = Approved -- https://code.launchpad.net/~jelmer/launchpad/635591-sync-source-unicode/+merge/35715 Your team Launchpad code reviewers is requested to review

Re: [Launchpad-reviewers] [Merge] lp:~jelmer/launchpad/635591-sync-source-unicode into lp:launchpad/devel

2010-09-16 Thread Jelmer Vernooij
On Thu, 2010-09-16 at 19:08 +, Robert Collins wrote: Something is funny with the bug/branch info here; the older MP isn't linked, the bug isn't qa-bad or qa-needstesting marked. Could you please put a bug together for why the older MP wasn't linked from the branch anymore? I think the

[Launchpad-reviewers] [Merge] lp:~jtv/launchpad/bug-594220 into lp:launchpad/devel

2010-09-16 Thread Jeroen T. Vermeulen
Jeroen T. Vermeulen has proposed merging lp:~jtv/launchpad/bug-594220 into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers): code Related bugs: #594220 Template imports built from branches are owned by VCS imports. https://bugs.launchpad.net/bugs/594220

Re: [Launchpad-reviewers] [Merge] lp:~lifeless/launchpad/cp into lp:~launchpad-pqm/launchpad/production-devel

2010-09-16 Thread Robert Collins
I'm going to request appservers only as we have SPOF's elsewhere. -- https://code.launchpad.net/~lifeless/launchpad/cp/+merge/35764 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lifeless/launchpad/cp into lp:~launchpad-pqm/launchpad/production-devel.

Re: [Launchpad-reviewers] [Merge] lp:~lifeless/launchpad/cp into lp:~launchpad-pqm/launchpad/production-devel

2010-09-16 Thread Tim Penhey
Review: Approve release-critical On Fri, 17 Sep 2010 15:48:47 you wrote: I'm going to request appservers only as we have SPOF's elsewhere. review approve release-critical merge approved -- https://code.launchpad.net/~lifeless/launchpad/cp/+merge/35764 Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] lp:~lifeless/launchpad/registry into lp:launchpad/devel

2010-09-16 Thread Robert Collins
Robert Collins has proposed merging lp:~lifeless/launchpad/registry into lp:launchpad/devel. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: #615237 /participants API timing out https://bugs.launchpad.net/bugs/615237 #627412 Person:+mailinglist-moderate