I approved on 2010-10-19. Have there been changes since? If not, I'm happy to
land this for you.
--
https://code.launchpad.net/~mbp/launchpad/dkim/+merge/35985
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~mbp/launchpad/dkim into lp:launchpad.
Review: Approve
post landing review - some thoughts: getSubscriptionForPerson seems to overlap
other getSubscription methods quite a bit. One particular thing is that this
seems buggy: I can subscribe my *team* but the edit facility will only let me
edit my *personal* subscription: its a
Robert Collins has proposed merging
lp:~lifeless/launchpad/getBuildSummariesForSourceIds into lp:launchpad/devel.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Group up calls in Archive:EntryResource:getBuildSummariesForSourceIds rather
than suffering death by a thousand
Ian Booth has proposed merging lp:~wallyworld/launchpad/fix-enable-review-type
into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
#671665 review type field for merge proposal not always enabled
https://bugs.launchpad.net/bugs/671665
=
The proposal to merge lp:~wallyworld/launchpad/fix-enable-review-type into
lp:launchpad has been updated.
Description changed to:
= Summary =
As per bug 671665, when the popup selection widget is used to choose the
reviewer for a mp, the review type field does not become enabled.
=
The proposal to merge lp:~wallyworld/launchpad/fix-enable-review-type into
lp:launchpad has been updated.
Description changed to:
= Summary =
As per bug 671665, when the popup selection widget is used to choose the
reviewer for a mp, the review type field does not become enabled.
=
6 matches
Mail list logo
