Re: [Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/bug-informationtype-refactor into lp:launchpad

2012-07-29 Thread Ian Booth
Review: Approve Thanks for answering my questions. -- https://code.launchpad.net/~wgrant/launchpad/bug-informationtype-refactor/+merge/117002 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/bug-informationtype-refactor into lp:launchpad

2012-07-29 Thread Ian Booth
The proposal to merge lp:~wgrant/launchpad/bug-informationtype-refactor into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~wgrant/launchpad/bug-informationtype-refactor/+merge/117002 --

Re: [Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/private-dupe-bug-warning3 into lp:launchpad

2012-07-29 Thread Ian Booth
1. Yes, that expansion behaviour is why Lp likes left aligned buttons. I have made the buttons for the second confirmation form left aligned. This also means that the buttons on the person picker validation forms are also left aligned eg the form asking if you really want to assign someone to

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/bug-informationtype-refactor into lp:launchpad

2012-07-29 Thread noreply
The proposal to merge lp:~wgrant/launchpad/bug-informationtype-refactor into lp:launchpad has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~wgrant/launchpad/bug-informationtype-refactor/+merge/117002 --

[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/bugsummary-v2-rebuild-ap into lp:launchpad

2012-07-29 Thread William Grant
William Grant has proposed merging lp:~wgrant/launchpad/bugsummary-v2-rebuild-ap into lp:launchpad with lp:launchpad/db-devel as a prerequisite. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1017748 in Launchpad itself: BugSummary assumes that