Review: Approve code
Thanks for this cleanup. I wonder if you could go even further by porting some
bug_supervisor setters to use makeProduct(bug_supervisor=) instead, as a few
seem to be ignorant of its existence.
610 Let's make Foo Bar a bug supervisor for upstream firefox:
611
612
Ian Booth has proposed merging
lp:~wallyworld/launchpad/embargoed-information-type-1036187 into lp:launchpad
with lp:~wallyworld/launchpad/edit-sharing-policies2-1036437 as a prerequisite.
Requested reviews:
Curtis Hovey (sinzui)
Related bugs:
Bug #1036187 in Launchpad itself: "Add the Embar
The proposal to merge lp:~stevenk/launchpad/no-more-add-bug-supervisor into
lp:launchpad has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/no-more-add-bug-supervisor/+merge/119818
--
https://code.launchpad.net/~stevenk/launchpa
Steve Kowalik has proposed merging
lp:~stevenk/launchpad/no-structsub-for-bug-supervisor into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/no-structsub-for-bug-supervisor/+merge/119831
No l
The proposal to merge lp:~wallyworld/launchpad/bugtask-title-truncation-1037364
into lp:launchpad has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/bugtask-title-truncation-1037364/+merge/119828
--
https://code.launchpad
Review: Approve
Self approve
--
https://code.launchpad.net/~wallyworld/launchpad/bugtask-title-truncation-1037364/+merge/119828
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-
Ian Booth has proposed merging
lp:~wallyworld/launchpad/bugtask-title-truncation-1037364 into lp:launchpad.
Requested reviews:
Ian Booth (wallyworld)
Related bugs:
Bug #1037364 in Launchpad itself: "Long bug titles are now truncated,
obscuring important information"
https://bugs.launchpad.
The proposal to merge lp:~stevenk/launchpad/no-oops-request-daily-build into
lp:launchpad has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/no-oops-request-daily-build/+merge/119654
--
https://code.launchpad.net/~stevenk/launch
The proposal to merge lp:~stevenk/launchpad/double-unmute-oops into
lp:launchpad has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/double-unmute-oops/+merge/119663
--
https://code.launchpad.net/~stevenk/launchpad/double-unmute-
He did indeed. There's more to be done of course :)
--
https://code.launchpad.net/~allenap/maas/pxe-file-import-merciless-cobbler-evisceration/+merge/118195
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~allenap/maas/pxe-file-import-merciless-cobbler-eviscera
The proposal to merge lp:~stevenk/launchpad/no-more-add-bug-supervisor into
lp:launchpad has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/no-more-add-bug-supervisor/+merge/119818
--
https://code.launchpad.net/~stevenk/la
The proposal to merge lp:~stevenk/launchpad/no-more-add-bug-supervisor into
lp:launchpad has been updated.
Commit Message changed to:
No longer explicitly notify the bug supervisor and maintainer when a private
bug is re-targeted, since we have structural subscriptions working for private
bugs
Hooray, less bug email!
--
https://code.launchpad.net/~stevenk/launchpad/no-more-add-bug-supervisor/+merge/119818
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post
Review: Approve
Hooray, less code
--
https://code.launchpad.net/~stevenk/launchpad/no-more-add-bug-supervisor/+merge/119818
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-revi
Steve Kowalik has proposed merging
lp:~stevenk/launchpad/no-more-add-bug-supervisor into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #1029724 in Launchpad itself: "Retargeting a private bug notifies
maintainer and bug supervisor without s
The proposal to merge lp:~wallyworld/launchpad/edit-sharing-policies2-1036437
into lp:launchpad has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/edit-sharing-policies2-1036437/+merge/119501
--
https://code.launchpad.n
Review: Approve code
We agreed to use Williams UI and land your open branches. We will then update
the UI to be smaller and get users to give us feedback.
--
https://code.launchpad.net/~wallyworld/launchpad/edit-sharing-policies-1036437/+merge/119466
Your team Launchpad code reviewers is subscri
The proposal to merge lp:~wallyworld/launchpad/edit-sharing-policies-1036437
into lp:launchpad has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/edit-sharing-policies-1036437/+merge/119466
--
https://code.launchpad.net
Review: Needs Information code
Is it possible to move the *.duplicateof.default_bugtask.target logic into a
view so that the tal does not execute non-compiled python? Maybe we could use a
function that a properties on the two views use?
--
https://code.launchpad.net/~jcsackett/launchpad/inacces
The proposal to merge lp:~stevenk/launchpad/no-oops-request-daily-build into
lp:launchpad has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/no-oops-request-daily-build/+merge/119654
--
https://code.launchpad.net/~stevenk/
The proposal to merge lp:~stevenk/launchpad/no-oops-request-daily-build into
lp:launchpad has been updated.
Commit Message changed to:
Skip obsolete series in ISourcePackageRecipe.performDailyBuild(), and warn
users about them.
For more details, see:
https://code.launchpad.net/~stevenk/launchp
The proposal to merge lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/fix-bug-623281/+merge/119674
--
https://code.launchpad.net/~stevenk/launchpad/fix-bug-623281/+merge/
The proposal to merge lp:~stevenk/launchpad/double-unmute-oops into
lp:launchpad has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/double-unmute-oops/+merge/119663
--
https://code.launchpad.net/~stevenk/launchpad/double-u
The proposal to merge lp:~stevenk/launchpad/double-unmute-oops into
lp:launchpad has been updated.
Commit Message changed to:
Force IBug.unmute() to deal if the bug is already muted.
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/double-unmute-oops/+merge/119663
--
https:
The proposal to merge
lp:~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thinks-it-is into
lp:launchpad has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thinks-it-is/+merge/119798
-
Review: Approve code
Thank you.
--
https://code.launchpad.net/~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thinks-it-is/+merge/119798
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.n
The proposal to merge lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad
has been updated.
Commit Message changed to:
The comment before IBuilder.currentjob must of been true at some point, but it
isn't now, so remove it.
For more details, see:
https://code.launchpad.net/~stevenk/launchpad
j.c.sackett has proposed merging
lp:~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thinks-it-is into
lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thi
Review: Approve
--
https://code.launchpad.net/~jameinel/launchpad/loggerhead-clear-cache/+merge/119793
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Brad Crittenden has proposed merging lp:~bac/lpsetup/host2target into
lp:lpsetup.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~bac/lpsetup/host2target/+merge/119795
Change 'host' to 'target' everywhere to make it less con
John A Meinel has proposed merging
lp:~jameinel/launchpad/loggerhead-clear-cache into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jameinel/launchpad/loggerhead-clear-cache/+merge/119793
This is a small twea
j.c.sackett has proposed merging
lp:~jcsackett/launchpad/inaccessible-duplicates-link into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/inaccessible-duplicates-link/+merge/119781
Summary
The proposal to merge lp:~sinzui/launchpad/edit-team-description into
lp:launchpad has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~sinzui/launchpad/edit-team-description/+merge/119759
--
https://code.launchpad.net/~sinzui/launchpad/edit-
Review: Approve
This looks good, Curtis. Thanks.
--
https://code.launchpad.net/~sinzui/launchpad/edit-team-description/+merge/119759
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launc
The proposal to merge lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/fix-bug-623281/+merge/119674
--
https://code.launchpad.net/~stevenk/launchpad/fix-bug-623281/+
Review: Approve code
Thank you.
--
https://code.launchpad.net/~stevenk/launchpad/fix-bug-623281/+merge/119674
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to
Review: Approve code
Thank you.
--
https://code.launchpad.net/~stevenk/launchpad/double-unmute-oops/+merge/119663
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post
Review: Approve code
Thank you.
--
https://code.launchpad.net/~stevenk/launchpad/no-oops-request-daily-build/+merge/119654
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-revie
Curtis Hovey has proposed merging lp:~sinzui/launchpad/edit-team-description
into lp:launchpad.
Requested reviews:
j.c.sackett (jcsackett)
Related bugs:
Bug #5283 in Launchpad itself: ""Home page" vs. "Description" is misleading"
https://bugs.launchpad.net/launchpad/+bug/5283
For more deta
The proposal to merge lp:~stub/launchpad/db-deploy into lp:launchpad has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/119714
--
https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/119714
Your team Launchp
The proposal to merge lp:~stub/launchpad/db-deploy into lp:launchpad has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/119714
--
https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/119714
Your team L
Review: Approve
--
https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/119714
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewe
Stuart Bishop has proposed merging lp:~stub/launchpad/db-deploy into
lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #906222 in Launchpad itself: "More BAD_USERS creating false positives
during fast downtime updates"
https://bugs.launchpad.
Robie Basak has proposed merging lp:~racb/maas/automation into lp:maas.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~racb/maas/automation/+merge/119708
Fixes around HACKING.txt and automatically getting a MAAS development
The proposal to merge
lp:~allenap/maas/pxe-file-import-merciless-cobbler-evisceration into lp:maas
has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~allenap/maas/pxe-file-import-merciless-cobbler-evisceration/+merge/118195
--
https://code
I think jtv has done this now.
--
https://code.launchpad.net/~allenap/maas/pxe-file-import-merciless-cobbler-evisceration/+merge/118195
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~allenap/maas/pxe-file-import-merciless-cobbler-evisceration into lp:maas.
__
Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/doris-does-mtime into
lp:maas.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jtv/maas/doris-does-mtime/+merge/119683
Management of modification times for DNS zone files
The proposal to merge lp:~jtv/maas/doris-does-mtime into lp:maas has been
updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~jtv/maas/doris-does-mtime/+merge/119683
--
https://code.launchpad.net/~jtv/maas/doris-does-mtime/+merge/119683
Your
Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/doris-does-mtime into
lp:maas.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jtv/maas/doris-does-mtime/+merge/119683
Management of modification times for DNS zone files
49 matches
Mail list logo
