[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad

2012-08-15 Thread Steve Kowalik
Steve Kowalik has proposed merging lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #623281 in Launchpad itself: IBuilder.currentjob should not be a property

Re: [Launchpad-reviewers] [Merge] lp:~jtv/maas/decobblerate-maas-import-ephemerals into lp:maas

2012-08-15 Thread Jeroen T. Vermeulen
As it turns out, Gavin has had a branch for this in review for a weeks now that wasn't on the board, so I missed it when picking up a work item — lp:~allenap/maas/pxe-file-import-merciless-cobbler-evisceration Obviously there will be enormous overlap. As far as I can see, my branch is a

[Launchpad-reviewers] [Merge] lp:~jtv/maas/doris-does-mtime into lp:maas

2012-08-15 Thread Jeroen T. Vermeulen
Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/doris-does-mtime into lp:maas. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~jtv/maas/doris-does-mtime/+merge/119683 Management of modification times for DNS zone

[Launchpad-reviewers] [Merge] lp:~jtv/maas/doris-does-mtime into lp:maas

2012-08-15 Thread Jeroen T. Vermeulen
The proposal to merge lp:~jtv/maas/doris-does-mtime into lp:maas has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~jtv/maas/doris-does-mtime/+merge/119683 -- https://code.launchpad.net/~jtv/maas/doris-does-mtime/+merge/119683 Your

[Launchpad-reviewers] [Merge] lp:~jtv/maas/doris-does-mtime into lp:maas

2012-08-15 Thread Jeroen T. Vermeulen
Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/doris-does-mtime into lp:maas. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~jtv/maas/doris-does-mtime/+merge/119683 Management of modification times for DNS zone

Re: [Launchpad-reviewers] [Merge] lp:~allenap/maas/pxe-file-import-merciless-cobbler-evisceration into lp:maas

2012-08-15 Thread Gavin Panella
I think jtv has done this now. -- https://code.launchpad.net/~allenap/maas/pxe-file-import-merciless-cobbler-evisceration/+merge/118195 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/maas/pxe-file-import-merciless-cobbler-evisceration into lp:maas.

[Launchpad-reviewers] [Merge] lp:~allenap/maas/pxe-file-import-merciless-cobbler-evisceration into lp:maas

2012-08-15 Thread Gavin Panella
The proposal to merge lp:~allenap/maas/pxe-file-import-merciless-cobbler-evisceration into lp:maas has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~allenap/maas/pxe-file-import-merciless-cobbler-evisceration/+merge/118195 --

[Launchpad-reviewers] [Merge] lp:~racb/maas/automation into lp:maas

2012-08-15 Thread Robie Basak
Robie Basak has proposed merging lp:~racb/maas/automation into lp:maas. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~racb/maas/automation/+merge/119708 Fixes around HACKING.txt and automatically getting a MAAS development

[Launchpad-reviewers] [Merge] lp:~stub/launchpad/db-deploy into lp:launchpad

2012-08-15 Thread Stuart Bishop
Stuart Bishop has proposed merging lp:~stub/launchpad/db-deploy into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #906222 in Launchpad itself: More BAD_USERS creating false positives during fast downtime updates

Re: [Launchpad-reviewers] [Merge] lp:~stub/launchpad/db-deploy into lp:launchpad

2012-08-15 Thread Stuart Bishop
Review: Approve -- https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/119714 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

[Launchpad-reviewers] [Merge] lp:~stub/launchpad/db-deploy into lp:launchpad

2012-08-15 Thread Stuart Bishop
The proposal to merge lp:~stub/launchpad/db-deploy into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/119714 -- https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/119714 Your team

[Launchpad-reviewers] [Merge] lp:~stub/launchpad/db-deploy into lp:launchpad

2012-08-15 Thread noreply
The proposal to merge lp:~stub/launchpad/db-deploy into lp:launchpad has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/119714 -- https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/119714 Your team

[Launchpad-reviewers] [Merge] lp:~sinzui/launchpad/edit-team-description into lp:launchpad

2012-08-15 Thread Curtis Hovey
Curtis Hovey has proposed merging lp:~sinzui/launchpad/edit-team-description into lp:launchpad. Requested reviews: j.c.sackett (jcsackett) Related bugs: Bug #5283 in Launchpad itself: Home page vs. Description is misleading https://bugs.launchpad.net/launchpad/+bug/5283 For more details,

Re: [Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/no-oops-request-daily-build into lp:launchpad

2012-08-15 Thread Curtis Hovey
Review: Approve code Thank you. -- https://code.launchpad.net/~stevenk/launchpad/no-oops-request-daily-build/+merge/119654 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/double-unmute-oops into lp:launchpad

2012-08-15 Thread Curtis Hovey
Review: Approve code Thank you. -- https://code.launchpad.net/~stevenk/launchpad/double-unmute-oops/+merge/119663 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad

2012-08-15 Thread Curtis Hovey
Review: Approve code Thank you. -- https://code.launchpad.net/~stevenk/launchpad/fix-bug-623281/+merge/119674 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad

2012-08-15 Thread Curtis Hovey
The proposal to merge lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~stevenk/launchpad/fix-bug-623281/+merge/119674 --

Re: [Launchpad-reviewers] [Merge] lp:~sinzui/launchpad/edit-team-description into lp:launchpad

2012-08-15 Thread j.c.sackett
Review: Approve This looks good, Curtis. Thanks. -- https://code.launchpad.net/~sinzui/launchpad/edit-team-description/+merge/119759 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

[Launchpad-reviewers] [Merge] lp:~sinzui/launchpad/edit-team-description into lp:launchpad

2012-08-15 Thread j.c.sackett
The proposal to merge lp:~sinzui/launchpad/edit-team-description into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~sinzui/launchpad/edit-team-description/+merge/119759 --

[Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/inaccessible-duplicates-link into lp:launchpad

2012-08-15 Thread j.c.sackett
j.c.sackett has proposed merging lp:~jcsackett/launchpad/inaccessible-duplicates-link into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~jcsackett/launchpad/inaccessible-duplicates-link/+merge/119781 Summary

[Launchpad-reviewers] [Merge] lp:~jameinel/launchpad/loggerhead-clear-cache into lp:launchpad

2012-08-15 Thread John A Meinel
John A Meinel has proposed merging lp:~jameinel/launchpad/loggerhead-clear-cache into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~jameinel/launchpad/loggerhead-clear-cache/+merge/119793 This is a small

[Launchpad-reviewers] [Merge] lp:~bac/lpsetup/host2target into lp:lpsetup

2012-08-15 Thread Brad Crittenden
Brad Crittenden has proposed merging lp:~bac/lpsetup/host2target into lp:lpsetup. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~bac/lpsetup/host2target/+merge/119795 Change 'host' to 'target' everywhere to make it less

Re: [Launchpad-reviewers] [Merge] lp:~jameinel/launchpad/loggerhead-clear-cache into lp:launchpad

2012-08-15 Thread Robert Collins
Review: Approve -- https://code.launchpad.net/~jameinel/launchpad/loggerhead-clear-cache/+merge/119793 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to :

[Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thinks-it-is into lp:launchpad

2012-08-15 Thread j.c.sackett
j.c.sackett has proposed merging lp:~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thinks-it-is into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad

2012-08-15 Thread Steve Kowalik
The proposal to merge lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad has been updated. Commit Message changed to: The comment before IBuilder.currentjob must of been true at some point, but it isn't now, so remove it. For more details, see:

Re: [Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thinks-it-is into lp:launchpad

2012-08-15 Thread Curtis Hovey
Review: Approve code Thank you. -- https://code.launchpad.net/~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thinks-it-is/+merge/119798 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

[Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thinks-it-is into lp:launchpad

2012-08-15 Thread Curtis Hovey
The proposal to merge lp:~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thinks-it-is into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jcsackett/launchpad/commentlist-isnt-as-smart-as-it-thinks-it-is/+merge/119798

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/double-unmute-oops into lp:launchpad

2012-08-15 Thread Steve Kowalik
The proposal to merge lp:~stevenk/launchpad/double-unmute-oops into lp:launchpad has been updated. Commit Message changed to: Force IBug.unmute() to deal if the bug is already muted. For more details, see: https://code.launchpad.net/~stevenk/launchpad/double-unmute-oops/+merge/119663 --

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/double-unmute-oops into lp:launchpad

2012-08-15 Thread Steve Kowalik
The proposal to merge lp:~stevenk/launchpad/double-unmute-oops into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~stevenk/launchpad/double-unmute-oops/+merge/119663 --

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad

2012-08-15 Thread noreply
The proposal to merge lp:~stevenk/launchpad/fix-bug-623281 into lp:launchpad has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~stevenk/launchpad/fix-bug-623281/+merge/119674 --

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/no-oops-request-daily-build into lp:launchpad

2012-08-15 Thread Steve Kowalik
The proposal to merge lp:~stevenk/launchpad/no-oops-request-daily-build into lp:launchpad has been updated. Commit Message changed to: Skip obsolete series in ISourcePackageRecipe.performDailyBuild(), and warn users about them. For more details, see:

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/no-oops-request-daily-build into lp:launchpad

2012-08-15 Thread Steve Kowalik
The proposal to merge lp:~stevenk/launchpad/no-oops-request-daily-build into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~stevenk/launchpad/no-oops-request-daily-build/+merge/119654 --

Re: [Launchpad-reviewers] [Merge] lp:~jcsackett/launchpad/inaccessible-duplicates-link into lp:launchpad

2012-08-15 Thread Curtis Hovey
Review: Needs Information code Is it possible to move the *.duplicateof.default_bugtask.target logic into a view so that the tal does not execute non-compiled python? Maybe we could use a function that a properties on the two views use? --

[Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/edit-sharing-policies-1036437 into lp:launchpad

2012-08-15 Thread Curtis Hovey
The proposal to merge lp:~wallyworld/launchpad/edit-sharing-policies-1036437 into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~wallyworld/launchpad/edit-sharing-policies-1036437/+merge/119466 --

Re: [Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/edit-sharing-policies-1036437 into lp:launchpad

2012-08-15 Thread Curtis Hovey
Review: Approve code We agreed to use Williams UI and land your open branches. We will then update the UI to be smaller and get users to give us feedback. -- https://code.launchpad.net/~wallyworld/launchpad/edit-sharing-policies-1036437/+merge/119466 Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/edit-sharing-policies2-1036437 into lp:launchpad

2012-08-15 Thread Ian Booth
The proposal to merge lp:~wallyworld/launchpad/edit-sharing-policies2-1036437 into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~wallyworld/launchpad/edit-sharing-policies2-1036437/+merge/119501 --

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/no-more-add-bug-supervisor into lp:launchpad

2012-08-15 Thread Steve Kowalik
Steve Kowalik has proposed merging lp:~stevenk/launchpad/no-more-add-bug-supervisor into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #1029724 in Launchpad itself: Retargeting a private bug notifies maintainer and bug supervisor without

Re: [Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/no-more-add-bug-supervisor into lp:launchpad

2012-08-15 Thread Michael Casadevall
Hooray, less bug email! -- https://code.launchpad.net/~stevenk/launchpad/no-more-add-bug-supervisor/+merge/119818 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/no-more-add-bug-supervisor into lp:launchpad

2012-08-15 Thread Steve Kowalik
The proposal to merge lp:~stevenk/launchpad/no-more-add-bug-supervisor into lp:launchpad has been updated. Commit Message changed to: No longer explicitly notify the bug supervisor and maintainer when a private bug is re-targeted, since we have structural subscriptions working for private

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/no-more-add-bug-supervisor into lp:launchpad

2012-08-15 Thread Steve Kowalik
The proposal to merge lp:~stevenk/launchpad/no-more-add-bug-supervisor into lp:launchpad has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~stevenk/launchpad/no-more-add-bug-supervisor/+merge/119818 --

Re: [Launchpad-reviewers] [Merge] lp:~allenap/maas/pxe-file-import-merciless-cobbler-evisceration into lp:maas

2012-08-15 Thread Julian Edwards
He did indeed. There's more to be done of course :) -- https://code.launchpad.net/~allenap/maas/pxe-file-import-merciless-cobbler-evisceration/+merge/118195 Your team Launchpad code reviewers is requested to review the proposed merge of

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/double-unmute-oops into lp:launchpad

2012-08-15 Thread noreply
The proposal to merge lp:~stevenk/launchpad/double-unmute-oops into lp:launchpad has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~stevenk/launchpad/double-unmute-oops/+merge/119663 --

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/no-oops-request-daily-build into lp:launchpad

2012-08-15 Thread noreply
The proposal to merge lp:~stevenk/launchpad/no-oops-request-daily-build into lp:launchpad has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~stevenk/launchpad/no-oops-request-daily-build/+merge/119654 --

[Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/bugtask-title-truncation-1037364 into lp:launchpad

2012-08-15 Thread Ian Booth
Ian Booth has proposed merging lp:~wallyworld/launchpad/bugtask-title-truncation-1037364 into lp:launchpad. Requested reviews: Ian Booth (wallyworld) Related bugs: Bug #1037364 in Launchpad itself: Long bug titles are now truncated, obscuring important information

Re: [Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/bugtask-title-truncation-1037364 into lp:launchpad

2012-08-15 Thread Ian Booth
Review: Approve Self approve -- https://code.launchpad.net/~wallyworld/launchpad/bugtask-title-truncation-1037364/+merge/119828 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

[Launchpad-reviewers] [Merge] lp:~wallyworld/launchpad/bugtask-title-truncation-1037364 into lp:launchpad

2012-08-15 Thread noreply
The proposal to merge lp:~wallyworld/launchpad/bugtask-title-truncation-1037364 into lp:launchpad has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~wallyworld/launchpad/bugtask-title-truncation-1037364/+merge/119828 --

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/no-structsub-for-bug-supervisor into lp:launchpad

2012-08-15 Thread Steve Kowalik
Steve Kowalik has proposed merging lp:~stevenk/launchpad/no-structsub-for-bug-supervisor into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~stevenk/launchpad/no-structsub-for-bug-supervisor/+merge/119831 No

[Launchpad-reviewers] [Merge] lp:~stevenk/launchpad/no-more-add-bug-supervisor into lp:launchpad

2012-08-15 Thread noreply
The proposal to merge lp:~stevenk/launchpad/no-more-add-bug-supervisor into lp:launchpad has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~stevenk/launchpad/no-more-add-bug-supervisor/+merge/119818 --