[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-branch-commitsForDays into lp:launchpad

2016-10-14 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-branch-commitsForDays into lp:launchpad. Commit message: Remove unused Branch.commitsForDays. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-new-view into lp:launchpad

2016-10-14 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/codeimport-git-new-view into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/codeimport-git-new-view/+merge/308545 -- Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-worker-fixes into lp:launchpad

2016-10-14 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/codeimport-git-worker-fixes into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/codeimport-git-worker-fixes/+merge/308540 -- Your team Launchpad code reviewers

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-webservice into lp:launchpad

2016-10-14 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/codeimport-git-webservice into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/codeimport-git-webservice/+merge/308399 -- Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-edit-views into lp:launchpad

2016-10-14 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/codeimport-git-edit-views into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/codeimport-git-edit-views/+merge/308398 -- Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-git-recipes-ff into lp:launchpad

2016-10-14 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/remove-git-recipes-ff into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/remove-git-recipes-ff/+merge/308539 -- Your team Launchpad code reviewers is

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-new-view into lp:launchpad

2016-10-14 Thread William Grant
Review: Approve code Diff comments: > === modified file 'lib/lp/code/browser/codeimport.py' > --- lib/lp/code/browser/codeimport.py 2016-10-14 17:29:44 + > +++ lib/lp/code/browser/codeimport.py 2016-10-14 17:29:44 + > @@ -243,9 +250,10 @@ > git_repo_url = URIField( >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-webservice into lp:launchpad

2016-10-14 Thread William Grant
Review: Approve code Diff comments: > > === modified file 'lib/lp/code/interfaces/hasbranches.py' > --- lib/lp/code/interfaces/hasbranches.py 2016-09-07 02:46:20 + > +++ lib/lp/code/interfaces/hasbranches.py 2016-10-14 16:44:55 + > @@ -170,19 +174,31 @@ >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-edit-views into lp:launchpad

2016-10-14 Thread William Grant
Review: Approve code Diff comments: > > === modified file 'lib/lp/code/browser/configure.zcml' > --- lib/lp/code/browser/configure.zcml2016-10-14 15:44:39 + > +++ lib/lp/code/browser/configure.zcml2016-10-14 16:43:43 + > @@ -881,6 +887,18 @@ >

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-worker-fixes into lp:launchpad

2016-10-14 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/codeimport-git-worker-fixes/+merge/308540 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-git-recipes-ff into lp:launchpad

2016-10-14 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-git-recipes-ff/+merge/308539 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-new-view into lp:launchpad

2016-10-14 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/codeimport-git-new-view into lp:launchpad with lp:~cjwatson/launchpad/codeimport-git-worker-fixes as a prerequisite. Commit message: Extend CodeImportNewView to be able to create Git-to-Git code imports. Requested reviews: Launchpad

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-worker-fixes into lp:launchpad

2016-10-14 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/codeimport-git-worker-fixes into lp:launchpad with lp:~cjwatson/launchpad/codeimport-git-webservice as a prerequisite. Commit message: Miscellaneous tweaks to the Git-to-Git import worker, mainly logging. Requested reviews: Launchpad

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-git-recipes-ff into lp:launchpad

2016-10-14 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-git-recipes-ff into lp:launchpad. Commit message: Remove the Git recipes feature flag. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-list-git into lp:launchpad

2016-10-14 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/codeimport-list-git into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/codeimport-list-git/+merge/308387 -- Your team Launchpad code reviewers is subscribed to

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-read-only-views into lp:launchpad

2016-10-14 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/codeimport-git-read-only-views into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/codeimport-git-read-only-views/+merge/308374 -- Your team Launchpad code

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-code-import-security-deletion into lp:launchpad

2016-10-14 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/git-code-import-security-deletion into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/git-code-import-security-deletion/+merge/308319 -- Your team Launchpad

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-code-import-security-deletion into lp:launchpad

2016-10-14 Thread Colin Watson
Diff comments: > > === modified file 'lib/lp/code/interfaces/gitrepository.py' > --- lib/lp/code/interfaces/gitrepository.py 2016-10-05 09:54:42 + > +++ lib/lp/code/interfaces/gitrepository.py 2016-10-13 12:29:37 + > @@ -946,14 +951,24 @@ > return identities > > > -def

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-xmlrpc-auth-params-cleanup into lp:launchpad

2016-10-14 Thread noreply
The proposal to merge lp:~cjwatson/launchpad/git-xmlrpc-auth-params-cleanup into lp:launchpad has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~cjwatson/launchpad/git-xmlrpc-auth-params-cleanup/+merge/308494 -- Your team Launchpad code

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/python-oops-wsgi/hide-macaroons into lp:python-oops-wsgi

2016-10-14 Thread Celso Providelo
Review: Approve Thanks, Colin. Nice catch. -- https://code.launchpad.net/~cjwatson/python-oops-wsgi/hide-macaroons/+merge/308489 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/python-oops-wsgi/hide-macaroons into lp:python-oops-wsgi.

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-xmlrpc-auth-params-cleanup into lp:launchpad

2016-10-14 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/git-xmlrpc-auth-params-cleanup/+merge/308494 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-list-git into lp:launchpad

2016-10-14 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/codeimport-list-git/+merge/308387 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-read-only-views into lp:launchpad

2016-10-14 Thread William Grant
Review: Approve code Diff comments: > > === modified file 'lib/lp/code/browser/codeimport.py' > --- lib/lp/code/browser/codeimport.py 2016-10-06 15:59:34 + > +++ lib/lp/code/browser/codeimport.py 2016-10-13 12:55:20 + > @@ -543,6 +549,10 @@ > else: > raise

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-xmlrpc-auth-params-cleanup into lp:launchpad

2016-10-14 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/launchpad/git-xmlrpc-auth-params-cleanup into lp:launchpad. Commit message: Remove old-style authentication parameters handling from GitAPI.translatePath. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/git-code-import-security-deletion into lp:launchpad

2016-10-14 Thread William Grant
Review: Approve code Diff comments: > > === modified file 'lib/lp/code/interfaces/gitrepository.py' > --- lib/lp/code/interfaces/gitrepository.py 2016-10-05 09:54:42 + > +++ lib/lp/code/interfaces/gitrepository.py 2016-10-13 12:29:37 + > @@ -946,14 +951,24 @@ > return

[Launchpad-reviewers] [Merge] lp:~cjwatson/python-oops-wsgi/hide-macaroons into lp:python-oops-wsgi

2016-10-14 Thread Colin Watson
Colin Watson has proposed merging lp:~cjwatson/python-oops-wsgi/hide-macaroons into lp:python-oops-wsgi. Commit message: Hide sensitive information in HTTP_AUTHORIZATION headers. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: