Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/simplify-buildout-bin-python-easy into lp:launchpad

2017-01-18 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/simplify-buildout-bin-python-easy/+merge/314976 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/simplify-buildout-bin-shell into lp:launchpad

2017-01-18 Thread William Grant
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/simplify-buildout-bin-shell/+merge/314973 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/normalise-mlist-sync into lp:launchpad

2017-01-18 Thread William Grant
Review: Approve code Intriguingly, this reverses a change that was made only five years ago, though I cannot discern the rationale. It is conceivable that it was to force it to use python2.7, though I can't see why it was only ever that script. --

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/testopenid-certificate into lp:launchpad

2017-01-18 Thread William Grant
Review: Approve code Diff comments: > > === modified file 'lib/lp/services/webapp/login.py' > --- lib/lp/services/webapp/login.py 2016-05-19 02:02:39 + > +++ lib/lp/services/webapp/login.py 2017-01-14 15:45:28 + > @@ -160,11 +159,7 @@ > name='+basiclogin') > > >