Review: Approve code
--
https://code.launchpad.net/~cjwatson/launchpad/docutils-0.14/+merge/335551
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Review: Approve code
Diff comments:
>
> === modified file 'sourcecode/Makefile'
> --- sourcecode/Makefile 2011-11-07 20:29:29 +
> +++ sourcecode/Makefile 2017-12-22 10:00:58 +
> @@ -3,7 +3,7 @@
> # the ones we test. If we fix them all to have EITHER a good makefile
> #
Review: Approve code
We'll probably need to tweak staging configs a bit to effectively test this.
Have you verified in any depth against a non-prod Swift?
Diff comments:
>
> === modified file 'lib/lp/services/librarianserver/swift.py'
> --- lib/lp/services/librarianserver/swift.py 2015-02-16
Review: Approve code
Diff comments:
> === modified file 'Makefile'
> --- Makefile 2018-01-01 20:24:26 +
> +++ Makefile 2018-01-02 04:49:50 +
> @@ -472,6 +468,7 @@
> -e 's,%LISTEN_ADDRESS%,$(LISTEN_ADDRESS),' \
> configs/development/local-launchpad-apache >
Review: Approve code
--
https://code.launchpad.net/~cjwatson/launchpad/eslint-eqeqeq/+merge/335615
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Review: Approve code
--
https://code.launchpad.net/~cjwatson/launchpad/eslint-regexes/+merge/335613
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Colin Watson has proposed merging lp:~cjwatson/launchpad/tidy-makefile into
lp:launchpad.
Commit message:
Tidy up various minor problems in the top-level Makefile.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #483782 in Launchpad itself: "The Makefile
Colin Watson has proposed merging lp:~cjwatson/launchpad/eslint-regexes into
lp:launchpad.
Commit message:
Remove useless escapes in JS regexes. pocketlint wanted these, but eslint
doesn't.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
The proposal to merge lp:~cjwatson/launchpad/eslint into lp:launchpad has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/eslint/+merge/327884
--
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
The proposal to merge lp:~cjwatson/launchpad/2018-update into lp:launchpad has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/2018-update/+merge/335612
--
Your team Launchpad code reviewers is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~cjwatson/launchpad/2018-update/+merge/335612
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to :
Colin Watson has proposed merging lp:~cjwatson/launchpad/2018-update into
lp:launchpad.
Commit message:
Update copyright years to 2018.
Requested reviews:
Colin Watson (cjwatson)
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/2018-update/+merge/335612
--
Your team
Diff comments:
>
> === modified file 'utilities/lint'
> --- utilities/lint2017-01-17 22:23:39 +
> +++ utilities/lint2017-07-23 03:47:01 +
> @@ -31,10 +31,21 @@
> fi
>
> # Sample data contains auto generated files with long lines.
> -pocketlint_files=`echo "$files" | env -i
13 matches
Mail list logo
